X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=opendaylight%2Fconfig%2Fnetty-event-executor-config%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fconfig%2Fyang%2Fnetty%2Feventexecutor%2FAutoCloseableEventExecutor.java;h=a7b931be62589f003c08112493a01075477a5a08;hb=refs%2Fchanges%2F95%2F101395%2F3;hp=b12fc67609af8d10095475d2d6ac449f735294b5;hpb=14c92df74247c884a43c5aaea2f154992b0ec798;p=controller.git diff --git a/opendaylight/config/netty-event-executor-config/src/main/java/org/opendaylight/controller/config/yang/netty/eventexecutor/AutoCloseableEventExecutor.java b/opendaylight/config/netty-event-executor-config/src/main/java/org/opendaylight/controller/config/yang/netty/eventexecutor/AutoCloseableEventExecutor.java index b12fc67609..a7b931be62 100644 --- a/opendaylight/config/netty-event-executor-config/src/main/java/org/opendaylight/controller/config/yang/netty/eventexecutor/AutoCloseableEventExecutor.java +++ b/opendaylight/config/netty-event-executor-config/src/main/java/org/opendaylight/controller/config/yang/netty/eventexecutor/AutoCloseableEventExecutor.java @@ -9,7 +9,6 @@ package org.opendaylight.controller.config.yang.netty.eventexecutor; import com.google.common.reflect.AbstractInvocationHandler; import com.google.common.reflect.Reflection; -import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import io.netty.util.concurrent.EventExecutor; import io.netty.util.concurrent.GlobalEventExecutor; import io.netty.util.concurrent.ImmediateEventExecutor; @@ -17,43 +16,26 @@ import java.lang.reflect.Method; import java.util.concurrent.TimeUnit; public interface AutoCloseableEventExecutor extends EventExecutor, AutoCloseable { - static AutoCloseableEventExecutor globalEventExecutor() { - return CloseableEventExecutorMixin.createCloseableProxy(GlobalEventExecutor.INSTANCE); + return createCloseableProxy(GlobalEventExecutor.INSTANCE); } static AutoCloseableEventExecutor immediateEventExecutor() { - return CloseableEventExecutorMixin.createCloseableProxy(ImmediateEventExecutor.INSTANCE); + return createCloseableProxy(ImmediateEventExecutor.INSTANCE); } - class CloseableEventExecutorMixin implements AutoCloseable { - public static final int DEFAULT_SHUTDOWN_SECONDS = 1; - private final EventExecutor eventExecutor; - - public CloseableEventExecutorMixin(final EventExecutor eventExecutor) { - this.eventExecutor = eventExecutor; - } - - @Override - @SuppressFBWarnings(value = "UC_USELESS_VOID_METHOD", justification = "False positive") - public void close() { - eventExecutor.shutdownGracefully(0, DEFAULT_SHUTDOWN_SECONDS, TimeUnit.SECONDS); - } - - static AutoCloseableEventExecutor createCloseableProxy(final EventExecutor eventExecutor) { - final CloseableEventExecutorMixin closeableEventExecutor = new CloseableEventExecutorMixin(eventExecutor); - return Reflection.newProxy(AutoCloseableEventExecutor.class, new AbstractInvocationHandler() { - @Override - protected Object handleInvocation(final Object proxy, final Method method, final Object[] args) - throws Throwable { - if (method.getName().equals("close")) { - closeableEventExecutor.close(); - return null; - } else { - return method.invoke(closeableEventExecutor.eventExecutor, args); - } + private static AutoCloseableEventExecutor createCloseableProxy(final EventExecutor eventExecutor) { + return Reflection.newProxy(AutoCloseableEventExecutor.class, new AbstractInvocationHandler() { + @Override + protected Object handleInvocation(final Object proxy, final Method method, final Object[] args) + throws Throwable { + if (method.getName().equals("close")) { + eventExecutor.shutdownGracefully(0, 1, TimeUnit.SECONDS); + return null; + } else { + return method.invoke(eventExecutor, args); } - }); - } + } + }); } }