X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=opendaylight%2Fforwardingrulesmanager%2Fapi%2Fsrc%2Ftest%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fforwardingrulesmanager%2FfrmTest.java;h=48e1f07716ec267ddb52340e3ea21ef64ac8cebd;hb=e640f23d9c37afac9ca51f48e155302bc65327ed;hp=176d8e9ebdfea8a2f0bb341eed68177d69a235ed;hpb=3e5c78a72ae6b2341240bee8f122b990427f1ee0;p=controller.git diff --git a/opendaylight/forwardingrulesmanager/api/src/test/java/org/opendaylight/controller/forwardingrulesmanager/frmTest.java b/opendaylight/forwardingrulesmanager/api/src/test/java/org/opendaylight/controller/forwardingrulesmanager/frmTest.java index 176d8e9ebd..48e1f07716 100644 --- a/opendaylight/forwardingrulesmanager/api/src/test/java/org/opendaylight/controller/forwardingrulesmanager/frmTest.java +++ b/opendaylight/forwardingrulesmanager/api/src/test/java/org/opendaylight/controller/forwardingrulesmanager/frmTest.java @@ -19,8 +19,6 @@ import java.util.concurrent.ConcurrentMap; import org.junit.Assert; import org.junit.Test; -import org.opendaylight.controller.forwardingrulesmanager.FlowConfig; -import org.opendaylight.controller.forwardingrulesmanager.FlowEntry; import org.opendaylight.controller.sal.action.Action; import org.opendaylight.controller.sal.action.ActionType; import org.opendaylight.controller.sal.action.Controller; @@ -471,13 +469,14 @@ public class frmTest { @Test public void testStatusToggle() throws UnknownHostException { + // default is install in Hw FlowConfig fc = new FlowConfig(); fc.toggleInstallation(); - Assert.assertTrue(fc.installInHw()); - fc.toggleInstallation(); Assert.assertFalse(fc.installInHw()); fc.toggleInstallation(); Assert.assertTrue(fc.installInHw()); + fc.toggleInstallation(); + Assert.assertFalse(fc.installInHw()); } @@ -523,6 +522,12 @@ public class frmTest { Assert.assertTrue(status.getDescription().contains("Node is null")); fc.setNode(Node.fromString(Node.NodeIDType.OPENFLOW, "1")); + Assert.assertFalse(fc.validate(null).isSuccess()); + List actions = new ArrayList(); + fc.setActions(actions); + Assert.assertFalse(fc.validate(null).isSuccess()); + actions.add("OUTPUT=2"); + fc.setActions(actions); Assert.assertTrue(fc.validate(null).isSuccess()); fc.setPriority("-1"); @@ -541,11 +546,6 @@ public class frmTest { fc.setCookie("100"); Assert.assertTrue(fc.validate(null).isSuccess()); - fc.setIngressPort("-1"); - status = fc.validate(null); - Assert.assertFalse(status.isSuccess()); - Assert.assertTrue(status.getDescription().contains("is not valid for the Switch")); - fc.setIngressPort("100"); Assert.assertTrue(fc.validate(null).isSuccess());