X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fcds-access-api%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Faccess%2Fcommands%2FModifyTransactionRequestProxyV1.java;h=384c889af8ded8aeef6a84b42f5943eb6f53bba8;hb=7ce039b3e55d153fc75bc88198c49536ab83befc;hp=846756dc3a365d9920bd4461d535796b8a90593e;hpb=93fd87f9e46446be9eb8538669ebbfade205590e;p=controller.git diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ModifyTransactionRequestProxyV1.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ModifyTransactionRequestProxyV1.java index 846756dc3a..384c889af8 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ModifyTransactionRequestProxyV1.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ModifyTransactionRequestProxyV1.java @@ -7,8 +7,9 @@ */ package org.opendaylight.controller.cluster.access.commands; +import static java.util.Objects.requireNonNull; + import akka.actor.ActorRef; -import com.google.common.base.Preconditions; import com.google.common.collect.ImmutableList; import java.io.IOException; import java.io.ObjectInput; @@ -17,9 +18,10 @@ import java.util.ArrayList; import java.util.List; import java.util.Optional; import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier; -import org.opendaylight.controller.cluster.datastore.node.utils.stream.NormalizedNodeDataInput; -import org.opendaylight.controller.cluster.datastore.node.utils.stream.NormalizedNodeDataOutput; -import org.opendaylight.controller.cluster.datastore.node.utils.stream.NormalizedNodeInputOutput; +import org.opendaylight.yangtools.yang.data.codec.binfmt.NormalizedNodeDataInput; +import org.opendaylight.yangtools.yang.data.codec.binfmt.NormalizedNodeDataOutput; +import org.opendaylight.yangtools.yang.data.codec.binfmt.NormalizedNodeStreamVersion; +import org.opendaylight.yangtools.yang.data.impl.schema.ReusableImmutableNormalizedNodeStreamWriter; /** * Externalizable proxy for use with {@link ExistsTransactionRequest}. It implements the initial (Boron) serialization @@ -29,8 +31,10 @@ import org.opendaylight.controller.cluster.datastore.node.utils.stream.Normalize */ final class ModifyTransactionRequestProxyV1 extends AbstractTransactionRequestProxy { private static final long serialVersionUID = 1L; + private List modifications; private Optional protocol; + private transient NormalizedNodeStreamVersion streamVersion; // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to // be able to create instances via reflection. @@ -41,8 +45,9 @@ final class ModifyTransactionRequestProxyV1 extends AbstractTransactionRequestPr ModifyTransactionRequestProxyV1(final ModifyTransactionRequest request) { super(request); - this.modifications = Preconditions.checkNotNull(request.getModifications()); + this.modifications = requireNonNull(request.getModifications()); this.protocol = request.getPersistenceProtocol(); + this.streamVersion = request.getVersion().getStreamVersion(); } @Override @@ -54,9 +59,11 @@ final class ModifyTransactionRequestProxyV1 extends AbstractTransactionRequestPr final int size = in.readInt(); if (size != 0) { modifications = new ArrayList<>(size); - final NormalizedNodeDataInput nnin = NormalizedNodeInputOutput.newDataInput(in); + final NormalizedNodeDataInput nnin = NormalizedNodeDataInput.newDataInput(in); + final ReusableImmutableNormalizedNodeStreamWriter writer = + ReusableImmutableNormalizedNodeStreamWriter.create(); for (int i = 0; i < size; ++i) { - modifications.add(TransactionModification.readFrom(nnin)); + modifications.add(TransactionModification.readFrom(nnin, writer)); } } else { modifications = ImmutableList.of(); @@ -70,7 +77,7 @@ final class ModifyTransactionRequestProxyV1 extends AbstractTransactionRequestPr out.writeByte(PersistenceProtocol.byteValue(protocol.orElse(null))); out.writeInt(modifications.size()); if (!modifications.isEmpty()) { - try (NormalizedNodeDataOutput nnout = NormalizedNodeInputOutput.newDataOutput(out)) { + try (NormalizedNodeDataOutput nnout = streamVersion.newDataOutput(out)) { for (TransactionModification op : modifications) { op.writeTo(nnout); }