X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fcds-access-api%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Faccess%2Fconcepts%2FTransactionIdentifier.java;h=ea72c847501a79a8982af88b1fd6aadfc90784c4;hb=HEAD;hp=b03e2cd5c34e0a2ddf468e49c4e8b16376f35f4b;hpb=d92bd0e575983b3d6a09a73089ef8f9c62f94eaa;p=controller.git diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/TransactionIdentifier.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/TransactionIdentifier.java index b03e2cd5c3..ea72c84750 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/TransactionIdentifier.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/TransactionIdentifier.java @@ -7,15 +7,11 @@ */ package org.opendaylight.controller.cluster.access.concepts; -import static com.google.common.base.Verify.verifyNotNull; import static java.util.Objects.requireNonNull; import java.io.DataInput; import java.io.DataOutput; -import java.io.Externalizable; import java.io.IOException; -import java.io.ObjectInput; -import java.io.ObjectOutput; import org.eclipse.jdt.annotation.NonNull; import org.opendaylight.yangtools.concepts.WritableIdentifier; import org.opendaylight.yangtools.concepts.WritableObjects; @@ -24,60 +20,6 @@ import org.opendaylight.yangtools.concepts.WritableObjects; * Globally-unique identifier of a transaction. */ public final class TransactionIdentifier implements WritableIdentifier { - interface SerialForm extends Externalizable { - @NonNull TransactionIdentifier identifier(); - - void setIdentifier(@NonNull TransactionIdentifier identifier); - - @java.io.Serial - Object readResolve(); - - @Override - default void readExternal(final ObjectInput in) throws IOException { - setIdentifier(new TransactionIdentifier(LocalHistoryIdentifier.readFrom(in), WritableObjects.readLong(in))); - } - - @Override - default void writeExternal(final ObjectOutput out) throws IOException { - final var id = identifier(); - id.getHistoryId().writeTo(out); - WritableObjects.writeLong(out, id.getTransactionId()); - } - } - - private static final class Proxy implements SerialForm { - @java.io.Serial - private static final long serialVersionUID = 1L; - - private TransactionIdentifier identifier; - - // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to - // be able to create instances via reflection. - @SuppressWarnings("checkstyle:RedundantModifier") - public Proxy() { - // For Externalizable - } - - Proxy(final TransactionIdentifier identifier) { - this.identifier = requireNonNull(identifier); - } - - @Override - public @NonNull TransactionIdentifier identifier() { - return verifyNotNull(identifier); - } - - @Override - public void setIdentifier(final TransactionIdentifier identifier) { - this.identifier = requireNonNull(identifier); - } - - @Override - public Object readResolve() { - return identifier(); - } - } - @java.io.Serial private static final long serialVersionUID = 1L; @@ -139,6 +81,6 @@ public final class TransactionIdentifier implements WritableIdentifier { @java.io.Serial private Object writeReplace() { - return new Proxy(this); + return new TI(this); } }