X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fmdsal-trace%2Fdom-impl%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fmd%2Fsal%2Ftrace%2Fclosetracker%2Fimpl%2FCloseTrackedTrait.java;h=f96daaa425566f328540b1268f95ae1af08bd798;hb=refs%2Fchanges%2F11%2F80211%2F6;hp=4fe1e12ec8e83288c5339cbe9b3e1fec8a3df01e;hpb=fe73467bcc8a500c80bfcfc8b87053e70341611f;p=controller.git diff --git a/opendaylight/md-sal/mdsal-trace/dom-impl/src/main/java/org/opendaylight/controller/md/sal/trace/closetracker/impl/CloseTrackedTrait.java b/opendaylight/md-sal/mdsal-trace/dom-impl/src/main/java/org/opendaylight/controller/md/sal/trace/closetracker/impl/CloseTrackedTrait.java index 4fe1e12ec8..f96daaa425 100644 --- a/opendaylight/md-sal/mdsal-trace/dom-impl/src/main/java/org/opendaylight/controller/md/sal/trace/closetracker/impl/CloseTrackedTrait.java +++ b/opendaylight/md-sal/mdsal-trace/dom-impl/src/main/java/org/opendaylight/controller/md/sal/trace/closetracker/impl/CloseTrackedTrait.java @@ -7,8 +7,10 @@ */ package org.opendaylight.controller.md.sal.trace.closetracker.impl; -import java.util.Objects; -import javax.annotation.Nullable; +import static java.util.Objects.requireNonNull; + +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; +import org.eclipse.jdt.annotation.Nullable; /** * Implementation of {@link CloseTracked} which can be used as a field in @@ -30,6 +32,7 @@ public class CloseTrackedTrait> implements CloseTracke private final CloseTrackedRegistry closeTrackedRegistry; private final CloseTracked realCloseTracked; + @SuppressFBWarnings(value = "NP_STORE_INTO_NONNULL_FIELD", justification = "SpotBugs and JDT annotations") public CloseTrackedTrait(CloseTrackedRegistry transactionChainRegistry, CloseTracked realCloseTracked) { if (transactionChainRegistry.isDebugContextEnabled()) { // NB: We're NOT doing the (expensive) getStackTrace() here just yet (only below) @@ -38,13 +41,13 @@ public class CloseTrackedTrait> implements CloseTracke } else { this.allocationContext = null; } - this.realCloseTracked = Objects.requireNonNull(realCloseTracked, "realCloseTracked"); - this.closeTrackedRegistry = Objects.requireNonNull(transactionChainRegistry, "transactionChainRegistry"); + this.realCloseTracked = requireNonNull(realCloseTracked, "realCloseTracked"); + this.closeTrackedRegistry = requireNonNull(transactionChainRegistry, "transactionChainRegistry"); this.closeTrackedRegistry.add(this); } @Override - @Nullable + @SuppressFBWarnings("PZLA_PREFER_ZERO_LENGTH_ARRAYS") public StackTraceElement[] getAllocationContextStackTrace() { return allocationContext != null ? allocationContext.getStackTrace() : null; }