X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-akka-raft%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Fraft%2FRaftActorContextImpl.java;h=0bf71ab7991b3e87bb4c6afd02577f84d749a730;hb=c2ecbded084e74232719f5d906197f15cc260965;hp=66059b5d62c1b756517cb691ab53f938b42006b0;hpb=cc2566a2570ce97c5ec054fca77f380ca35b942d;p=controller.git diff --git a/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/RaftActorContextImpl.java b/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/RaftActorContextImpl.java index 66059b5d62..0bf71ab799 100644 --- a/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/RaftActorContextImpl.java +++ b/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/RaftActorContextImpl.java @@ -13,7 +13,6 @@ import akka.actor.ActorRef; import akka.actor.ActorSelection; import akka.actor.ActorSystem; import akka.actor.Props; - import com.google.common.annotations.VisibleForTesting; import com.google.common.base.Supplier; import java.util.ArrayList; @@ -24,8 +23,8 @@ import java.util.List; import java.util.Map; import java.util.Set; import org.opendaylight.controller.cluster.DataPersistenceProvider; -import org.opendaylight.controller.cluster.raft.policy.RaftPolicy; import org.opendaylight.controller.cluster.raft.ServerConfigurationPayload.ServerInfo; +import org.opendaylight.controller.cluster.raft.policy.RaftPolicy; import org.slf4j.Logger; public class RaftActorContextImpl implements RaftActorContext { @@ -63,6 +62,8 @@ public class RaftActorContextImpl implements RaftActorContext { private short payloadVersion; + private boolean votingMember = true; + public RaftActorContextImpl(ActorRef actor, ActorContext context, String id, ElectionTerm termInformation, long commitIndex, long lastApplied, Map peerAddresses, ConfigParams configParams, DataPersistenceProvider persistenceProvider, Logger logger) { @@ -181,6 +182,8 @@ public class RaftActorContextImpl implements RaftActorContext { peerAddress = configParams.getPeerAddressResolver().resolve(peerId); peerInfo.setAddress(peerAddress); } + } else { + peerAddress = configParams.getPeerAddressResolver().resolve(peerId); } return peerAddress; @@ -188,10 +191,16 @@ public class RaftActorContextImpl implements RaftActorContext { @Override public void updatePeerIds(ServerConfigurationPayload serverConfig){ - + votingMember = true; + boolean foundSelf = false; Set currentPeers = new HashSet<>(this.getPeerIds()); for(ServerInfo server: serverConfig.getServerConfig()) { - if(!getId().equals(server.getId())) { + if(getId().equals(server.getId())) { + foundSelf = true; + if(!server.isVoting()) { + votingMember = false; + } + } else { VotingState votingState = server.isVoting() ? VotingState.VOTING: VotingState.NON_VOTING; if(!currentPeers.contains(server.getId())) { this.addToPeers(server.getId(), null, votingState); @@ -205,6 +214,11 @@ public class RaftActorContextImpl implements RaftActorContext { for(String peerIdToRemove: currentPeers) { this.removePeer(peerIdToRemove); } + + if(!foundSelf) { + votingMember = false; + } + setDynamicServerConfigurationInUse(); } @@ -217,8 +231,13 @@ public class RaftActorContextImpl implements RaftActorContext { peerInfoMap.put(id, new PeerInfo(id, address, votingState)); } - @Override public void removePeer(String name) { - peerInfoMap.remove(name); + @Override + public void removePeer(String name) { + if(getId().equals(name)) { + votingMember = false; + } else { + peerInfoMap.remove(name); + } } @Override public ActorSelection getPeerActorSelection(String peerId) { @@ -283,7 +302,7 @@ public class RaftActorContextImpl implements RaftActorContext { } @Override - public ServerConfigurationPayload getPeerServerInfo() { + public ServerConfigurationPayload getPeerServerInfo(boolean includeSelf) { if (!isDynamicServerConfigurationInUse()) { return null; } @@ -293,7 +312,15 @@ public class RaftActorContextImpl implements RaftActorContext { newConfig.add(new ServerInfo(peer.getId(), peer.isVoting())); } - newConfig.add(new ServerInfo(getId(), true)); + if(includeSelf) { + newConfig.add(new ServerInfo(getId(), votingMember)); + } + return (new ServerConfigurationPayload(newConfig)); } + + @Override + public boolean isVotingMember() { + return votingMember; + } }