X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-akka-raft%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Fraft%2FRaftActorServerConfigurationSupport.java;h=29641cb00e441d5dedc5e7cccccd69bb0b0e6d3a;hb=d0f46920468c8e4b67c68bd9058572b2d10d75f1;hp=3f030d0ff05bc61f5af07a1a4e9b962d81864fae;hpb=2d60632f7cf63712e8357a3cf3fc40d83366e5e6;p=controller.git diff --git a/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/RaftActorServerConfigurationSupport.java b/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/RaftActorServerConfigurationSupport.java index 3f030d0ff0..29641cb00e 100644 --- a/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/RaftActorServerConfigurationSupport.java +++ b/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/RaftActorServerConfigurationSupport.java @@ -7,10 +7,11 @@ */ package org.opendaylight.controller.cluster.raft; +import static java.util.Objects.requireNonNull; + import akka.actor.ActorRef; import akka.actor.ActorSelection; import akka.actor.Cancellable; -import com.google.common.base.Preconditions; import java.util.ArrayDeque; import java.util.ArrayList; import java.util.Collection; @@ -19,7 +20,7 @@ import java.util.List; import java.util.Map; import java.util.Queue; import java.util.UUID; -import javax.annotation.Nullable; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.cluster.raft.base.messages.ApplyState; import org.opendaylight.controller.cluster.raft.base.messages.SnapshotComplete; import org.opendaylight.controller.cluster.raft.base.messages.TimeoutNow; @@ -247,7 +248,7 @@ class RaftActorServerConfigurationSupport { } protected void operationComplete(final ServerOperationContext operationContext, - @Nullable final ServerChangeStatus replyStatus) { + final @Nullable ServerChangeStatus replyStatus) { if (replyStatus != null) { sendReply(operationContext, replyStatus); } @@ -453,7 +454,7 @@ class RaftActorServerConfigurationSupport { InstallingSnapshot(final AddServerContext addServerContext, final Cancellable installSnapshotTimer) { super(addServerContext); - this.installSnapshotTimer = Preconditions.checkNotNull(installSnapshotTimer); + this.installSnapshotTimer = requireNonNull(installSnapshotTimer); } @Override @@ -497,7 +498,7 @@ class RaftActorServerConfigurationSupport { WaitingForPriorSnapshotComplete(final AddServerContext addServerContext, final Cancellable snapshotTimer) { super(addServerContext); - this.snapshotTimer = Preconditions.checkNotNull(snapshotTimer); + this.snapshotTimer = requireNonNull(snapshotTimer); } @Override @@ -609,7 +610,7 @@ class RaftActorServerConfigurationSupport { private final RemoveServerContext removeServerContext; protected RemoveServerState(final RemoveServerContext removeServerContext) { - this.removeServerContext = Preconditions.checkNotNull(removeServerContext); + this.removeServerContext = requireNonNull(removeServerContext); } @@ -701,6 +702,8 @@ class RaftActorServerConfigurationSupport { if (succeeded && localServerChangedToNonVoting) { LOG.debug("Leader changed to non-voting - trying leadership transfer"); raftActor.becomeNonVoting(); + } else if (raftActor.isLeader()) { + raftActor.onVotingStateChangeComplete(); } } @@ -878,7 +881,7 @@ class RaftActorServerConfigurationSupport { private final String loggingContext; ServerOperationTimeout(final String loggingContext) { - this.loggingContext = Preconditions.checkNotNull(loggingContext, "loggingContext should not be null"); + this.loggingContext = requireNonNull(loggingContext, "loggingContext should not be null"); } String getLoggingContext() {