X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-akka-raft%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Fraft%2FRaftActorServerConfigurationSupport.java;h=3f030d0ff05bc61f5af07a1a4e9b962d81864fae;hb=2d60632f7cf63712e8357a3cf3fc40d83366e5e6;hp=0014a6fce716f988a2f96ffe22b3e0ffc5ee6d2b;hpb=1c717bbf117d3486196a0fdd73ac650721f9c557;p=controller.git
diff --git a/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/RaftActorServerConfigurationSupport.java b/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/RaftActorServerConfigurationSupport.java
index 0014a6fce7..3f030d0ff0 100644
--- a/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/RaftActorServerConfigurationSupport.java
+++ b/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/RaftActorServerConfigurationSupport.java
@@ -61,12 +61,12 @@ class RaftActorServerConfigurationSupport {
private OperationState currentOperationState = IDLE;
- RaftActorServerConfigurationSupport(RaftActor raftActor) {
+ RaftActorServerConfigurationSupport(final RaftActor raftActor) {
this.raftActor = raftActor;
this.raftContext = raftActor.getRaftActorContext();
}
- boolean handleMessage(Object message, ActorRef sender) {
+ boolean handleMessage(final Object message, final ActorRef sender) {
if (message instanceof AddServer) {
onAddServer((AddServer) message, sender);
return true;
@@ -92,11 +92,11 @@ class RaftActorServerConfigurationSupport {
}
}
- void onNewLeader(String leaderId) {
+ void onNewLeader(final String leaderId) {
currentOperationState.onNewLeader(leaderId);
}
- private void onChangeServersVotingStatus(ChangeServersVotingStatus message, ActorRef sender) {
+ private void onChangeServersVotingStatus(final ChangeServersVotingStatus message, final ActorRef sender) {
LOG.debug("{}: onChangeServersVotingStatus: {}, state: {}", raftContext.getId(), message,
currentOperationState);
@@ -122,7 +122,7 @@ class RaftActorServerConfigurationSupport {
}
}
- private void onRemoveServer(RemoveServer removeServer, ActorRef sender) {
+ private void onRemoveServer(final RemoveServer removeServer, final ActorRef sender) {
LOG.debug("{}: onRemoveServer: {}, state: {}", raftContext.getId(), removeServer, currentOperationState);
boolean isSelf = removeServer.getServerId().equals(raftContext.getId());
if (isSelf && !raftContext.hasFollowers()) {
@@ -138,7 +138,7 @@ class RaftActorServerConfigurationSupport {
}
}
- private boolean onApplyState(ApplyState applyState) {
+ private boolean onApplyState(final ApplyState applyState) {
Payload data = applyState.getReplicatedLogEntry().getData();
if (data instanceof ServerConfigurationPayload) {
currentOperationState.onApplyState(applyState);
@@ -149,7 +149,7 @@ class RaftActorServerConfigurationSupport {
}
/**
- * The algorithm for AddServer is as follows:
+ * Add a server. The algorithm for AddServer is as follows:
*
* - Add the new server as a peer.
* - Add the new follower to the leader.
@@ -169,13 +169,13 @@ class RaftActorServerConfigurationSupport {
* - Respond to caller with TIMEOUT.
*
*/
- private void onAddServer(AddServer addServer, ActorRef sender) {
+ private void onAddServer(final AddServer addServer, final ActorRef sender) {
LOG.debug("{}: onAddServer: {}, state: {}", raftContext.getId(), addServer, currentOperationState);
onNewOperation(new AddServerContext(addServer, sender));
}
- private void onNewOperation(ServerOperationContext> operationContext) {
+ private void onNewOperation(final ServerOperationContext> operationContext) {
if (raftActor.isLeader()) {
currentOperationState.onNewOperation(operationContext);
} else {
@@ -202,7 +202,7 @@ class RaftActorServerConfigurationSupport {
* Abstract base class for a server operation FSM state. Handles common behavior for all states.
*/
private abstract class OperationState {
- void onNewOperation(ServerOperationContext> operationContext) {
+ void onNewOperation(final ServerOperationContext> operationContext) {
// We're currently processing another operation so queue it to be processed later.
LOG.debug("{}: Server operation already in progress - queueing {}", raftContext.getId(),
@@ -211,15 +211,15 @@ class RaftActorServerConfigurationSupport {
pendingOperationsQueue.add(operationContext);
}
- void onServerOperationTimeout(ServerOperationTimeout timeout) {
+ void onServerOperationTimeout(final ServerOperationTimeout timeout) {
LOG.debug("onServerOperationTimeout should not be called in state {}", this);
}
- void onUnInitializedFollowerSnapshotReply(UnInitializedFollowerSnapshotReply reply) {
+ void onUnInitializedFollowerSnapshotReply(final UnInitializedFollowerSnapshotReply reply) {
LOG.debug("onUnInitializedFollowerSnapshotReply was called in state {}", this);
}
- void onApplyState(ApplyState applyState) {
+ void onApplyState(final ApplyState applyState) {
LOG.debug("onApplyState was called in state {}", this);
}
@@ -227,10 +227,10 @@ class RaftActorServerConfigurationSupport {
}
- void onNewLeader(String newLeader) {
+ void onNewLeader(final String newLeader) {
}
- protected void persistNewServerConfiguration(ServerOperationContext> operationContext) {
+ protected void persistNewServerConfiguration(final ServerOperationContext> operationContext) {
raftContext.setDynamicServerConfigurationInUse();
ServerConfigurationPayload payload = raftContext.getPeerServerInfo(
@@ -246,8 +246,8 @@ class RaftActorServerConfigurationSupport {
sendReply(operationContext, ServerChangeStatus.OK);
}
- protected void operationComplete(ServerOperationContext> operationContext,
- @Nullable ServerChangeStatus replyStatus) {
+ protected void operationComplete(final ServerOperationContext> operationContext,
+ @Nullable final ServerChangeStatus replyStatus) {
if (replyStatus != null) {
sendReply(operationContext, replyStatus);
}
@@ -266,7 +266,7 @@ class RaftActorServerConfigurationSupport {
}
}
- protected void sendReply(ServerOperationContext> operationContext, ServerChangeStatus status) {
+ protected void sendReply(final ServerOperationContext> operationContext, final ServerChangeStatus status) {
LOG.debug("{}: Returning {} for operation {}", raftContext.getId(), status,
operationContext.getOperation());
@@ -274,11 +274,11 @@ class RaftActorServerConfigurationSupport {
raftActor.self());
}
- Cancellable newTimer(Object message) {
+ Cancellable newTimer(final Object message) {
return newTimer(raftContext.getConfigParams().getElectionTimeOutInterval().$times(2), message);
}
- Cancellable newTimer(FiniteDuration timeout, Object message) {
+ Cancellable newTimer(final FiniteDuration timeout, final Object message) {
return raftContext.getActorSystem().scheduler().scheduleOnce(
timeout, raftContext.getActor(), message,
raftContext.getActorSystem().dispatcher(), raftContext.getActor());
@@ -295,12 +295,12 @@ class RaftActorServerConfigurationSupport {
*/
private final class Idle extends OperationState {
@Override
- public void onNewOperation(ServerOperationContext> operationContext) {
+ public void onNewOperation(final ServerOperationContext> operationContext) {
operationContext.newInitialOperationState(RaftActorServerConfigurationSupport.this).initiate();
}
@Override
- public void onApplyState(ApplyState applyState) {
+ public void onApplyState(final ApplyState applyState) {
// Noop - we override b/c ApplyState is called normally for followers in the idle state.
}
}
@@ -313,13 +313,13 @@ class RaftActorServerConfigurationSupport {
private final Cancellable timer;
private boolean timedOut = false;
- Persisting(ServerOperationContext> operationContext, Cancellable timer) {
+ Persisting(final ServerOperationContext> operationContext, final Cancellable timer) {
this.operationContext = operationContext;
this.timer = timer;
}
@Override
- public void onApplyState(ApplyState applyState) {
+ public void onApplyState(final ApplyState applyState) {
// Sanity check - we could get an ApplyState from a previous operation that timed out so make
// sure it's meant for us.
if (operationContext.getContextId().equals(applyState.getIdentifier())) {
@@ -332,7 +332,7 @@ class RaftActorServerConfigurationSupport {
}
@Override
- public void onServerOperationTimeout(ServerOperationTimeout timeout) {
+ public void onServerOperationTimeout(final ServerOperationTimeout timeout) {
LOG.warn("{}: Timeout occured while replicating the new server configuration for {}", raftContext.getId(),
timeout.getLoggingContext());
@@ -347,7 +347,7 @@ class RaftActorServerConfigurationSupport {
}
@Override
- public void onNewOperation(ServerOperationContext> newOperationContext) {
+ public void onNewOperation(final ServerOperationContext> newOperationContext) {
if (timedOut) {
sendReply(newOperationContext, ServerChangeStatus.PRIOR_REQUEST_CONSENSUS_TIMEOUT);
} else {
@@ -362,7 +362,7 @@ class RaftActorServerConfigurationSupport {
private abstract class AddServerState extends OperationState {
private final AddServerContext addServerContext;
- AddServerState(AddServerContext addServerContext) {
+ AddServerState(final AddServerContext addServerContext) {
this.addServerContext = addServerContext;
}
@@ -374,7 +374,7 @@ class RaftActorServerConfigurationSupport {
return newTimer(new ServerOperationTimeout(addServerContext.getOperation().getNewServerId()));
}
- void handleInstallSnapshotTimeout(ServerOperationTimeout timeout) {
+ void handleInstallSnapshotTimeout(final ServerOperationTimeout timeout) {
String serverId = timeout.getLoggingContext();
LOG.debug("{}: handleInstallSnapshotTimeout for new server {}", raftContext.getId(), serverId);
@@ -399,7 +399,7 @@ class RaftActorServerConfigurationSupport {
* snapshot capture, if necessary.
*/
private final class InitialAddServerState extends AddServerState implements InitialOperationState {
- InitialAddServerState(AddServerContext addServerContext) {
+ InitialAddServerState(final AddServerContext addServerContext) {
super(addServerContext);
}
@@ -451,13 +451,13 @@ class RaftActorServerConfigurationSupport {
private final class InstallingSnapshot extends AddServerState {
private final Cancellable installSnapshotTimer;
- InstallingSnapshot(AddServerContext addServerContext, Cancellable installSnapshotTimer) {
+ InstallingSnapshot(final AddServerContext addServerContext, final Cancellable installSnapshotTimer) {
super(addServerContext);
this.installSnapshotTimer = Preconditions.checkNotNull(installSnapshotTimer);
}
@Override
- public void onServerOperationTimeout(ServerOperationTimeout timeout) {
+ public void onServerOperationTimeout(final ServerOperationTimeout timeout) {
handleInstallSnapshotTimeout(timeout);
LOG.warn("{}: Timeout occured for new server {} while installing snapshot", raftContext.getId(),
@@ -465,7 +465,7 @@ class RaftActorServerConfigurationSupport {
}
@Override
- public void onUnInitializedFollowerSnapshotReply(UnInitializedFollowerSnapshotReply reply) {
+ public void onUnInitializedFollowerSnapshotReply(final UnInitializedFollowerSnapshotReply reply) {
LOG.debug("{}: onUnInitializedFollowerSnapshotReply: {}", raftContext.getId(), reply);
String followerId = reply.getFollowerId();
@@ -495,7 +495,7 @@ class RaftActorServerConfigurationSupport {
private final class WaitingForPriorSnapshotComplete extends AddServerState {
private final Cancellable snapshotTimer;
- WaitingForPriorSnapshotComplete(AddServerContext addServerContext, Cancellable snapshotTimer) {
+ WaitingForPriorSnapshotComplete(final AddServerContext addServerContext, final Cancellable snapshotTimer) {
super(addServerContext);
this.snapshotTimer = Preconditions.checkNotNull(snapshotTimer);
}
@@ -522,7 +522,7 @@ class RaftActorServerConfigurationSupport {
}
@Override
- public void onServerOperationTimeout(ServerOperationTimeout timeout) {
+ public void onServerOperationTimeout(final ServerOperationTimeout timeout) {
handleInstallSnapshotTimeout(timeout);
LOG.warn("{}: Timeout occured for new server {} while waiting for prior snapshot to complete",
@@ -549,7 +549,7 @@ class RaftActorServerConfigurationSupport {
private final ActorRef clientRequestor;
private final Identifier contextId;
- ServerOperationContext(T operation, ActorRef clientRequestor) {
+ ServerOperationContext(final T operation, final ActorRef clientRequestor) {
this.operation = operation;
this.clientRequestor = clientRequestor;
contextId = new ServerOperationContextIdentifier();
@@ -567,10 +567,10 @@ class RaftActorServerConfigurationSupport {
return clientRequestor;
}
- void operationComplete(RaftActor raftActor, boolean succeeded) {
+ void operationComplete(final RaftActor raftActor, final boolean succeeded) {
}
- boolean includeSelfInNewConfiguration(RaftActor raftActor) {
+ boolean includeSelfInNewConfiguration(final RaftActor raftActor) {
return true;
}
@@ -585,17 +585,17 @@ class RaftActorServerConfigurationSupport {
* Stores context information for an AddServer operation.
*/
private static class AddServerContext extends ServerOperationContext {
- AddServerContext(AddServer addServer, ActorRef clientRequestor) {
+ AddServerContext(final AddServer addServer, final ActorRef clientRequestor) {
super(addServer, clientRequestor);
}
@Override
- Object newReply(ServerChangeStatus status, String leaderId) {
+ Object newReply(final ServerChangeStatus status, final String leaderId) {
return new AddServerReply(status, leaderId);
}
@Override
- InitialOperationState newInitialOperationState(RaftActorServerConfigurationSupport support) {
+ InitialOperationState newInitialOperationState(final RaftActorServerConfigurationSupport support) {
return support.new InitialAddServerState(this);
}
@@ -608,7 +608,7 @@ class RaftActorServerConfigurationSupport {
private abstract class RemoveServerState extends OperationState {
private final RemoveServerContext removeServerContext;
- protected RemoveServerState(RemoveServerContext removeServerContext) {
+ protected RemoveServerState(final RemoveServerContext removeServerContext) {
this.removeServerContext = Preconditions.checkNotNull(removeServerContext);
}
@@ -620,7 +620,7 @@ class RaftActorServerConfigurationSupport {
private final class InitialRemoveServerState extends RemoveServerState implements InitialOperationState {
- protected InitialRemoveServerState(RemoveServerContext removeServerContext) {
+ protected InitialRemoveServerState(final RemoveServerContext removeServerContext) {
super(removeServerContext);
}
@@ -639,23 +639,23 @@ class RaftActorServerConfigurationSupport {
private static class RemoveServerContext extends ServerOperationContext {
private final String peerAddress;
- RemoveServerContext(RemoveServer operation, String peerAddress, ActorRef clientRequestor) {
+ RemoveServerContext(final RemoveServer operation, final String peerAddress, final ActorRef clientRequestor) {
super(operation, clientRequestor);
this.peerAddress = peerAddress;
}
@Override
- Object newReply(ServerChangeStatus status, String leaderId) {
+ Object newReply(final ServerChangeStatus status, final String leaderId) {
return new RemoveServerReply(status, leaderId);
}
@Override
- InitialOperationState newInitialOperationState(RaftActorServerConfigurationSupport support) {
+ InitialOperationState newInitialOperationState(final RaftActorServerConfigurationSupport support) {
return support.new InitialRemoveServerState(this);
}
@Override
- void operationComplete(RaftActor raftActor, boolean succeeded) {
+ void operationComplete(final RaftActor raftActor, final boolean succeeded) {
if (peerAddress != null) {
raftActor.context().actorSelection(peerAddress).tell(
new ServerRemoved(getOperation().getServerId()), raftActor.getSelf());
@@ -663,7 +663,7 @@ class RaftActorServerConfigurationSupport {
}
@Override
- boolean includeSelfInNewConfiguration(RaftActor raftActor) {
+ boolean includeSelfInNewConfiguration(final RaftActor raftActor) {
return !getOperation().getServerId().equals(raftActor.getId());
}
@@ -676,24 +676,24 @@ class RaftActorServerConfigurationSupport {
private static class ChangeServersVotingStatusContext extends ServerOperationContext {
private final boolean tryToElectLeader;
- ChangeServersVotingStatusContext(ChangeServersVotingStatus convertMessage, ActorRef clientRequestor,
- boolean tryToElectLeader) {
+ ChangeServersVotingStatusContext(final ChangeServersVotingStatus convertMessage, final ActorRef clientRequestor,
+ final boolean tryToElectLeader) {
super(convertMessage, clientRequestor);
this.tryToElectLeader = tryToElectLeader;
}
@Override
- InitialOperationState newInitialOperationState(RaftActorServerConfigurationSupport support) {
+ InitialOperationState newInitialOperationState(final RaftActorServerConfigurationSupport support) {
return support.new ChangeServersVotingStatusState(this, tryToElectLeader);
}
@Override
- Object newReply(ServerChangeStatus status, String leaderId) {
+ Object newReply(final ServerChangeStatus status, final String leaderId) {
return new ServerChangeReply(status, leaderId);
}
@Override
- void operationComplete(final RaftActor raftActor, boolean succeeded) {
+ void operationComplete(final RaftActor raftActor, final boolean succeeded) {
// If this leader changed to non-voting we need to step down as leader so we'll try to transfer
// leadership.
boolean localServerChangedToNonVoting = Boolean.FALSE.equals(getOperation()
@@ -714,8 +714,8 @@ class RaftActorServerConfigurationSupport {
private final ChangeServersVotingStatusContext changeVotingStatusContext;
private final boolean tryToElectLeader;
- ChangeServersVotingStatusState(ChangeServersVotingStatusContext changeVotingStatusContext,
- boolean tryToElectLeader) {
+ ChangeServersVotingStatusState(final ChangeServersVotingStatusContext changeVotingStatusContext,
+ final boolean tryToElectLeader) {
this.changeVotingStatusContext = changeVotingStatusContext;
this.tryToElectLeader = tryToElectLeader;
}
@@ -792,8 +792,8 @@ class RaftActorServerConfigurationSupport {
private final ChangeServersVotingStatusContext operationContext;
private final Cancellable timer;
- WaitingForLeaderElected(ChangeServersVotingStatusContext operationContext,
- ServerConfigurationPayload previousServerConfig) {
+ WaitingForLeaderElected(final ChangeServersVotingStatusContext operationContext,
+ final ServerConfigurationPayload previousServerConfig) {
this.operationContext = operationContext;
this.previousServerConfig = previousServerConfig;
@@ -802,7 +802,7 @@ class RaftActorServerConfigurationSupport {
}
@Override
- void onNewLeader(String newLeader) {
+ void onNewLeader(final String newLeader) {
if (newLeader == null) {
return;
}
@@ -826,7 +826,7 @@ class RaftActorServerConfigurationSupport {
}
@Override
- void onServerOperationTimeout(ServerOperationTimeout timeout) {
+ void onServerOperationTimeout(final ServerOperationTimeout timeout) {
LOG.warn("{}: Leader election timed out - cannot apply operation {}",
raftContext.getId(), timeout.getLoggingContext());
@@ -877,7 +877,7 @@ class RaftActorServerConfigurationSupport {
static class ServerOperationTimeout {
private final String loggingContext;
- ServerOperationTimeout(String loggingContext) {
+ ServerOperationTimeout(final String loggingContext) {
this.loggingContext = Preconditions.checkNotNull(loggingContext, "loggingContext should not be null");
}