X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-akka-raft%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Fraft%2FReplicatedLogImpl.java;h=c22f6f431bd4cf833ab6eb7c275563e9d357d386;hb=refs%2Fchanges%2F40%2F81640%2F6;hp=764bce1ddb97aa4af14620736a5e286d64d1a87a;hpb=2d60632f7cf63712e8357a3cf3fc40d83366e5e6;p=controller.git diff --git a/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/ReplicatedLogImpl.java b/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/ReplicatedLogImpl.java index 764bce1ddb..c22f6f431b 100644 --- a/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/ReplicatedLogImpl.java +++ b/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/ReplicatedLogImpl.java @@ -7,12 +7,11 @@ */ package org.opendaylight.controller.cluster.raft; -import akka.japi.Procedure; -import com.google.common.base.Preconditions; +import static java.util.Objects.requireNonNull; + import java.util.Collections; import java.util.List; -import javax.annotation.Nonnull; -import javax.annotation.Nullable; +import java.util.function.Consumer; import org.opendaylight.controller.cluster.raft.persisted.DeleteEntries; import org.opendaylight.controller.cluster.raft.persisted.Snapshot; @@ -29,7 +28,7 @@ final class ReplicatedLogImpl extends AbstractReplicatedLogImpl { final List unAppliedEntries, final RaftActorContext context) { super(snapshotIndex, snapshotTerm, unAppliedEntries, context.getId()); - this.context = Preconditions.checkNotNull(context); + this.context = requireNonNull(context); } static ReplicatedLog newInstance(final Snapshot snapshot, final RaftActorContext context) { @@ -93,8 +92,8 @@ final class ReplicatedLogImpl extends AbstractReplicatedLogImpl { } @Override - public boolean appendAndPersist(@Nonnull final ReplicatedLogEntry replicatedLogEntry, - @Nullable final Procedure callback, final boolean doAsync) { + public boolean appendAndPersist(final ReplicatedLogEntry replicatedLogEntry, + final Consumer callback, final boolean doAsync) { context.getLogger().debug("{}: Append log entry and persist {} ", context.getId(), replicatedLogEntry); @@ -102,22 +101,29 @@ final class ReplicatedLogImpl extends AbstractReplicatedLogImpl { return false; } - Procedure persistCallback = persistedLogEntry -> { - context.getLogger().debug("{}: persist complete {}", context.getId(), persistedLogEntry); - - dataSizeSinceLastSnapshot += persistedLogEntry.size(); - - if (callback != null) { - callback.apply(persistedLogEntry); - } - }; - if (doAsync) { - context.getPersistenceProvider().persistAsync(replicatedLogEntry, persistCallback); + context.getPersistenceProvider().persistAsync(replicatedLogEntry, + entry -> persistCallback(entry, callback)); } else { - context.getPersistenceProvider().persist(replicatedLogEntry, persistCallback); + context.getPersistenceProvider().persist(replicatedLogEntry, entry -> syncPersistCallback(entry, callback)); } return true; } + + private void persistCallback(final ReplicatedLogEntry persistedLogEntry, + final Consumer callback) { + context.getExecutor().execute(() -> syncPersistCallback(persistedLogEntry, callback)); + } + + private void syncPersistCallback(final ReplicatedLogEntry persistedLogEntry, + final Consumer callback) { + context.getLogger().debug("{}: persist complete {}", context.getId(), persistedLogEntry); + + dataSizeSinceLastSnapshot += persistedLogEntry.size(); + + if (callback != null) { + callback.accept(persistedLogEntry); + } + } }