X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-akka-raft%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Fraft%2Fbehaviors%2FLeader.java;h=eb49abc17aea4a0ebefacde0a5925312082e1405;hb=bfe4439155b27fbf9ae300252420c8a81fcbdb80;hp=827364c29faeefd03149b5b65777195ca3afa5d6;hpb=a0b8be5ce48c0d1e0b573d1952211913c58d4935;p=controller.git
diff --git a/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/behaviors/Leader.java b/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/behaviors/Leader.java
index 827364c29f..eb49abc17a 100644
--- a/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/behaviors/Leader.java
+++ b/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/behaviors/Leader.java
@@ -10,6 +10,7 @@ package org.opendaylight.controller.cluster.raft.behaviors;
import akka.actor.ActorRef;
import akka.actor.ActorSelection;
import com.google.common.annotations.VisibleForTesting;
+import com.google.common.base.Optional;
import com.google.common.base.Preconditions;
import com.google.common.base.Stopwatch;
import java.util.concurrent.TimeUnit;
@@ -23,8 +24,9 @@ import org.opendaylight.controller.cluster.raft.base.messages.TimeoutNow;
import org.opendaylight.controller.cluster.raft.messages.AppendEntriesReply;
/**
- * The behavior of a RaftActor when it is in the Leader state
- *
+ * The behavior of a RaftActor when it is in the Leader state.
+ *
+ *
* Leaders:
*
* - Upon election: send initial empty AppendEntries RPCs
@@ -34,15 +36,14 @@ import org.opendaylight.controller.cluster.raft.messages.AppendEntriesReply;
* respond after entry applied to state machine (§5.3)
*
- If last log index ⥠nextIndex for a follower: send
* AppendEntries RPC with log entries starting at nextIndex
- *
* - If successful: update nextIndex and matchIndex for
* follower (§5.3)
*
- If AppendEntries fails because of log inconsistency:
* decrement nextIndex and retry (§5.3)
- *
- * - If there exists an N such that N > commitIndex, a majority
+ *
- If there exists an N such that N > commitIndex, a majority
* of matchIndex[i] ⥠N, and log[N].term == currentTerm:
* set commitIndex = N (§5.3, §5.4).
+ *
*/
public class Leader extends AbstractLeader {
/**
@@ -53,7 +54,7 @@ public class Leader extends AbstractLeader {
static final Object ISOLATED_LEADER_CHECK = new Object();
private final Stopwatch isolatedLeaderCheck = Stopwatch.createStarted();
- private @Nullable LeadershipTransferContext leadershipTransferContext;
+ @Nullable private LeadershipTransferContext leadershipTransferContext;
Leader(RaftActorContext context, @Nullable AbstractLeader initializeFromLeader) {
super(context, RaftState.Leader, initializeFromLeader);
@@ -69,7 +70,7 @@ public class Leader extends AbstractLeader {
if (ISOLATED_LEADER_CHECK.equals(originalMessage)) {
if (isLeaderIsolated()) {
- LOG.warn("{}: At least {} followers need to be active, Switching {} from Leader to IsolatedLeader",
+ log.warn("{}: At least {} followers need to be active, Switching {} from Leader to IsolatedLeader",
context.getId(), getMinIsolatedLeaderPeerCount(), getLeaderId());
return internalSwitchBehavior(new IsolatedLeader(context, this));
} else {
@@ -81,15 +82,16 @@ public class Leader extends AbstractLeader {
}
@Override
- protected void beforeSendHeartbeat(){
- if(isolatedLeaderCheck.elapsed(TimeUnit.MILLISECONDS) > context.getConfigParams().getIsolatedCheckIntervalInMillis()){
+ protected void beforeSendHeartbeat() {
+ if (isolatedLeaderCheck.elapsed(TimeUnit.MILLISECONDS)
+ > context.getConfigParams().getIsolatedCheckIntervalInMillis()) {
context.getActor().tell(ISOLATED_LEADER_CHECK, context.getActor());
isolatedLeaderCheck.reset().start();
}
- if(leadershipTransferContext != null && leadershipTransferContext.isExpired(
+ if (leadershipTransferContext != null && leadershipTransferContext.isExpired(
context.getConfigParams().getElectionTimeOutInterval().toMillis())) {
- LOG.debug("{}: Leadership transfer expired", logName());
+ log.debug("{}: Leadership transfer expired", logName());
leadershipTransferContext = null;
}
}
@@ -107,20 +109,20 @@ public class Leader extends AbstractLeader {
* Start a timer (Stopwatch).
* Send an initial AppendEntries heartbeat to all followers.
* On AppendEntriesReply, check if the follower's new match Index matches the leader's last index
- * If it matches,
+ * If it matches,
*
* - Send an additional AppendEntries to ensure the follower has applied all its log entries to its state.
* - Send an ElectionTimeout to the follower to immediately start an election.
* - Notify {@link RaftActorLeadershipTransferCohort#transferComplete}.
- *
+ *
* Otherwise if the election time out period elapses, notify
- * {@link RaftActorLeadershipTransferCohort#abortTtransfer}.
+ * {@link RaftActorLeadershipTransferCohort#abortTransfer}.
*
*
- * @param leadershipTransferCohort
+ * @param leadershipTransferCohort the cohort participating in the leadership transfer
*/
public void transferLeadership(@Nonnull RaftActorLeadershipTransferCohort leadershipTransferCohort) {
- LOG.debug("{}: Attempting to transfer leadership", logName());
+ log.debug("{}: Attempting to transfer leadership", logName());
leadershipTransferContext = new LeadershipTransferContext(leadershipTransferCohort);
@@ -129,23 +131,30 @@ public class Leader extends AbstractLeader {
}
private void tryToCompleteLeadershipTransfer(String followerId) {
- if(leadershipTransferContext == null) {
+ if (leadershipTransferContext == null) {
+ return;
+ }
+
+ final Optional requestedFollowerIdOptional
+ = leadershipTransferContext.transferCohort.getRequestedFollowerId();
+ if (requestedFollowerIdOptional.isPresent() && !requestedFollowerIdOptional.get().equals(followerId)) {
+ // we want to transfer leadership to specific follower
return;
}
FollowerLogInformation followerInfo = getFollower(followerId);
- if(followerInfo == null) {
+ if (followerInfo == null) {
return;
}
long lastIndex = context.getReplicatedLog().lastIndex();
boolean isVoting = context.getPeerInfo(followerId).isVoting();
- LOG.debug("{}: tryToCompleteLeadershipTransfer: followerId: {}, matchIndex: {}, lastIndex: {}, isVoting: {}",
+ log.debug("{}: tryToCompleteLeadershipTransfer: followerId: {}, matchIndex: {}, lastIndex: {}, isVoting: {}",
logName(), followerId, followerInfo.getMatchIndex(), lastIndex, isVoting);
- if(isVoting && followerInfo.getMatchIndex() == lastIndex) {
- LOG.debug("{}: Follower's log matches - sending ElectionTimeout", logName());
+ if (isVoting && followerInfo.getMatchIndex() == lastIndex) {
+ log.debug("{}: Follower's log matches - sending ElectionTimeout", logName());
// We can't be sure if the follower has applied all its log entries to its state so send an
// additional AppendEntries with the latest commit index.
@@ -155,7 +164,7 @@ public class Leader extends AbstractLeader {
ActorSelection followerActor = context.getPeerActorSelection(followerId);
followerActor.tell(TimeoutNow.INSTANCE, context.getActor());
- LOG.debug("{}: Leader transfer complete", logName());
+ log.debug("{}: Leader transfer complete", logName());
leadershipTransferContext.transferCohort.transferComplete();
leadershipTransferContext = null;
@@ -164,7 +173,7 @@ public class Leader extends AbstractLeader {
@Override
public void close() {
- if(leadershipTransferContext != null) {
+ if (leadershipTransferContext != null) {
LeadershipTransferContext localLeadershipTransferContext = leadershipTransferContext;
leadershipTransferContext = null;
localLeadershipTransferContext.transferCohort.abortTransfer();
@@ -192,7 +201,7 @@ public class Leader extends AbstractLeader {
}
boolean isExpired(long timeout) {
- if(timer.elapsed(TimeUnit.MILLISECONDS) >= timeout) {
+ if (timer.elapsed(TimeUnit.MILLISECONDS) >= timeout) {
transferCohort.abortTransfer();
return true;
}