X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-akka-raft%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Fraft%2Fbehaviors%2FSnapshotTracker.java;h=bb7a24248188f0a83b9225a32a9b2a7e3e16f250;hb=5e590ea1548dd4974ca59f1318a11f2a8651c3b7;hp=d26837f1808306edbabb159ca7f0c13084836f2d;hpb=bfd413d87f82ee3ffed67a141a980805950a0f06;p=controller.git diff --git a/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/behaviors/SnapshotTracker.java b/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/behaviors/SnapshotTracker.java index d26837f180..bb7a242481 100644 --- a/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/behaviors/SnapshotTracker.java +++ b/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/behaviors/SnapshotTracker.java @@ -10,6 +10,7 @@ package org.opendaylight.controller.cluster.raft.behaviors; import com.google.common.base.Optional; import com.google.protobuf.ByteString; +import java.util.Arrays; import org.slf4j.Logger; /** @@ -36,7 +37,10 @@ public class SnapshotTracker { * @return true when the lastChunk is received * @throws InvalidChunkException */ - boolean addChunk(int chunkIndex, ByteString chunk, Optional lastChunkHashCode) throws InvalidChunkException{ + boolean addChunk(int chunkIndex, byte[] chunk, Optional lastChunkHashCode) throws InvalidChunkException{ + LOG.debug("addChunk: chunkIndex={}, lastChunkIndex={}, collectedChunks.size={}, lastChunkHashCode={}", + chunkIndex, lastChunkIndex, collectedChunks.size(), this.lastChunkHashCode); + if(sealed){ throw new InvalidChunkException("Invalid chunk received with chunkIndex " + chunkIndex + " all chunks already received"); } @@ -48,19 +52,14 @@ public class SnapshotTracker { if(lastChunkHashCode.isPresent()){ if(lastChunkHashCode.get() != this.lastChunkHashCode){ throw new InvalidChunkException("The hash code of the recorded last chunk does not match " + - "the senders hash code expected " + lastChunkHashCode + " was " + lastChunkHashCode.get()); + "the senders hash code, expected " + this.lastChunkHashCode + " was " + lastChunkHashCode.get()); } } - if(LOG.isDebugEnabled()) { - LOG.debug("Chunk={},collectedChunks.size:{}", - chunkIndex, collectedChunks.size()); - } - sealed = (chunkIndex == totalChunks); lastChunkIndex = chunkIndex; - collectedChunks = collectedChunks.concat(chunk); - this.lastChunkHashCode = chunk.hashCode(); + collectedChunks = collectedChunks.concat(ByteString.copyFrom(chunk)); + this.lastChunkHashCode = Arrays.hashCode(chunk); return sealed; }