X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-akka-raft%2Fsrc%2Ftest%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Fraft%2Fbehaviors%2FCandidateTest.java;h=b04c9e39715acbb3566e2c5f11e77a0f132cbcf4;hb=refs%2Fchanges%2F82%2F81482%2F7;hp=cb188c604b830191dace9f380f70ccd776b58e66;hpb=e1eca73a5ae2ffae8dd78c6fe5281cd2f45d5ef3;p=controller.git diff --git a/opendaylight/md-sal/sal-akka-raft/src/test/java/org/opendaylight/controller/cluster/raft/behaviors/CandidateTest.java b/opendaylight/md-sal/sal-akka-raft/src/test/java/org/opendaylight/controller/cluster/raft/behaviors/CandidateTest.java index cb188c604b..b04c9e3971 100644 --- a/opendaylight/md-sal/sal-akka-raft/src/test/java/org/opendaylight/controller/cluster/raft/behaviors/CandidateTest.java +++ b/opendaylight/md-sal/sal-akka-raft/src/test/java/org/opendaylight/controller/cluster/raft/behaviors/CandidateTest.java @@ -12,9 +12,10 @@ import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertTrue; import akka.actor.ActorRef; -import akka.actor.Props; +import akka.dispatch.Dispatchers; import akka.testkit.TestActorRef; import com.google.common.base.Stopwatch; +import com.google.common.util.concurrent.MoreExecutors; import java.util.ArrayList; import java.util.Collections; import java.util.HashMap; @@ -40,6 +41,7 @@ import org.opendaylight.controller.cluster.raft.messages.AppendEntriesReply; import org.opendaylight.controller.cluster.raft.messages.RaftRPC; import org.opendaylight.controller.cluster.raft.messages.RequestVote; import org.opendaylight.controller.cluster.raft.messages.RequestVoteReply; +import org.opendaylight.controller.cluster.raft.persisted.SimpleReplicatedLogEntry; import org.opendaylight.controller.cluster.raft.utils.MessageCollectorActor; import org.slf4j.Logger; import org.slf4j.LoggerFactory; @@ -48,9 +50,10 @@ public class CandidateTest extends AbstractRaftActorBehaviorTest { static final Logger LOG = LoggerFactory.getLogger(CandidateTest.class); private final TestActorRef candidateActor = actorFactory.createTestActor( - Props.create(MessageCollectorActor.class), actorFactory.generateActorId("candidate")); + MessageCollectorActor.props().withDispatcher(Dispatchers.DefaultDispatcherId()), + actorFactory.generateActorId("candidate")); - private TestActorRef[] peerActors; + private ActorRef[] peerActors; private RaftActorBehavior candidate; @@ -60,7 +63,7 @@ public class CandidateTest extends AbstractRaftActorBehaviorTest { @Override @After - public void tearDown() throws Exception { + public void tearDown() { if (candidate != null) { candidate.close(); } @@ -176,7 +179,7 @@ public class CandidateTest extends AbstractRaftActorBehaviorTest { Mockito.doReturn(1L).when(mockElectionTerm).getCurrentTerm(); RaftActorContext raftActorContext = new RaftActorContextImpl(candidateActor, candidateActor.actorContext(), "candidate", mockElectionTerm, -1, -1, setupPeers(4), new DefaultConfigParamsImpl(), - new NonPersistentDataProvider(), LOG); + new NonPersistentDataProvider(Runnable::run), applyState -> { }, LOG, MoreExecutors.directExecutor()); raftActorContext.setReplicatedLog(new MockRaftActorContext.MockReplicatedLogBuilder().build()); raftActorContext.getPeerInfo("peer1").setVotingState(VotingState.NON_VOTING); raftActorContext.getPeerInfo("peer4").setVotingState(VotingState.NON_VOTING); @@ -306,7 +309,7 @@ public class CandidateTest extends AbstractRaftActorBehaviorTest { @Test @Override - public void testHandleAppendEntriesAddSameEntryToLog() throws Exception { + public void testHandleAppendEntriesAddSameEntryToLog() { MockRaftActorContext context = createActorContext(); context.getTermInformation().update(2, "test"); @@ -316,7 +319,7 @@ public class CandidateTest extends AbstractRaftActorBehaviorTest { setLastLogEntry(context, 2, 0, payload); List entries = new ArrayList<>(); - entries.add(new MockRaftActorContext.MockReplicatedLogEntry(2, 0, payload)); + entries.add(new SimpleReplicatedLogEntry(0, 2, payload)); final AppendEntries appendEntries = new AppendEntries(2, "leader-1", -1, -1, entries, 2, -1, (short)0); @@ -346,16 +349,16 @@ public class CandidateTest extends AbstractRaftActorBehaviorTest { return new Candidate(actorContext); } - @Override protected MockRaftActorContext createActorContext() { + @Override + protected MockRaftActorContext createActorContext() { return new MockRaftActorContext("candidate", getSystem(), candidateActor); } - @SuppressWarnings("unchecked") private Map setupPeers(final int count) { Map peerMap = new HashMap<>(); - peerActors = new TestActorRef[count]; + peerActors = new ActorRef[count]; for (int i = 0; i < count; i++) { - peerActors[i] = actorFactory.createTestActor(Props.create(MessageCollectorActor.class), + peerActors[i] = actorFactory.createActor(MessageCollectorActor.props(), actorFactory.generateActorId("peer")); peerMap.put("peer" + (i + 1), peerActors[i].path().toString()); } @@ -365,7 +368,7 @@ public class CandidateTest extends AbstractRaftActorBehaviorTest { @Override protected void assertStateChangesToFollowerWhenRaftRPCHasNewerTerm(final MockRaftActorContext actorContext, - final ActorRef actorRef, final RaftRPC rpc) throws Exception { + final ActorRef actorRef, final RaftRPC rpc) { super.assertStateChangesToFollowerWhenRaftRPCHasNewerTerm(actorContext, actorRef, rpc); if (rpc instanceof RequestVote) { assertEquals("New votedFor", ((RequestVote)rpc).getCandidateId(),