X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-binding-broker%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fmd%2Fsal%2Fbinding%2Fimpl%2FBindingDOMNotificationServiceAdapter.java;h=64ccef369465daec611a8b30b836523ff06e584a;hb=3fe96f65938e25effd0ee164a86cb3fb6af2fca5;hp=6006266cc2d07a2745dca15b6b596415f1a14c9c;hpb=a7e57cf252c2a19a1acfbc23402eed634ae2ac5a;p=controller.git diff --git a/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/md/sal/binding/impl/BindingDOMNotificationServiceAdapter.java b/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/md/sal/binding/impl/BindingDOMNotificationServiceAdapter.java index 6006266cc2..64ccef3694 100644 --- a/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/md/sal/binding/impl/BindingDOMNotificationServiceAdapter.java +++ b/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/md/sal/binding/impl/BindingDOMNotificationServiceAdapter.java @@ -9,74 +9,47 @@ package org.opendaylight.controller.md.sal.binding.impl; import com.google.common.collect.ClassToInstanceMap; import com.google.common.collect.ImmutableSet; -import java.util.ArrayList; -import java.util.Collection; -import java.util.List; import java.util.Set; import org.opendaylight.controller.md.sal.binding.api.NotificationService; import org.opendaylight.controller.md.sal.binding.impl.BindingDOMAdapterBuilder.Factory; -import org.opendaylight.controller.md.sal.dom.api.DOMNotificationListener; import org.opendaylight.controller.md.sal.dom.api.DOMNotificationService; import org.opendaylight.controller.md.sal.dom.api.DOMService; -import org.opendaylight.controller.sal.binding.codegen.impl.SingletonHolder; -import org.opendaylight.controller.sal.binding.spi.NotificationInvokerFactory; -import org.opendaylight.yangtools.binding.data.codec.api.BindingNormalizedNodeSerializer; +import org.opendaylight.mdsal.binding.dom.codec.api.BindingNormalizedNodeSerializer; import org.opendaylight.yangtools.concepts.AbstractListenerRegistration; import org.opendaylight.yangtools.concepts.ListenerRegistration; -import org.opendaylight.yangtools.yang.binding.Notification; import org.opendaylight.yangtools.yang.binding.NotificationListener; -import org.opendaylight.yangtools.yang.binding.util.BindingReflections; -import org.opendaylight.yangtools.yang.model.api.SchemaPath; public class BindingDOMNotificationServiceAdapter implements NotificationService, AutoCloseable { - public static final Factory BUILDER_FACTORY = new Factory() { - - @Override - public BindingDOMAdapterBuilder newBuilder() { - return new Builder(); - } - - }; + public static final Factory BUILDER_FACTORY = Builder::new; private final BindingNormalizedNodeSerializer codec; private final DOMNotificationService domNotifService; - private final NotificationInvokerFactory notificationInvokerFactory; - public BindingDOMNotificationServiceAdapter(final BindingNormalizedNodeSerializer codec, final DOMNotificationService domNotifService, final NotificationInvokerFactory notificationInvokerFactory) { + public BindingDOMNotificationServiceAdapter(final BindingNormalizedNodeSerializer codec, + final DOMNotificationService domNotifService) { this.codec = codec; this.domNotifService = domNotifService; - this.notificationInvokerFactory = notificationInvokerFactory; } @Override public ListenerRegistration registerNotificationListener(final T listener) { - final NotificationInvokerFactory.NotificationInvoker invoker = notificationInvokerFactory.invokerFor(listener); - final DOMNotificationListener domListener = new BindingDOMNotificationListenerAdapter(codec, invoker); - final Collection schemaPaths = convertNotifTypesToSchemaPath(invoker.getSupportedNotifications()); - final ListenerRegistration domRegistration = - domNotifService.registerNotificationListener(domListener, schemaPaths); + final BindingDOMNotificationListenerAdapter domListener = + new BindingDOMNotificationListenerAdapter(codec, listener); + final ListenerRegistration domRegistration = + domNotifService.registerNotificationListener(domListener, domListener.getSupportedNotifications()); return new ListenerRegistrationImpl<>(listener, domRegistration); } - - - private Collection convertNotifTypesToSchemaPath(final Set> notificationTypes) { - final List schemaPaths = new ArrayList<>(); - for (final Class notificationType : notificationTypes) { - schemaPaths.add(SchemaPath.create(true, BindingReflections.findQName(notificationType))); - } - return schemaPaths; - } - @Override public void close() throws Exception { } - private static class ListenerRegistrationImpl extends AbstractListenerRegistration { + private static class ListenerRegistrationImpl + extends AbstractListenerRegistration { private final ListenerRegistration listenerRegistration; - public ListenerRegistrationImpl(final T listener, final ListenerRegistration listenerRegistration) { + ListenerRegistrationImpl(final T listener, final ListenerRegistration listenerRegistration) { super(listener); this.listenerRegistration = listenerRegistration; } @@ -89,21 +62,20 @@ public class BindingDOMNotificationServiceAdapter implements NotificationService private static class Builder extends BindingDOMAdapterBuilder { - @Override protected NotificationService createInstance(final BindingToNormalizedNodeCodec codec, final ClassToInstanceMap delegates) { final DOMNotificationService domNotification = delegates.getInstance(DOMNotificationService.class); - final NotificationInvokerFactory invokerFactory = SingletonHolder.INVOKER_FACTORY; - return new BindingDOMNotificationServiceAdapter(codec.getCodecRegistry(), domNotification, invokerFactory); + return new BindingDOMNotificationServiceAdapter(codec.getCodecRegistry(), domNotification); } @Override public Set> getRequiredDelegates() { return ImmutableSet.of(DOMNotificationService.class); } + } - - + public DOMNotificationService getDomService() { + return domNotifService; } }