X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-binding-broker%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fmd%2Fsal%2Fbinding%2Fimpl%2FRpcServiceAdapter.java;h=984302f1ea1e703e6cf5f93f5091bcdc7fe1b5cf;hb=220fbf7b619893a063b4e97411f840723e54ddaf;hp=d61c9a4b6e2f5af78e35128f7b278134dd6ad074;hpb=88936a5b76150f059aa04f5990c9acd06aa9dbf2;p=controller.git diff --git a/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/md/sal/binding/impl/RpcServiceAdapter.java b/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/md/sal/binding/impl/RpcServiceAdapter.java index d61c9a4b6e..984302f1ea 100644 --- a/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/md/sal/binding/impl/RpcServiceAdapter.java +++ b/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/md/sal/binding/impl/RpcServiceAdapter.java @@ -18,17 +18,19 @@ import java.lang.reflect.Method; import java.lang.reflect.Proxy; import java.util.Collection; import java.util.Map.Entry; +import java.util.concurrent.Future; import org.opendaylight.controller.md.sal.dom.api.DOMRpcException; import org.opendaylight.controller.md.sal.dom.api.DOMRpcResult; import org.opendaylight.controller.md.sal.dom.api.DOMRpcService; import org.opendaylight.controller.md.sal.dom.broker.spi.rpc.RpcRoutingStrategy; +import org.opendaylight.controller.sal.core.compat.LegacyDOMRpcResultFutureAdapter; import org.opendaylight.mdsal.binding.dom.adapter.BindingRpcFutureAware; import org.opendaylight.mdsal.binding.dom.codec.api.BindingNormalizedNodeSerializer; +import org.opendaylight.mdsal.binding.spec.reflect.BindingReflections; import org.opendaylight.yangtools.yang.binding.DataContainer; import org.opendaylight.yangtools.yang.binding.DataObject; import org.opendaylight.yangtools.yang.binding.InstanceIdentifier; import org.opendaylight.yangtools.yang.binding.RpcService; -import org.opendaylight.yangtools.yang.binding.util.BindingReflections; import org.opendaylight.yangtools.yang.common.QName; import org.opendaylight.yangtools.yang.common.RpcError; import org.opendaylight.yangtools.yang.common.RpcError.ErrorSeverity; @@ -68,6 +70,12 @@ class RpcServiceAdapter implements InvocationHandler { final CheckedFuture result = delegate.invokeRpc(schemaPath, input); if (result instanceof BindingRpcFutureAware) { return ((BindingRpcFutureAware) result).getBindingFuture(); + } else if (result instanceof LegacyDOMRpcResultFutureAdapter) { + Future delegateFuture = + ((LegacyDOMRpcResultFutureAdapter)result).delegate(); + if (delegateFuture instanceof BindingRpcFutureAware) { + return ((BindingRpcFutureAware) delegateFuture).getBindingFuture(); + } } return transformFuture(schemaPath, result, codec.getCodecFactory()); @@ -86,11 +94,11 @@ class RpcServiceAdapter implements InvocationHandler { } @Override - public Object invoke(final Object proxyObj, final Method method, final Object[] args) throws Throwable { + public Object invoke(final Object proxyObj, final Method method, final Object[] args) { final RpcInvocationStrategy rpc = rpcNames.get(method); if (rpc != null) { - if (method.getParameterTypes().length == 0) { + if (method.getParameterCount() == 0) { return rpc.invokeEmpty(); } if (args.length != 1) { @@ -108,11 +116,11 @@ class RpcServiceAdapter implements InvocationHandler { private static boolean isObjectMethod(final Method method) { switch (method.getName()) { case "toString": - return method.getReturnType().equals(String.class) && method.getParameterTypes().length == 0; + return method.getReturnType().equals(String.class) && method.getParameterCount() == 0; case "hashCode": - return method.getReturnType().equals(int.class) && method.getParameterTypes().length == 0; + return method.getReturnType().equals(int.class) && method.getParameterCount() == 0; case "equals": - return method.getReturnType().equals(boolean.class) && method.getParameterTypes().length == 1 && method + return method.getReturnType().equals(boolean.class) && method.getParameterCount() == 1 && method .getParameterTypes()[0] == Object.class; default: return false;