X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-binding-broker%2Fsrc%2Ftest%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fmd%2Fsal%2Fbinding%2Fimpl%2FBindingDOMDataTreeChangeServiceAdapterTest.java;h=3e68e48d085f7c20af3b6bef8af5ce2615d10466;hb=0b283e62a5872be1960635d5d6c4d301b1f87df2;hp=894b80e56fd237dc699492714947daf2914604e9;hpb=68f0b724084bcf42d775ad1f6e40c02dfcedf3d3;p=controller.git diff --git a/opendaylight/md-sal/sal-binding-broker/src/test/java/org/opendaylight/controller/md/sal/binding/impl/BindingDOMDataTreeChangeServiceAdapterTest.java b/opendaylight/md-sal/sal-binding-broker/src/test/java/org/opendaylight/controller/md/sal/binding/impl/BindingDOMDataTreeChangeServiceAdapterTest.java index 894b80e56f..3e68e48d08 100644 --- a/opendaylight/md-sal/sal-binding-broker/src/test/java/org/opendaylight/controller/md/sal/binding/impl/BindingDOMDataTreeChangeServiceAdapterTest.java +++ b/opendaylight/md-sal/sal-binding-broker/src/test/java/org/opendaylight/controller/md/sal/binding/impl/BindingDOMDataTreeChangeServiceAdapterTest.java @@ -8,17 +8,16 @@ package org.opendaylight.controller.md.sal.binding.impl; import static org.mockito.AdditionalMatchers.not; -import static org.mockito.Matchers.any; -import static org.mockito.Matchers.isA; +import static org.mockito.ArgumentMatchers.any; +import static org.mockito.ArgumentMatchers.isA; import static org.mockito.Mockito.doReturn; import static org.mockito.Mockito.reset; import static org.mockito.Mockito.verify; + import java.util.Collection; -import org.hamcrest.Description; import org.junit.Before; import org.junit.Test; -import org.mockito.ArgumentMatcher; -import org.mockito.Matchers; +import org.mockito.ArgumentMatchers; import org.mockito.Mock; import org.mockito.MockitoAnnotations; import org.opendaylight.controller.md.sal.binding.api.ClusteredDataTreeChangeListener; @@ -31,10 +30,10 @@ import org.opendaylight.controller.md.sal.dom.api.ClusteredDOMDataTreeChangeList import org.opendaylight.controller.md.sal.dom.api.DOMDataTreeChangeListener; import org.opendaylight.controller.md.sal.dom.api.DOMDataTreeChangeService; import org.opendaylight.controller.md.sal.dom.api.DOMDataTreeIdentifier; +import org.opendaylight.mdsal.binding.dom.codec.impl.BindingNormalizedNodeCodecRegistry; +import org.opendaylight.mdsal.binding.generator.impl.GeneratedClassLoadingStrategy; import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.md.sal.test.list.rev140701.Top; -import org.opendaylight.yangtools.binding.data.codec.impl.BindingNormalizedNodeCodecRegistry; import org.opendaylight.yangtools.concepts.ListenerRegistration; -import org.opendaylight.yangtools.sal.binding.generator.impl.GeneratedClassLoadingStrategy; import org.opendaylight.yangtools.yang.binding.InstanceIdentifier; import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier; @@ -65,59 +64,50 @@ public class BindingDOMDataTreeChangeServiceAdapterTest { @Before public void setUp() { MockitoAnnotations.initMocks(this); - doReturn(mockYangID).when(codecRegistry).toYangInstanceIdentifier(TOP_PATH); + doReturn(this.mockYangID).when(this.codecRegistry).toYangInstanceIdentifier(TOP_PATH); } @Test public void testRegisterDataTreeChangeListener() { - BindingToNormalizedNodeCodec codec = new BindingToNormalizedNodeCodec(classLoadingStrategy, codecRegistry); + final BindingToNormalizedNodeCodec codec = + new BindingToNormalizedNodeCodec(this.classLoadingStrategy, this.codecRegistry); - DataTreeChangeService service = BindingDOMDataTreeChangeServiceAdapter.create(codec, mockDOMService); + final DataTreeChangeService service = BindingDOMDataTreeChangeServiceAdapter.create(codec, this.mockDOMService); - doReturn(mockDOMReg).when(mockDOMService).registerDataTreeChangeListener(domDataTreeIdentifier(mockYangID), + doReturn(this.mockDOMReg).when(this.mockDOMService).registerDataTreeChangeListener( + domDataTreeIdentifier(this.mockYangID), any(DOMDataTreeChangeListener.class)); - DataTreeIdentifier treeId = new DataTreeIdentifier<>(LogicalDatastoreType.CONFIGURATION, TOP_PATH); - TestClusteredDataTreeChangeListener mockClusteredListener = new TestClusteredDataTreeChangeListener(); + final DataTreeIdentifier treeId = new DataTreeIdentifier<>(LogicalDatastoreType.CONFIGURATION, TOP_PATH); + final TestClusteredDataTreeChangeListener mockClusteredListener = new TestClusteredDataTreeChangeListener(); service.registerDataTreeChangeListener(treeId , mockClusteredListener); - verify(mockDOMService).registerDataTreeChangeListener(domDataTreeIdentifier(mockYangID), + verify(this.mockDOMService).registerDataTreeChangeListener(domDataTreeIdentifier(this.mockYangID), isA(ClusteredDOMDataTreeChangeListener.class)); - reset(mockDOMService); - doReturn(mockDOMReg).when(mockDOMService).registerDataTreeChangeListener(domDataTreeIdentifier(mockYangID), - any(DOMDataTreeChangeListener.class)); - TestDataTreeChangeListener mockNonClusteredListener = new TestDataTreeChangeListener(); + reset(this.mockDOMService); + doReturn(this.mockDOMReg).when(this.mockDOMService).registerDataTreeChangeListener( + domDataTreeIdentifier(this.mockYangID), any(DOMDataTreeChangeListener.class)); + final TestDataTreeChangeListener mockNonClusteredListener = new TestDataTreeChangeListener(); service.registerDataTreeChangeListener(treeId , mockNonClusteredListener); - verify(mockDOMService).registerDataTreeChangeListener(domDataTreeIdentifier(mockYangID), + verify(this.mockDOMService).registerDataTreeChangeListener(domDataTreeIdentifier(this.mockYangID), not(isA(ClusteredDOMDataTreeChangeListener.class))); } static DOMDataTreeIdentifier domDataTreeIdentifier(final YangInstanceIdentifier yangID) { - return Matchers.argThat(new ArgumentMatcher() { - @Override - public boolean matches(Object argument) { - DOMDataTreeIdentifier treeId = (DOMDataTreeIdentifier) argument; - return treeId.getDatastoreType() == LogicalDatastoreType.CONFIGURATION && - yangID.equals(treeId.getRootIdentifier()); - } - - @Override - public void describeTo(Description description) { - description.appendValue(new DOMDataTreeIdentifier(LogicalDatastoreType.CONFIGURATION, yangID)); - } - }); + return ArgumentMatchers.argThat(treeId -> treeId.getDatastoreType() == LogicalDatastoreType.CONFIGURATION + && yangID.equals(treeId.getRootIdentifier())); } private static class TestClusteredDataTreeChangeListener implements ClusteredDataTreeChangeListener { @Override - public void onDataTreeChanged(Collection> changes) { + public void onDataTreeChanged(final Collection> changes) { } } private static class TestDataTreeChangeListener implements DataTreeChangeListener { @Override - public void onDataTreeChanged(Collection> changes) { + public void onDataTreeChanged(final Collection> changes) { } } }