X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-binding-dom-it%2Fsrc%2Ftest%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fmd%2Fsal%2Fbinding%2Fdata%2FConcurrentImplicitCreateTest.java;h=e74a97fce9faa5833f12b83fea434512d996eeca;hb=refs%2Fchanges%2F22%2F58022%2F4;hp=cdf7fbc7f996498f62d736e5f9b0667b67ca29d7;hpb=dea515c8870769408b9bea29f555d6b71ff43211;p=controller.git diff --git a/opendaylight/md-sal/sal-binding-dom-it/src/test/java/org/opendaylight/controller/md/sal/binding/data/ConcurrentImplicitCreateTest.java b/opendaylight/md-sal/sal-binding-dom-it/src/test/java/org/opendaylight/controller/md/sal/binding/data/ConcurrentImplicitCreateTest.java index cdf7fbc7f9..e74a97fce9 100644 --- a/opendaylight/md-sal/sal-binding-dom-it/src/test/java/org/opendaylight/controller/md/sal/binding/data/ConcurrentImplicitCreateTest.java +++ b/opendaylight/md-sal/sal-binding-dom-it/src/test/java/org/opendaylight/controller/md/sal/binding/data/ConcurrentImplicitCreateTest.java @@ -7,20 +7,19 @@ */ package org.opendaylight.controller.md.sal.binding.data; -import static org.junit.Assert.assertEquals; -import static org.junit.Assert.assertTrue; import java.util.concurrent.ExecutionException; -import java.util.concurrent.Future; +import java.util.concurrent.TimeUnit; +import java.util.concurrent.TimeoutException; import org.junit.Test; -import org.opendaylight.controller.md.sal.common.api.TransactionStatus; -import org.opendaylight.controller.sal.binding.api.data.DataModificationTransaction; +import org.opendaylight.controller.md.sal.binding.api.DataBroker; +import org.opendaylight.controller.md.sal.binding.api.WriteTransaction; +import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; import org.opendaylight.controller.sal.binding.test.AbstractDataServiceTest; import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.md.sal.test.list.rev140701.Top; import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.md.sal.test.list.rev140701.two.level.list.TopLevelList; import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.md.sal.test.list.rev140701.two.level.list.TopLevelListBuilder; import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.md.sal.test.list.rev140701.two.level.list.TopLevelListKey; import org.opendaylight.yangtools.yang.binding.InstanceIdentifier; -import org.opendaylight.yangtools.yang.common.RpcResult; /** * FIXME: THis test should be moved to sal-binding-broker and rewriten @@ -35,25 +34,16 @@ public class ConcurrentImplicitCreateTest extends AbstractDataServiceTest { private static final InstanceIdentifier BAR_PATH = TOP_PATH.child(TopLevelList.class, BAR_KEY); @Test - public void testConcurrentCreate() throws InterruptedException, ExecutionException { + public void testConcurrentCreate() throws InterruptedException, ExecutionException, TimeoutException { - DataModificationTransaction fooTx = baDataService.beginTransaction(); - DataModificationTransaction barTx = baDataService.beginTransaction(); + DataBroker dataBroker = testContext.getDataBroker(); + WriteTransaction fooTx = dataBroker.newWriteOnlyTransaction(); + WriteTransaction barTx = dataBroker.newWriteOnlyTransaction(); - fooTx.putOperationalData(FOO_PATH, new TopLevelListBuilder().setKey(FOO_KEY).build()); - barTx.putOperationalData(BAR_PATH, new TopLevelListBuilder().setKey(BAR_KEY).build()); - - Future> fooFuture = fooTx.commit(); - Future> barFuture = barTx.commit(); - - RpcResult fooResult = fooFuture.get(); - RpcResult barResult = barFuture.get(); - - assertTrue(fooResult.isSuccessful()); - assertTrue(barResult.isSuccessful()); - - assertEquals(TransactionStatus.COMMITED, fooResult.getResult()); - assertEquals(TransactionStatus.COMMITED, barResult.getResult()); + fooTx.put(LogicalDatastoreType.OPERATIONAL, FOO_PATH, new TopLevelListBuilder().setKey(FOO_KEY).build()); + barTx.put(LogicalDatastoreType.OPERATIONAL, BAR_PATH, new TopLevelListBuilder().setKey(BAR_KEY).build()); + fooTx.submit().get(5, TimeUnit.SECONDS); + barTx.submit().get(5, TimeUnit.SECONDS); } }