X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-binding-it%2Fsrc%2Ftest%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Ftest%2Fsal%2Fbinding%2Fit%2FAbstractTest.java;h=4057d9d1bc0ec3807b85754764bbbc108dc095a6;hb=b3e0b00065cf40a359d4fd295b14d89c838f54e5;hp=cddf7e83304ea33b70e2621e95fb868979786d65;hpb=e41b96adc85177b252b3a47816f9f9f6b5571362;p=controller.git

diff --git a/opendaylight/md-sal/sal-binding-it/src/test/java/org/opendaylight/controller/test/sal/binding/it/AbstractTest.java b/opendaylight/md-sal/sal-binding-it/src/test/java/org/opendaylight/controller/test/sal/binding/it/AbstractTest.java
index cddf7e8330..4057d9d1bc 100644
--- a/opendaylight/md-sal/sal-binding-it/src/test/java/org/opendaylight/controller/test/sal/binding/it/AbstractTest.java
+++ b/opendaylight/md-sal/sal-binding-it/src/test/java/org/opendaylight/controller/test/sal/binding/it/AbstractTest.java
@@ -1,6 +1,7 @@
 package org.opendaylight.controller.test.sal.binding.it;
 
 import static org.ops4j.pax.exam.CoreOptions.*;
+import static org.opendaylight.controller.test.sal.binding.it.TestHelper.*;
 
 import javax.inject.Inject;
 
@@ -17,115 +18,48 @@ public abstract class AbstractTest {
 
     public static final String CONTROLLER = "org.opendaylight.controller";
     public static final String YANGTOOLS = "org.opendaylight.yangtools";
-    
+
     public static final String CONTROLLER_MODELS = "org.opendaylight.controller.model";
     public static final String YANGTOOLS_MODELS = "org.opendaylight.yangtools.model";
-    
-    
+
     @Inject
     BindingAwareBroker broker;
 
     @Inject
     BundleContext bundleContext;
 
-    
-    
     public BindingAwareBroker getBroker() {
         return broker;
     }
 
-
-
     public void setBroker(BindingAwareBroker broker) {
         this.broker = broker;
     }
 
-
-
     public BundleContext getBundleContext() {
         return bundleContext;
     }
 
-
-
     public void setBundleContext(BundleContext bundleContext) {
         this.bundleContext = bundleContext;
     }
 
-
-
     @Configuration
     public Option[] config() {
-        return options(systemProperty("osgi.console").value("2401"), 
-                mavenBundle("org.slf4j", "slf4j-api").versionAsInProject(), //
+        return options(systemProperty("osgi.console").value("2401"), mavenBundle("org.slf4j", "slf4j-api")
+                .versionAsInProject(), //
                 mavenBundle("org.slf4j", "log4j-over-slf4j").versionAsInProject(), //
                 mavenBundle("ch.qos.logback", "logback-core").versionAsInProject(), //
                 mavenBundle("ch.qos.logback", "logback-classic").versionAsInProject(), //
+
+                configMinumumBundles(),
                 
-                // MD-SAL Dependencies
-                mavenBundle(YANGTOOLS, "concepts").versionAsInProject(),
-                mavenBundle(YANGTOOLS, "yang-binding").versionAsInProject(), //
-                mavenBundle(YANGTOOLS, "yang-common").versionAsInProject(), //
-                
-                mavenBundle(YANGTOOLS+".thirdparty", "xtend-lib-osgi").versionAsInProject(),
-                mavenBundle("com.google.guava", "guava").versionAsInProject(), //
-                mavenBundle("org.javassist", "javassist").versionAsInProject(),
-                
-                // MD SAL
-                mavenBundle(CONTROLLER, "sal-binding-api").versionAsInProject(), //
-                mavenBundle(CONTROLLER, "sal-binding-broker-impl").versionAsInProject(), //
-                mavenBundle(CONTROLLER, "sal-common").versionAsInProject(), //
-                mavenBundle(CONTROLLER, "sal-common-api").versionAsInProject(),
-                mavenBundle(CONTROLLER, "sal-common-util").versionAsInProject(), //
-                
+                mdSalCoreBundles(),
+
+                bindingAwareSalBundles(),
+
                 // BASE Models
-                mavenBundle(YANGTOOLS_MODELS,"yang-ext").versionAsInProject(),
-                mavenBundle(YANGTOOLS_MODELS,"ietf-inet-types").versionAsInProject(),
-                mavenBundle(YANGTOOLS_MODELS,"ietf-yang-types").versionAsInProject(),
-                mavenBundle(YANGTOOLS_MODELS,"opendaylight-l2-types").versionAsInProject(),
-                mavenBundle(CONTROLLER_MODELS,"model-flow-base").versionAsInProject(),
-                mavenBundle(CONTROLLER_MODELS,"model-flow-service").versionAsInProject(),
-                mavenBundle(CONTROLLER_MODELS,"model-inventory").versionAsInProject(),
-                junitAndMockitoBundles()
-                );
+                baseModelBundles(), flowCapableModelBundles(), junitAndMockitoBundles());
     }
     
-    
-    public static Option junitAndMockitoBundles() {
-        return new DefaultCompositeOption(
-                // Repository required to load harmcrest (OSGi-fied version).
-                repository("http://repository.springsource.com/maven/bundles/external").id(
-                        "com.springsource.repository.bundles.external"),
-
-                // Mockito without Hamcrest and Objenesis
-                mavenBundle("org.mockito", "mockito-all", "1.9.5"),
-
-                // Hamcrest with a version matching the range expected by Mockito
-                //mavenBundle("org.hamcrest", "com.springsource.org.hamcrest.core", "1.1.0"),
-
-                // Objenesis with a version matching the range expected by Mockito
-                //wrappedBundle(mavenBundle("org.objenesis", "objenesis", "1.2"))
-                 //       .exports("*;version=1.2"),
-
-                // The default JUnit bundle also exports Hamcrest, but with an (incorrect) version of
-                // 4.9 which does not match the Mockito import. When deployed after the hamcrest bundles, it gets
-                // resolved correctly.
-                junitBundles(),
-
-                /*
-                 * Felix has implicit boot delegation enabled by default. It conflicts with Mockito:
-                 * java.lang.LinkageError: loader constraint violation in interface itable initialization:
-                 * when resolving method "org.osgi.service.useradmin.User$$EnhancerByMockitoWithCGLIB$$dd2f81dc
-                 * .newInstance(Lorg/mockito/cglib/proxy/Callback;)Ljava/lang/Object;" the class loader
-                 * (instance of org/mockito/internal/creation/jmock/SearchingClassLoader) of the current class,
-                 * org/osgi/service/useradmin/User$$EnhancerByMockitoWithCGLIB$$dd2f81dc, and the class loader
-                 * (instance of org/apache/felix/framework/BundleWiringImpl$BundleClassLoaderJava5) for interface
-                 * org/mockito/cglib/proxy/Factory have different Class objects for the type org/mockito/cglib/
-                 * proxy/Callback used in the signature
-                 *
-                 * So we disable the bootdelegation. this property has no effect on the other OSGi implementation.
-                 */
-                frameworkProperty("felix.bootdelegation.implicit").value("false")
-        );
-    }
 }