X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-clustering-commons%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Fcommon%2Factor%2FMeteredBoundedMailbox.java;h=2a6aac4d79d95ec603591fa84865d0517c35d84d;hb=2d62916cb1f4b4045f4fc38fbd313f8339f9ac67;hp=458f379f845904786a77d992c87b1e1f3bbe5c2c;hpb=eeb7581f3d675fa499638e90f01e657c73c67c73;p=controller.git diff --git a/opendaylight/md-sal/sal-clustering-commons/src/main/java/org/opendaylight/controller/cluster/common/actor/MeteredBoundedMailbox.java b/opendaylight/md-sal/sal-clustering-commons/src/main/java/org/opendaylight/controller/cluster/common/actor/MeteredBoundedMailbox.java index 458f379f84..2a6aac4d79 100644 --- a/opendaylight/md-sal/sal-clustering-commons/src/main/java/org/opendaylight/controller/cluster/common/actor/MeteredBoundedMailbox.java +++ b/opendaylight/md-sal/sal-clustering-commons/src/main/java/org/opendaylight/controller/cluster/common/actor/MeteredBoundedMailbox.java @@ -26,9 +26,9 @@ public class MeteredBoundedMailbox implements MailboxType, ProducesMessageQueue< private final Logger LOG = LoggerFactory.getLogger(MeteredBoundedMailbox.class); private MeteredMessageQueue queue; - private Integer capacity; - private FiniteDuration pushTimeOut; - private MetricRegistry registry; + private final Integer capacity; + private final FiniteDuration pushTimeOut; + private final MetricRegistry registry; private final String QUEUE_SIZE = "q-size"; @@ -38,7 +38,7 @@ public class MeteredBoundedMailbox implements MailboxType, ProducesMessageQueue< this.capacity = commonConfig.getMailBoxCapacity(); this.pushTimeOut = commonConfig.getMailBoxPushTimeout(); - MetricsReporter reporter = MetricsReporter.getInstance(); + MetricsReporter reporter = MetricsReporter.getInstance(MeteringBehavior.DOMAIN); registry = reporter.getMetricsRegistry(); } @@ -55,24 +55,27 @@ public class MeteredBoundedMailbox implements MailboxType, ProducesMessageQueue< return; //there's no actor to monitor } String actorName = owner.get().path().toStringWithoutAddress(); - String metricName = registry.name(actorName, QUEUE_SIZE); + String metricName = MetricRegistry.name(actorName, QUEUE_SIZE); if (registry.getMetrics().containsKey(metricName)) + { return; //already registered + } - Gauge queueSize = getQueueSizeGuage(monitoredQueue); + Gauge queueSize = getQueueSizeGuage(monitoredQueue); registerQueueSizeMetric(metricName, queueSize); } public static class MeteredMessageQueue extends BoundedDequeBasedMailbox.MessageQueue { + private static final long serialVersionUID = 1L; public MeteredMessageQueue(int capacity, FiniteDuration pushTimeOut) { super(capacity, pushTimeOut); } } - private Gauge getQueueSizeGuage(final MeteredMessageQueue monitoredQueue ){ + private Gauge getQueueSizeGuage(final MeteredMessageQueue monitoredQueue ){ return new Gauge() { @Override public Integer getValue() { @@ -81,7 +84,7 @@ public class MeteredBoundedMailbox implements MailboxType, ProducesMessageQueue< }; } - private void registerQueueSizeMetric(String metricName, Gauge metric){ + private void registerQueueSizeMetric(String metricName, Gauge metric){ try { registry.register(metricName,metric); } catch (IllegalArgumentException e) {