X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-clustering-commons%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Fdatastore%2Fnode%2Futils%2Fstream%2FAbstractNormalizedNodeDataOutput.java;h=447a588a10239f1b33a8665664829e1d4d92951d;hb=a7da626a1de6eaa413cb33211d6aaccaaf1d57ab;hp=02bebebd2949d397d9234a27215f1e84de0ce299;hpb=77f491931ec07f6972869b8cbfa2207857990cec;p=controller.git diff --git a/opendaylight/md-sal/sal-clustering-commons/src/main/java/org/opendaylight/controller/cluster/datastore/node/utils/stream/AbstractNormalizedNodeDataOutput.java b/opendaylight/md-sal/sal-clustering-commons/src/main/java/org/opendaylight/controller/cluster/datastore/node/utils/stream/AbstractNormalizedNodeDataOutput.java index 02bebebd29..447a588a10 100755 --- a/opendaylight/md-sal/sal-clustering-commons/src/main/java/org/opendaylight/controller/cluster/datastore/node/utils/stream/AbstractNormalizedNodeDataOutput.java +++ b/opendaylight/md-sal/sal-clustering-commons/src/main/java/org/opendaylight/controller/cluster/datastore/node/utils/stream/AbstractNormalizedNodeDataOutput.java @@ -44,6 +44,7 @@ abstract class AbstractNormalizedNodeDataOutput implements NormalizedNodeDataOut private NormalizedNodeWriter normalizedNodeWriter; private boolean headerWritten; private QName lastLeafSetQName; + private boolean inSimple; AbstractNormalizedNodeDataOutput(final DataOutput output) { this.output = Preconditions.checkNotNull(output); @@ -59,8 +60,6 @@ abstract class AbstractNormalizedNodeDataOutput implements NormalizedNodeDataOut protected abstract short streamVersion(); - protected abstract void writeQName(QName qname) throws IOException; - protected abstract void writeString(String string) throws IOException; @Override @@ -162,18 +161,15 @@ abstract class AbstractNormalizedNodeDataOutput implements NormalizedNodeDataOut } @Override - public void leafNode(final NodeIdentifier name, final Object value) throws IOException, IllegalArgumentException { + public void startLeafNode(final NodeIdentifier name) throws IOException { Preconditions.checkNotNull(name, "Node identifier should not be null"); - LOG.trace("Writing a new leaf node"); + LOG.trace("Starting a new leaf node"); startNode(name.getNodeType(), NodeTypes.LEAF_NODE); - - writeObject(value); + inSimple = true; } @Override - public void startLeafSet(final NodeIdentifier name, final int childSizeHint) - - throws IOException, IllegalArgumentException { + public void startLeafSet(final NodeIdentifier name, final int childSizeHint) throws IOException { Preconditions.checkNotNull(name, "Node identifier should not be null"); LOG.trace("Starting a new leaf set"); @@ -182,8 +178,7 @@ abstract class AbstractNormalizedNodeDataOutput implements NormalizedNodeDataOut } @Override - public void startOrderedLeafSet(final NodeIdentifier name, final int childSizeHint) - throws IOException, IllegalArgumentException { + public void startOrderedLeafSet(final NodeIdentifier name, final int childSizeHint) throws IOException { Preconditions.checkNotNull(name, "Node identifier should not be null"); LOG.trace("Starting a new ordered leaf set"); @@ -192,23 +187,21 @@ abstract class AbstractNormalizedNodeDataOutput implements NormalizedNodeDataOut } @Override - public void leafSetEntryNode(final QName name, final Object value) throws IOException, IllegalArgumentException { - LOG.trace("Writing a new leaf set entry node"); + public void startLeafSetEntryNode(final NodeWithValue name) throws IOException { + LOG.trace("Starting a new leaf set entry node"); output.writeByte(NodeTypes.LEAF_SET_ENTRY_NODE); // lastLeafSetQName is set if the parent LeafSetNode was previously written. Otherwise this is a // stand alone LeafSetEntryNode so write out it's name here. if (lastLeafSetQName == null) { - writeQName(name); + writeQName(name.getNodeType()); } - - writeObject(value); + inSimple = true; } @Override - public void startContainerNode(final NodeIdentifier name, final int childSizeHint) - throws IOException, IllegalArgumentException { + public void startContainerNode(final NodeIdentifier name, final int childSizeHint) throws IOException { Preconditions.checkNotNull(name, "Node identifier should not be null"); LOG.trace("Starting a new container node"); @@ -217,8 +210,7 @@ abstract class AbstractNormalizedNodeDataOutput implements NormalizedNodeDataOut } @Override - public void startYangModeledAnyXmlNode(final NodeIdentifier name, final int childSizeHint) - throws IOException, IllegalArgumentException { + public void startYangModeledAnyXmlNode(final NodeIdentifier name, final int childSizeHint) throws IOException { Preconditions.checkNotNull(name, "Node identifier should not be null"); LOG.trace("Starting a new yang modeled anyXml node"); @@ -227,8 +219,7 @@ abstract class AbstractNormalizedNodeDataOutput implements NormalizedNodeDataOut } @Override - public void startUnkeyedList(final NodeIdentifier name, final int childSizeHint) - throws IOException, IllegalArgumentException { + public void startUnkeyedList(final NodeIdentifier name, final int childSizeHint) throws IOException { Preconditions.checkNotNull(name, "Node identifier should not be null"); LOG.trace("Starting a new unkeyed list"); @@ -236,8 +227,7 @@ abstract class AbstractNormalizedNodeDataOutput implements NormalizedNodeDataOut } @Override - public void startUnkeyedListItem(final NodeIdentifier name, final int childSizeHint) - throws IOException, IllegalStateException { + public void startUnkeyedListItem(final NodeIdentifier name, final int childSizeHint) throws IOException { Preconditions.checkNotNull(name, "Node identifier should not be null"); LOG.trace("Starting a new unkeyed list item"); @@ -245,8 +235,7 @@ abstract class AbstractNormalizedNodeDataOutput implements NormalizedNodeDataOut } @Override - public void startMapNode(final NodeIdentifier name, final int childSizeHint) - throws IOException, IllegalArgumentException { + public void startMapNode(final NodeIdentifier name, final int childSizeHint) throws IOException { Preconditions.checkNotNull(name, "Node identifier should not be null"); LOG.trace("Starting a new map node"); @@ -255,18 +244,16 @@ abstract class AbstractNormalizedNodeDataOutput implements NormalizedNodeDataOut @Override public void startMapEntryNode(final NodeIdentifierWithPredicates identifier, final int childSizeHint) - throws IOException, IllegalArgumentException { + throws IOException { Preconditions.checkNotNull(identifier, "Node identifier should not be null"); LOG.trace("Starting a new map entry node"); startNode(identifier.getNodeType(), NodeTypes.MAP_ENTRY_NODE); writeKeyValueMap(identifier.getKeyValues()); - } @Override - public void startOrderedMapNode(final NodeIdentifier name, final int childSizeHint) - throws IOException, IllegalArgumentException { + public void startOrderedMapNode(final NodeIdentifier name, final int childSizeHint) throws IOException { Preconditions.checkNotNull(name, "Node identifier should not be null"); LOG.trace("Starting a new ordered map node"); @@ -274,8 +261,7 @@ abstract class AbstractNormalizedNodeDataOutput implements NormalizedNodeDataOut } @Override - public void startChoiceNode(final NodeIdentifier name, final int childSizeHint) - throws IOException, IllegalArgumentException { + public void startChoiceNode(final NodeIdentifier name, final int childSizeHint) throws IOException { Preconditions.checkNotNull(name, "Node identifier should not be null"); LOG.trace("Starting a new choice node"); @@ -283,25 +269,32 @@ abstract class AbstractNormalizedNodeDataOutput implements NormalizedNodeDataOut } @Override - public void startAugmentationNode(final AugmentationIdentifier identifier) - throws IOException, IllegalArgumentException { + public void startAugmentationNode(final AugmentationIdentifier identifier) throws IOException { Preconditions.checkNotNull(identifier, "Node identifier should not be null"); LOG.trace("Starting a new augmentation node"); output.writeByte(NodeTypes.AUGMENTATION_NODE); - writeQNameSet(identifier.getPossibleChildNames()); + writeAugmentationIdentifier(identifier); } @Override - public void anyxmlNode(final NodeIdentifier name, final Object value) throws IOException, IllegalArgumentException { + public void startAnyxmlNode(final NodeIdentifier name) throws IOException { Preconditions.checkNotNull(name, "Node identifier should not be null"); - LOG.trace("Writing any xml node"); - + LOG.trace("Starting any xml node"); startNode(name.getNodeType(), NodeTypes.ANY_XML_NODE); + inSimple = true; + } + + @Override + public void scalarValue(final Object value) throws IOException { + writeObject(value); + } + @Override + public void domSourceValue(final DOMSource value) throws IOException { try { StreamResult xmlOutput = new StreamResult(new StringWriter()); - TransformerFactory.newInstance().newTransformer().transform((DOMSource)value, xmlOutput); + TransformerFactory.newInstance().newTransformer().transform(value, xmlOutput); writeObject(xmlOutput.getWriter().toString()); } catch (TransformerException | TransformerFactoryConfigurationError e) { throw new IOException("Error writing anyXml", e); @@ -309,10 +302,13 @@ abstract class AbstractNormalizedNodeDataOutput implements NormalizedNodeDataOut } @Override - public void endNode() throws IOException, IllegalStateException { + public void endNode() throws IOException { LOG.trace("Ending the node"); - lastLeafSetQName = null; - output.writeByte(NodeTypes.END_NODE); + if (!inSimple) { + lastLeafSetQName = null; + output.writeByte(NodeTypes.END_NODE); + } + inSimple = false; } @Override @@ -329,6 +325,7 @@ abstract class AbstractNormalizedNodeDataOutput implements NormalizedNodeDataOut private void startNode(final QName qname, final byte nodeType) throws IOException { Preconditions.checkNotNull(qname, "QName of node identifier should not be null."); + Preconditions.checkState(!inSimple, "Attempted to start a child in a simple node"); ensureHeaderWritten(); @@ -411,10 +408,8 @@ abstract class AbstractNormalizedNodeDataOutput implements NormalizedNodeDataOut case PathArgumentTypes.AUGMENTATION_IDENTIFIER : - AugmentationIdentifier augmentationIdentifier = (AugmentationIdentifier) pathArgument; - // No Qname in augmentation identifier - writeQNameSet(augmentationIdentifier.getPossibleChildNames()); + writeAugmentationIdentifier((AugmentationIdentifier) pathArgument); break; default : throw new IllegalStateException("Unknown node identifier type is found : " @@ -435,11 +430,12 @@ abstract class AbstractNormalizedNodeDataOutput implements NormalizedNodeDataOut } } - private void writeQNameSet(final Set children) throws IOException { + void writeAugmentationIdentifier(final AugmentationIdentifier aid) throws IOException { + final Set qnames = aid.getPossibleChildNames(); // Write each child's qname separately, if list is empty send count as 0 - if (children != null && !children.isEmpty()) { - output.writeInt(children.size()); - for (QName qname : children) { + if (!qnames.isEmpty()) { + output.writeInt(qnames.size()); + for (QName qname : qnames) { writeQName(qname); } } else {