X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-distributed-datastore%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Fdatastore%2FDataChangeListenerSupport.java;h=05accddb7885625a89d93d4bc8936bf763c267b1;hb=d207a2f677545357095f2e5f145a5ecc8d3a60dd;hp=7a033cf21fd2d1037c56e6125ae4637048deef71;hpb=189586eeeeeeb8a9b6ed7398450d198f1864c307;p=controller.git diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/DataChangeListenerSupport.java b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/DataChangeListenerSupport.java index 7a033cf21f..05accddb78 100644 --- a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/DataChangeListenerSupport.java +++ b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/DataChangeListenerSupport.java @@ -7,95 +7,125 @@ */ package org.opendaylight.controller.cluster.datastore; -import com.google.common.base.Preconditions; -import java.util.ArrayList; -import java.util.List; import akka.actor.ActorRef; import akka.actor.ActorSelection; +import com.google.common.base.Optional; +import java.util.ArrayList; +import java.util.List; +import java.util.Map.Entry; import org.opendaylight.controller.cluster.datastore.messages.EnableNotification; import org.opendaylight.controller.cluster.datastore.messages.RegisterChangeListener; import org.opendaylight.controller.cluster.datastore.messages.RegisterChangeListenerReply; import org.opendaylight.controller.md.sal.common.api.data.AsyncDataChangeListener; +import org.opendaylight.controller.md.sal.dom.store.impl.DataChangeListenerRegistration; import org.opendaylight.yangtools.concepts.ListenerRegistration; import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier; import org.opendaylight.yangtools.yang.data.api.schema.NormalizedNode; +import org.opendaylight.yangtools.yang.data.api.schema.tree.DataTreeCandidate; import org.slf4j.Logger; import org.slf4j.LoggerFactory; -final class DataChangeListenerSupport extends LeaderLocalDelegateFactory>>> { +final class DataChangeListenerSupport extends LeaderLocalDelegateFactory>>, + Optional> { private static final Logger LOG = LoggerFactory.getLogger(DataChangeListenerSupport.class); private final List delayedListenerRegistrations = new ArrayList<>(); private final List dataChangeListeners = new ArrayList<>(); - private final Shard shard; + private final List delayedRegisterOnAllListeners = new ArrayList<>(); DataChangeListenerSupport(final Shard shard) { - this.shard = Preconditions.checkNotNull(shard); + super(shard); } @Override - void onLeadershipChange(final boolean isLeader) { + void onLeadershipChange(final boolean isLeader, boolean hasLeader) { + LOG.debug("onLeadershipChange, isLeader: {}, hasLeader : {}", isLeader, hasLeader); + for (ActorSelection dataChangeListener : dataChangeListeners) { - dataChangeListener.tell(new EnableNotification(isLeader), shard.getSelf()); + dataChangeListener.tell(new EnableNotification(isLeader), getSelf()); + } + + if(hasLeader) { + for (DelayedListenerRegistration reg : delayedRegisterOnAllListeners) { + registerDelayedListeners(reg); + } + delayedRegisterOnAllListeners.clear(); } if (isLeader) { for (DelayedListenerRegistration reg: delayedListenerRegistrations) { - if(!reg.isClosed()) { - reg.setDelegate(createDelegate(reg.getRegisterChangeListener())); - } + registerDelayedListeners(reg); } delayedListenerRegistrations.clear(); } } + private void registerDelayedListeners(DelayedListenerRegistration reg) { + if(!reg.isClosed()) { + final Entry>>, + Optional> res = createDelegate(reg.getRegisterChangeListener()); + reg.setDelegate(res.getKey()); + getShard().getDataStore().notifyOfInitialData(res.getKey(), res.getValue()); + } + } + @Override - void onMessage(final RegisterChangeListener message, final boolean isLeader) { + void onMessage(final RegisterChangeListener message, final boolean isLeader, boolean hasLeader) { - LOG.debug("{}: registerDataChangeListener for {}, leader: {}", shard.persistenceId(), message.getPath(), isLeader); + LOG.debug("{}: registerDataChangeListener for {}, isLeader: {}, hasLeader : {}", + persistenceId(), message.getPath(), isLeader, hasLeader); - ListenerRegistration>> registration; - if (isLeader) { - registration = createDelegate(message); + if ((hasLeader && message.isRegisterOnAllInstances()) || isLeader) { + final Entry>>, + Optional> res = createDelegate(message); + registration = res.getKey(); + + getShard().getDataStore().notifyOfInitialData(res.getKey(), res.getValue()); } else { - LOG.debug("{}: Shard is not the leader - delaying registration", shard.persistenceId()); + LOG.debug("{}: Shard is not the leader - delaying registration", persistenceId()); DelayedListenerRegistration delayedReg = new DelayedListenerRegistration(message); - delayedListenerRegistrations.add(delayedReg); + if(message.isRegisterOnAllInstances()) { + delayedRegisterOnAllListeners.add(delayedReg); + } else { + delayedListenerRegistrations.add(delayedReg); + } registration = delayedReg; } - ActorRef listenerRegistration = shard.getContext().actorOf( - DataChangeListenerRegistration.props(registration)); + ActorRef listenerRegistration = createActor(DataChangeListenerRegistrationActor.props(registration)); LOG.debug("{}: registerDataChangeListener sending reply, listenerRegistrationPath = {} ", - shard.persistenceId(), listenerRegistration.path()); + persistenceId(), listenerRegistration.path()); - shard.getSender().tell(new RegisterChangeListenerReply(listenerRegistration), shard.getSelf()); + tellSender(new RegisterChangeListenerReply(listenerRegistration)); } @Override - ListenerRegistration>> createDelegate( - final RegisterChangeListener message) { - ActorSelection dataChangeListenerPath = shard.getContext().system().actorSelection( - message.getDataChangeListenerPath()); + Entry>>, + Optional> createDelegate(final RegisterChangeListener message) { + ActorSelection dataChangeListenerPath = selectActor(message.getDataChangeListenerPath()); // Notify the listener if notifications should be enabled or not // If this shard is the leader then it will enable notifications else // it will not - dataChangeListenerPath.tell(new EnableNotification(true), shard.getSelf()); + dataChangeListenerPath.tell(new EnableNotification(true), getSelf()); // Now store a reference to the data change listener so it can be notified // at a later point if notifications should be enabled or disabled - dataChangeListeners.add(dataChangeListenerPath); + if(!message.isRegisterOnAllInstances()) { + dataChangeListeners.add(dataChangeListenerPath); + } AsyncDataChangeListener> listener = new DataChangeListenerProxy(dataChangeListenerPath); - LOG.debug("{}: Registering for path {}", shard.persistenceId(), message.getPath()); + LOG.debug("{}: Registering for path {}", persistenceId(), message.getPath()); - return shard.getDataStore().registerChangeListener(message.getPath(), listener, + return getShard().getDataStore().registerChangeListener(message.getPath(), listener, message.getScope()); } }