X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-distributed-datastore%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Fdatastore%2FDataChangeListenerSupport.java;h=2e26e6ee36d170d4bb0d3da3ae3d276d8f62305c;hb=e7da6f458d9278b2276671dc3164c9cde24ac9ef;hp=05accddb7885625a89d93d4bc8936bf763c267b1;hpb=d9ea4400df226eb65c964ab0cb2aa81ee495ba15;p=controller.git

diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/DataChangeListenerSupport.java b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/DataChangeListenerSupport.java
index 05accddb78..2e26e6ee36 100644
--- a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/DataChangeListenerSupport.java
+++ b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/DataChangeListenerSupport.java
@@ -10,122 +10,110 @@ package org.opendaylight.controller.cluster.datastore;
 import akka.actor.ActorRef;
 import akka.actor.ActorSelection;
 import com.google.common.base.Optional;
+import com.google.common.collect.Sets;
 import java.util.ArrayList;
-import java.util.List;
+import java.util.Collection;
 import java.util.Map.Entry;
+import java.util.Set;
 import org.opendaylight.controller.cluster.datastore.messages.EnableNotification;
 import org.opendaylight.controller.cluster.datastore.messages.RegisterChangeListener;
 import org.opendaylight.controller.cluster.datastore.messages.RegisterChangeListenerReply;
+import org.opendaylight.controller.md.sal.common.api.data.AsyncDataBroker.DataChangeScope;
 import org.opendaylight.controller.md.sal.common.api.data.AsyncDataChangeListener;
 import org.opendaylight.controller.md.sal.dom.store.impl.DataChangeListenerRegistration;
 import org.opendaylight.yangtools.concepts.ListenerRegistration;
 import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier;
 import org.opendaylight.yangtools.yang.data.api.schema.NormalizedNode;
 import org.opendaylight.yangtools.yang.data.api.schema.tree.DataTreeCandidate;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
 
-final class DataChangeListenerSupport extends LeaderLocalDelegateFactory<RegisterChangeListener,
-        DataChangeListenerRegistration<AsyncDataChangeListener<YangInstanceIdentifier, NormalizedNode<?, ?>>>,
-        Optional<DataTreeCandidate>> {
-    private static final Logger LOG = LoggerFactory.getLogger(DataChangeListenerSupport.class);
-    private final List<DelayedListenerRegistration> delayedListenerRegistrations = new ArrayList<>();
-    private final List<ActorSelection> dataChangeListeners =  new ArrayList<>();
-    private final List<DelayedListenerRegistration> delayedRegisterOnAllListeners = new ArrayList<>();
+final class DataChangeListenerSupport extends AbstractDataListenerSupport<
+        AsyncDataChangeListener<YangInstanceIdentifier, NormalizedNode<?, ?>>, RegisterChangeListener,
+            DelayedDataChangeListenerRegistration, DataChangeListenerRegistration<
+                    AsyncDataChangeListener<YangInstanceIdentifier, NormalizedNode<?, ?>>>> {
+
+    private final Set<ActorSelection> listenerActors = Sets.newConcurrentHashSet();
 
     DataChangeListenerSupport(final Shard shard) {
         super(shard);
     }
 
+    Collection<ActorSelection> getListenerActors() {
+        return new ArrayList<>(listenerActors);
+    }
+
     @Override
-    void onLeadershipChange(final boolean isLeader, boolean hasLeader) {
-        LOG.debug("onLeadershipChange, isLeader: {}, hasLeader : {}", isLeader, hasLeader);
+    DataChangeListenerRegistration<AsyncDataChangeListener<YangInstanceIdentifier, NormalizedNode<?, ?>>>
+            createDelegate(final RegisterChangeListener message) {
+        final ActorSelection dataChangeListenerPath = selectActor(message.getDataChangeListenerPath());
 
-        for (ActorSelection dataChangeListener : dataChangeListeners) {
-            dataChangeListener.tell(new EnableNotification(isLeader), getSelf());
-        }
+        // Notify the listener if notifications should be enabled or not
+        // If this shard is the leader then it will enable notifications else
+        // it will not
+        dataChangeListenerPath.tell(new EnableNotification(true), getSelf());
 
-        if(hasLeader) {
-            for (DelayedListenerRegistration reg : delayedRegisterOnAllListeners) {
-                registerDelayedListeners(reg);
-            }
-            delayedRegisterOnAllListeners.clear();
+        // Now store a reference to the data change listener so it can be notified
+        // at a later point if notifications should be enabled or disabled
+        if (!message.isRegisterOnAllInstances()) {
+            addListenerActor(dataChangeListenerPath);
         }
 
-        if (isLeader) {
-            for (DelayedListenerRegistration reg: delayedListenerRegistrations) {
-                registerDelayedListeners(reg);
-            }
+        AsyncDataChangeListener<YangInstanceIdentifier, NormalizedNode<?, ?>> listener =
+                new DataChangeListenerProxy(dataChangeListenerPath);
 
-            delayedListenerRegistrations.clear();
-        }
-    }
+        log().debug("{}: Registering for path {}", persistenceId(), message.getPath());
 
-    private void registerDelayedListeners(DelayedListenerRegistration reg) {
-        if(!reg.isClosed()) {
-            final Entry<DataChangeListenerRegistration<AsyncDataChangeListener<YangInstanceIdentifier, NormalizedNode<?, ?>>>,
-                            Optional<DataTreeCandidate>> res = createDelegate(reg.getRegisterChangeListener());
-            reg.setDelegate(res.getKey());
-            getShard().getDataStore().notifyOfInitialData(res.getKey(), res.getValue());
-        }
-    }
+        Entry<DataChangeListenerRegistration<AsyncDataChangeListener<YangInstanceIdentifier, NormalizedNode<?, ?>>>,
+                Optional<DataTreeCandidate>> regEntry = getShard().getDataStore().registerChangeListener(
+                        message.getPath(), listener, message.getScope());
 
-    @Override
-    void onMessage(final RegisterChangeListener message, final boolean isLeader, boolean hasLeader) {
-
-        LOG.debug("{}: registerDataChangeListener for {}, isLeader: {}, hasLeader : {}",
-            persistenceId(), message.getPath(), isLeader, hasLeader);
-
-        final ListenerRegistration<AsyncDataChangeListener<YangInstanceIdentifier,
-                                                     NormalizedNode<?, ?>>> registration;
-        if ((hasLeader && message.isRegisterOnAllInstances()) || isLeader) {
-            final Entry<DataChangeListenerRegistration<AsyncDataChangeListener<YangInstanceIdentifier, NormalizedNode<?, ?>>>,
-                    Optional<DataTreeCandidate>> res = createDelegate(message);
-            registration = res.getKey();
-
-            getShard().getDataStore().notifyOfInitialData(res.getKey(), res.getValue());
-        } else {
-            LOG.debug("{}: Shard is not the leader - delaying registration", persistenceId());
-
-            DelayedListenerRegistration delayedReg = new DelayedListenerRegistration(message);
-            if(message.isRegisterOnAllInstances()) {
-                delayedRegisterOnAllListeners.add(delayedReg);
-            } else {
-                delayedListenerRegistrations.add(delayedReg);
+        getShard().getDataStore().notifyOfInitialData(regEntry.getKey(), regEntry.getValue());
+
+        listenerActors.add(dataChangeListenerPath);
+        final DataChangeListenerRegistration<AsyncDataChangeListener<YangInstanceIdentifier, NormalizedNode<?, ?>>>
+            delegate = regEntry.getKey();
+        return new DataChangeListenerRegistration<AsyncDataChangeListener<YangInstanceIdentifier,
+                NormalizedNode<?,?>>>() {
+            @Override
+            public void close() {
+                listenerActors.remove(dataChangeListenerPath);
+                delegate.close();
             }
-            registration = delayedReg;
-        }
 
-        ActorRef listenerRegistration = createActor(DataChangeListenerRegistrationActor.props(registration));
+            @Override
+            public AsyncDataChangeListener<YangInstanceIdentifier, NormalizedNode<?, ?>> getInstance() {
+                return delegate.getInstance();
+            }
 
-        LOG.debug("{}: registerDataChangeListener sending reply, listenerRegistrationPath = {} ",
-                persistenceId(), listenerRegistration.path());
+            @Override
+            public YangInstanceIdentifier getPath() {
+                return delegate.getPath();
+            }
 
-        tellSender(new RegisterChangeListenerReply(listenerRegistration));
+            @Override
+            public DataChangeScope getScope() {
+                return delegate.getScope();
+            }
+        };
     }
 
     @Override
-    Entry<DataChangeListenerRegistration<AsyncDataChangeListener<YangInstanceIdentifier, NormalizedNode<?, ?>>>,
-            Optional<DataTreeCandidate>> createDelegate(final RegisterChangeListener message) {
-        ActorSelection dataChangeListenerPath = selectActor(message.getDataChangeListenerPath());
-
-        // Notify the listener if notifications should be enabled or not
-        // If this shard is the leader then it will enable notifications else
-        // it will not
-        dataChangeListenerPath.tell(new EnableNotification(true), getSelf());
-
-        // Now store a reference to the data change listener so it can be notified
-        // at a later point if notifications should be enabled or disabled
-        if(!message.isRegisterOnAllInstances()) {
-            dataChangeListeners.add(dataChangeListenerPath);
-        }
+    protected DelayedDataChangeListenerRegistration newDelayedListenerRegistration(RegisterChangeListener message) {
+        return new DelayedDataChangeListenerRegistration(message);
+    }
 
-        AsyncDataChangeListener<YangInstanceIdentifier, NormalizedNode<?, ?>> listener =
-                new DataChangeListenerProxy(dataChangeListenerPath);
+    @Override
+    protected ActorRef newRegistrationActor(
+            ListenerRegistration<AsyncDataChangeListener<YangInstanceIdentifier, NormalizedNode<?, ?>>> registration) {
+        return createActor(DataChangeListenerRegistrationActor.props(registration));
+    }
 
-        LOG.debug("{}: Registering for path {}", persistenceId(), message.getPath());
+    @Override
+    protected Object newRegistrationReplyMessage(ActorRef registrationActor) {
+        return new RegisterChangeListenerReply(registrationActor);
+    }
 
-        return getShard().getDataStore().registerChangeListener(message.getPath(), listener,
-                message.getScope());
+    @Override
+    protected String logName() {
+        return "registerDataChangeListener";
     }
 }