X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-distributed-datastore%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Fdatastore%2FDataTreeChangeListenerActor.java;h=9384a84e382aceaed952efd2682d446b22f588ba;hb=546cd1fd100dbaa36908b22c2f422320dbd8c4b2;hp=2936a28b90a1f77cc640602c977751597fc8008b;hpb=013a6679470bf692753f2e04ab4398c97fd9f5d0;p=controller.git diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/DataTreeChangeListenerActor.java b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/DataTreeChangeListenerActor.java index 2936a28b90..9384a84e38 100644 --- a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/DataTreeChangeListenerActor.java +++ b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/DataTreeChangeListenerActor.java @@ -7,72 +7,102 @@ */ package org.opendaylight.controller.cluster.datastore; +import static java.util.Objects.requireNonNull; + +import akka.actor.ActorRef; import akka.actor.Props; -import com.google.common.base.Preconditions; import org.opendaylight.controller.cluster.common.actor.AbstractUntypedActor; import org.opendaylight.controller.cluster.datastore.messages.DataTreeChanged; import org.opendaylight.controller.cluster.datastore.messages.DataTreeChangedReply; import org.opendaylight.controller.cluster.datastore.messages.EnableNotification; -import org.opendaylight.controller.md.sal.dom.api.DOMDataTreeChangeListener; +import org.opendaylight.controller.cluster.datastore.messages.GetInfo; +import org.opendaylight.controller.cluster.datastore.messages.OnInitialData; +import org.opendaylight.controller.cluster.mgmt.api.DataTreeListenerInfo; +import org.opendaylight.mdsal.dom.api.DOMDataTreeChangeListener; import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier; /** * Proxy actor which acts as a facade to the user-provided listener. Responsible for decapsulating * DataTreeChanged messages and dispatching their context to the user. */ -final class DataTreeChangeListenerActor extends AbstractUntypedActor { +class DataTreeChangeListenerActor extends AbstractUntypedActor { private final DOMDataTreeChangeListener listener; private final YangInstanceIdentifier registeredPath; + private boolean notificationsEnabled = false; + private long notificationCount; + private String logContext = ""; - private DataTreeChangeListenerActor(final DOMDataTreeChangeListener listener, + DataTreeChangeListenerActor(final DOMDataTreeChangeListener listener, final YangInstanceIdentifier registeredPath) { - this.listener = Preconditions.checkNotNull(listener); - this.registeredPath = Preconditions.checkNotNull(registeredPath); + this.listener = requireNonNull(listener); + this.registeredPath = requireNonNull(registeredPath); } @Override - protected void handleReceive(final Object message) { + protected final void handleReceive(final Object message) { if (message instanceof DataTreeChanged) { - dataChanged((DataTreeChanged)message); + dataTreeChanged((DataTreeChanged) message); + } else if (message instanceof OnInitialData) { + onInitialData((OnInitialData) message); } else if (message instanceof EnableNotification) { enableNotification((EnableNotification) message); + } else if (message instanceof GetInfo) { + getSender().tell(new DataTreeListenerInfo(listener.toString(), registeredPath.toString(), + notificationsEnabled, notificationCount), getSelf()); } else { unknownMessage(message); } } @SuppressWarnings("checkstyle:IllegalCatch") - private void dataChanged(final DataTreeChanged message) { + void onInitialData(final OnInitialData message) { + LOG.debug("{}: Notifying onInitialData to listener {}", logContext, listener); + + try { + this.listener.onInitialData(); + } catch (Exception e) { + LOG.error("{}: Error notifying listener {}", logContext, this.listener, e); + } + } + + @SuppressWarnings("checkstyle:IllegalCatch") + void dataTreeChanged(final DataTreeChanged message) { // Do nothing if notifications are not enabled if (!notificationsEnabled) { - LOG.debug("Notifications not enabled for listener {} - dropping change notification", listener); + LOG.debug("{}: Notifications not enabled for listener {} - dropping change notification", + logContext, listener); return; } - LOG.debug("Sending change notification {} to listener {}", message.getChanges(), listener); + LOG.debug("{}: Sending {} change notification(s) {} to listener {}", logContext, message.getChanges().size(), + message.getChanges(), listener); + + notificationCount++; try { this.listener.onDataTreeChanged(message.getChanges()); } catch (Exception e) { - LOG.error("Error notifying listener {}", this.listener, e); + LOG.error("{}: Error notifying listener {}", logContext, this.listener, e); } // TODO: do we really need this? // It seems the sender is never null but it doesn't hurt to check. If the caller passes in // a null sender (ActorRef.noSender()), akka translates that to the deadLetters actor. - if (getSender() != null && !getContext().system().deadLetters().equals(getSender())) { - getSender().tell(DataTreeChangedReply.getInstance(), getSelf()); + final ActorRef sender = getSender(); + if (sender != null && !sender.equals(getContext().system().deadLetters())) { + sender.tell(DataTreeChangedReply.getInstance(), getSelf()); } } private void enableNotification(final EnableNotification message) { + logContext = message.getLogContext(); notificationsEnabled = message.isEnabled(); - LOG.debug("{} notifications for listener {}", notificationsEnabled ? "Enabled" : "Disabled", + LOG.debug("{}: {} notifications for listener {}", logContext, notificationsEnabled ? "Enabled" : "Disabled", listener); } - public static Props props(final DOMDataTreeChangeListener listener, final YangInstanceIdentifier registeredPath) { + static Props props(final DOMDataTreeChangeListener listener, final YangInstanceIdentifier registeredPath) { return Props.create(DataTreeChangeListenerActor.class, listener, registeredPath); } }