X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-distributed-datastore%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Fdatastore%2FDistributedDataStore.java;h=19c93b3dc418d15b0b772d8365122a897b4dff7d;hb=4c1877fd363bf0663c91b85b2bf5be64d22e56aa;hp=04a8e3098f979ded784abdb05495feaa0e0918b7;hpb=ffc46de334c8a903844b9f4aff73dc68b2401659;p=controller.git diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/DistributedDataStore.java b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/DistributedDataStore.java index 04a8e3098f..19c93b3dc4 100644 --- a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/DistributedDataStore.java +++ b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/DistributedDataStore.java @@ -19,7 +19,7 @@ import org.opendaylight.controller.cluster.datastore.config.Configuration; import org.opendaylight.controller.cluster.datastore.identifiers.ShardManagerIdentifier; import org.opendaylight.controller.cluster.datastore.jmx.mbeans.DatastoreConfigurationMXBeanImpl; import org.opendaylight.controller.cluster.datastore.jmx.mbeans.DatastoreInfoMXBeanImpl; -import org.opendaylight.controller.cluster.datastore.shardstrategy.ShardStrategyFactory; +import org.opendaylight.controller.cluster.datastore.messages.DatastoreSnapshot; import org.opendaylight.controller.cluster.datastore.utils.ActorContext; import org.opendaylight.controller.cluster.datastore.utils.Dispatchers; import org.opendaylight.controller.cluster.datastore.utils.PrimaryShardInfoFutureCache; @@ -54,7 +54,6 @@ public class DistributedDataStore implements DOMStore, SchemaContextListener, private final ActorContext actorContext; private final long waitTillReadyTimeInMillis; - private AutoCloseable closeable; private DatastoreConfigurationMXBeanImpl datastoreConfigMXBean; @@ -68,13 +67,14 @@ public class DistributedDataStore implements DOMStore, SchemaContextListener, private final TransactionContextFactory txContextFactory; public DistributedDataStore(ActorSystem actorSystem, ClusterWrapper cluster, - Configuration configuration, DatastoreContext datastoreContext) { + Configuration configuration, DatastoreContextFactory datastoreContextFactory, + DatastoreSnapshot restoreFromSnapshot) { Preconditions.checkNotNull(actorSystem, "actorSystem should not be null"); Preconditions.checkNotNull(cluster, "cluster should not be null"); Preconditions.checkNotNull(configuration, "configuration should not be null"); - Preconditions.checkNotNull(datastoreContext, "datastoreContext should not be null"); + Preconditions.checkNotNull(datastoreContextFactory, "datastoreContextFactory should not be null"); - this.type = datastoreContext.getDataStoreType(); + this.type = datastoreContextFactory.getBaseDatastoreContext().getDataStoreType(); String shardManagerId = ShardManagerIdentifier.builder().type(type).build().toString(); @@ -84,20 +84,26 @@ public class DistributedDataStore implements DOMStore, SchemaContextListener, new Dispatchers(actorSystem.dispatchers()).getDispatcherPath(Dispatchers.DispatcherType.Shard); PrimaryShardInfoFutureCache primaryShardInfoCache = new PrimaryShardInfoFutureCache(); - actorContext = new ActorContext(actorSystem, createShardManager(actorSystem, cluster, configuration, - datastoreContext, shardDispatcher, shardManagerId, primaryShardInfoCache), cluster, - configuration, datastoreContext, primaryShardInfoCache); + + ShardManager.Builder builder = ShardManager.builder().cluster(cluster).configuration(configuration). + datastoreContextFactory(datastoreContextFactory).waitTillReadyCountdownLatch(waitTillReadyCountDownLatch). + primaryShardInfoCache(primaryShardInfoCache).restoreFromSnapshot(restoreFromSnapshot); + + actorContext = new ActorContext(actorSystem, createShardManager(actorSystem, builder, shardDispatcher, + shardManagerId), cluster, configuration, datastoreContextFactory.getBaseDatastoreContext(), primaryShardInfoCache); this.waitTillReadyTimeInMillis = actorContext.getDatastoreContext().getShardLeaderElectionTimeout().duration().toMillis() * READY_WAIT_FACTOR; this.txContextFactory = TransactionContextFactory.create(actorContext); - datastoreConfigMXBean = new DatastoreConfigurationMXBeanImpl(datastoreContext.getDataStoreMXBeanType()); - datastoreConfigMXBean.setContext(datastoreContext); + datastoreConfigMXBean = new DatastoreConfigurationMXBeanImpl( + datastoreContextFactory.getBaseDatastoreContext().getDataStoreMXBeanType()); + datastoreConfigMXBean.setContext(datastoreContextFactory.getBaseDatastoreContext()); datastoreConfigMXBean.registerMBean(); - datastoreInfoMXBean = new DatastoreInfoMXBeanImpl(datastoreContext.getDataStoreMXBeanType(), actorContext); + datastoreInfoMXBean = new DatastoreInfoMXBeanImpl(datastoreContextFactory.getBaseDatastoreContext(). + getDataStoreMXBeanType(), actorContext); datastoreInfoMXBean.registerMBean(); } @@ -126,7 +132,7 @@ public class DistributedDataStore implements DOMStore, SchemaContextListener, LOG.debug("Registering listener: {} for path: {} scope: {}", listener, path, scope); - String shardName = ShardStrategyFactory.getStrategy(path).findShard(path); + String shardName = actorContext.getShardStrategyFactory().getStrategy(path).findShard(path); final DataChangeListenerRegistrationProxy listenerRegistrationProxy = new DataChangeListenerRegistrationProxy(shardName, actorContext, listener); @@ -140,7 +146,7 @@ public class DistributedDataStore implements DOMStore, SchemaContextListener, Preconditions.checkNotNull(treeId, "treeId should not be null"); Preconditions.checkNotNull(listener, "listener should not be null"); - final String shardName = ShardStrategyFactory.getStrategy(treeId).findShard(treeId); + final String shardName = actorContext.getShardStrategyFactory().getStrategy(treeId).findShard(treeId); LOG.debug("Registering tree listener: {} for tree: {} shard: {}", listener, treeId, shardName); final DataTreeChangeListenerProxy listenerRegistrationProxy = @@ -178,17 +184,21 @@ public class DistributedDataStore implements DOMStore, SchemaContextListener, } @Override - public void onDatastoreContextUpdated(DatastoreContext context) { + public void onDatastoreContextUpdated(DatastoreContextFactory contextFactory) { LOG.info("DatastoreContext updated for data store {}", actorContext.getDataStoreType()); - actorContext.setDatastoreContext(context); - datastoreConfigMXBean.setContext(context); + actorContext.setDatastoreContext(contextFactory); + datastoreConfigMXBean.setContext(contextFactory.getBaseDatastoreContext()); } @Override public void close() { - datastoreConfigMXBean.unregisterMBean(); - datastoreInfoMXBean.unregisterMBean(); + if (datastoreConfigMXBean != null) { + datastoreConfigMXBean.unregisterMBean(); + } + if (datastoreInfoMXBean != null) { + datastoreInfoMXBean.unregisterMBean(); + } if (closeable != null) { try { @@ -200,7 +210,6 @@ public class DistributedDataStore implements DOMStore, SchemaContextListener, txContextFactory.close(); actorContext.shutdown(); - DistributedDataStoreFactory.destroyInstance(this); } public ActorContext getActorContext() { @@ -221,17 +230,14 @@ public class DistributedDataStore implements DOMStore, SchemaContextListener, } } - private ActorRef createShardManager(ActorSystem actorSystem, ClusterWrapper cluster, Configuration configuration, - DatastoreContext datastoreContext, String shardDispatcher, String shardManagerId, - PrimaryShardInfoFutureCache primaryShardInfoCache){ + private ActorRef createShardManager(ActorSystem actorSystem, ShardManager.Builder builder, String shardDispatcher, + String shardManagerId){ Exception lastException = null; for(int i=0;i<100;i++) { try { - return actorSystem.actorOf( - ShardManager.props(cluster, configuration, datastoreContext, waitTillReadyCountDownLatch, - primaryShardInfoCache).withDispatcher(shardDispatcher).withMailbox( - ActorContext.MAILBOX), shardManagerId); + return actorSystem.actorOf(builder.props().withDispatcher(shardDispatcher).withMailbox( + ActorContext.MAILBOX), shardManagerId); } catch (Exception e){ lastException = e; Uninterruptibles.sleepUninterruptibly(100, TimeUnit.MILLISECONDS);