X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-distributed-datastore%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Fdatastore%2FDistributedDataStore.java;h=2ef8e5f449f8df564ae42943c6597224b832bcb4;hb=34bc6ec632529a0dfe419aa7404bb42a456fbc96;hp=29fc259bb75935d25f13dcb8f7a0865f74f145cd;hpb=863603710603742b27d8aa72b158c170dc3c0cbf;p=controller.git diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/DistributedDataStore.java b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/DistributedDataStore.java index 29fc259bb7..c780881a2f 100644 --- a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/DistributedDataStore.java +++ b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/DistributedDataStore.java @@ -9,14 +9,15 @@ package org.opendaylight.controller.cluster.datastore; import akka.actor.ActorRef; -import akka.actor.ActorSelection; import akka.actor.ActorSystem; +import akka.dispatch.OnComplete; import akka.util.Timeout; -import org.opendaylight.controller.cluster.datastore.messages.FindPrimary; -import org.opendaylight.controller.cluster.datastore.messages.PrimaryFound; +import com.google.common.base.Preconditions; +import org.opendaylight.controller.cluster.datastore.identifiers.ShardManagerIdentifier; import org.opendaylight.controller.cluster.datastore.messages.RegisterChangeListener; import org.opendaylight.controller.cluster.datastore.messages.RegisterChangeListenerReply; -import org.opendaylight.controller.cluster.datastore.messages.UpdateSchemaContext; +import org.opendaylight.controller.cluster.datastore.shardstrategy.ShardStrategyFactory; +import org.opendaylight.controller.cluster.datastore.utils.ActorContext; import org.opendaylight.controller.md.sal.common.api.data.AsyncDataBroker; import org.opendaylight.controller.md.sal.common.api.data.AsyncDataChangeListener; import org.opendaylight.controller.sal.core.spi.data.DOMStore; @@ -25,116 +26,123 @@ import org.opendaylight.controller.sal.core.spi.data.DOMStoreReadWriteTransactio import org.opendaylight.controller.sal.core.spi.data.DOMStoreTransactionChain; import org.opendaylight.controller.sal.core.spi.data.DOMStoreWriteTransaction; import org.opendaylight.yangtools.concepts.ListenerRegistration; -import org.opendaylight.yangtools.yang.data.api.InstanceIdentifier; +import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier; import org.opendaylight.yangtools.yang.data.api.schema.NormalizedNode; import org.opendaylight.yangtools.yang.model.api.SchemaContext; import org.opendaylight.yangtools.yang.model.api.SchemaContextListener; import org.slf4j.Logger; import org.slf4j.LoggerFactory; -import scala.concurrent.Await; import scala.concurrent.Future; -import scala.concurrent.duration.Duration; -import scala.concurrent.duration.FiniteDuration; - -import java.util.concurrent.TimeUnit; - -import static akka.pattern.Patterns.ask; /** * */ -public class DistributedDataStore implements DOMStore, SchemaContextListener { - - private static final Logger - LOG = LoggerFactory.getLogger(DistributedDataStore.class); +public class DistributedDataStore implements DOMStore, SchemaContextListener, AutoCloseable { - final FiniteDuration ASK_DURATION = Duration.create(5, TimeUnit.SECONDS); - final Duration AWAIT_DURATION = Duration.create(5, TimeUnit.SECONDS); + private static final Logger LOG = LoggerFactory.getLogger(DistributedDataStore.class); + public static final int REGISTER_DATA_CHANGE_LISTENER_TIMEOUT_FACTOR = 24; // 24 times the usual operation timeout - private final ActorRef shardManager; - private final ActorSystem actorSystem; - private final String type; + private final ActorContext actorContext; + public DistributedDataStore(ActorSystem actorSystem, String type, ClusterWrapper cluster, + Configuration configuration, DatastoreContext datastoreContext) { + Preconditions.checkNotNull(actorSystem, "actorSystem should not be null"); + Preconditions.checkNotNull(type, "type should not be null"); + Preconditions.checkNotNull(cluster, "cluster should not be null"); + Preconditions.checkNotNull(configuration, "configuration should not be null"); + Preconditions.checkNotNull(datastoreContext, "datastoreContext should not be null"); - public DistributedDataStore(ActorSystem actorSystem, String type) { - this.actorSystem = actorSystem; - this.type = type; - shardManager = actorSystem.actorOf(ShardManager.props(type)); - } + String shardManagerId = ShardManagerIdentifier.builder().type(type).build().toString(); - @Override - public >> ListenerRegistration registerChangeListener( - InstanceIdentifier path, L listener, - AsyncDataBroker.DataChangeScope scope) { + LOG.info("Creating ShardManager : {}", shardManagerId); - ActorSelection primary = findPrimary(); + actorContext = new ActorContext(actorSystem, actorSystem.actorOf( + ShardManager.props(type, cluster, configuration, datastoreContext) + .withMailbox(ActorContext.MAILBOX), shardManagerId ), cluster, configuration); - ActorRef dataChangeListenerActor = actorSystem.actorOf(DataChangeListener.props()); - - Object result = - getResult(primary, new RegisterChangeListener(path, dataChangeListenerActor.path(), - AsyncDataBroker.DataChangeScope.BASE), ASK_DURATION); - - RegisterChangeListenerReply reply = (RegisterChangeListenerReply) result; - return new ListenerRegistrationProxy(reply.getListenerRegistrationPath()); + actorContext.setOperationTimeout(datastoreContext.getOperationTimeoutInSeconds()); } - private ActorSelection findPrimary() { - Object result = getResult(shardManager, new FindPrimary(Shard.DEFAULT_NAME), ASK_DURATION); - - if(result instanceof PrimaryFound){ - PrimaryFound found = (PrimaryFound) result; - LOG.error("Primary found {}", found.getPrimaryPath()); - - return actorSystem.actorSelection(found.getPrimaryPath()); - } - throw new RuntimeException("primary was not found"); + public DistributedDataStore(ActorContext actorContext) { + this.actorContext = Preconditions.checkNotNull(actorContext, "actorContext should not be null"); } - private Object getResult(ActorRef actor, Object message, FiniteDuration duration){ - Future future = - ask(actor, message, new Timeout(duration)); + @SuppressWarnings("unchecked") + @Override + public >> + ListenerRegistration registerChangeListener( + final YangInstanceIdentifier path, L listener, + AsyncDataBroker.DataChangeScope scope) { - try { - return Await.result(future, AWAIT_DURATION); - } catch (Exception e) { - throw new RuntimeException(e); + Preconditions.checkNotNull(path, "path should not be null"); + Preconditions.checkNotNull(listener, "listener should not be null"); + if(LOG.isDebugEnabled()) { + LOG.debug("Registering listener: {} for path: {} scope: {}", listener, path, scope); } - } - - private Object getResult(ActorSelection actor, Object message, FiniteDuration duration){ - Future future = - ask(actor, message, new Timeout(duration)); - - try { - return Await.result(future, AWAIT_DURATION); - } catch (Exception e) { - throw new RuntimeException(e); + ActorRef dataChangeListenerActor = actorContext.getActorSystem().actorOf( + DataChangeListener.props(listener )); + + String shardName = ShardStrategyFactory.getStrategy(path).findShard(path); + + Future future = actorContext.executeLocalShardOperationAsync(shardName, + new RegisterChangeListener(path, dataChangeListenerActor.path(), scope), + new Timeout(actorContext.getOperationDuration().$times( + REGISTER_DATA_CHANGE_LISTENER_TIMEOUT_FACTOR))); + + if (future != null) { + final DataChangeListenerRegistrationProxy listenerRegistrationProxy = + new DataChangeListenerRegistrationProxy(listener, dataChangeListenerActor); + + future.onComplete(new OnComplete(){ + + @Override public void onComplete(Throwable failure, Object result) + throws Throwable { + if(failure != null){ + LOG.error("Failed to register listener at path " + path.toString(), failure); + return; + } + RegisterChangeListenerReply reply = (RegisterChangeListenerReply) result; + listenerRegistrationProxy.setListenerRegistrationActor(actorContext + .actorSelection(reply.getListenerRegistrationPath())); + } + }, actorContext.getActorSystem().dispatcher()); + return listenerRegistrationProxy; + } + if(LOG.isDebugEnabled()) { + LOG.debug( + "No local shard for shardName {} was found so returning a noop registration", + shardName); } + return new NoOpDataChangeListenerRegistration(listener); } - @Override public DOMStoreTransactionChain createTransactionChain() { - return new TransactionChainProxy(); + return new TransactionChainProxy(actorContext); } @Override public DOMStoreReadTransaction newReadOnlyTransaction() { - return new TransactionProxy(); + return new TransactionProxy(actorContext, TransactionProxy.TransactionType.READ_ONLY); } @Override public DOMStoreWriteTransaction newWriteOnlyTransaction() { - return new TransactionProxy(); + return new TransactionProxy(actorContext, TransactionProxy.TransactionType.WRITE_ONLY); } @Override public DOMStoreReadWriteTransaction newReadWriteTransaction() { - return new TransactionProxy(); + return new TransactionProxy(actorContext, TransactionProxy.TransactionType.READ_WRITE); } - @Override public void onGlobalContextUpdated(SchemaContext schemaContext) { - shardManager.tell(new UpdateSchemaContext(schemaContext), null); + @Override + public void onGlobalContextUpdated(SchemaContext schemaContext) { + actorContext.setSchemaContext(schemaContext); + } + + @Override + public void close() throws Exception { + actorContext.shutdown(); } }