X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-distributed-datastore%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Fdatastore%2FDistributedDataStore.java;h=db01d515354a9d166e2b906d8cd7168e7c39deb0;hb=35f74293edf98402e2b622e060185f7874d10857;hp=c43307643b49539b6af395f8db7a5822725ee098;hpb=3471ea2c8462ea99043263563903ce7091ad8432;p=controller.git diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/DistributedDataStore.java b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/DistributedDataStore.java index c43307643b..db01d51535 100644 --- a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/DistributedDataStore.java +++ b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/DistributedDataStore.java @@ -10,11 +10,12 @@ package org.opendaylight.controller.cluster.datastore; import akka.actor.ActorRef; import akka.actor.ActorSystem; -import com.google.common.util.concurrent.ListeningExecutorService; -import com.google.common.util.concurrent.MoreExecutors; + +import com.google.common.base.Preconditions; + +import org.opendaylight.controller.cluster.datastore.identifiers.ShardManagerIdentifier; import org.opendaylight.controller.cluster.datastore.messages.RegisterChangeListener; import org.opendaylight.controller.cluster.datastore.messages.RegisterChangeListenerReply; -import org.opendaylight.controller.cluster.datastore.messages.UpdateSchemaContext; import org.opendaylight.controller.cluster.datastore.shardstrategy.ShardStrategyFactory; import org.opendaylight.controller.cluster.datastore.utils.ActorContext; import org.opendaylight.controller.md.sal.common.api.data.AsyncDataBroker; @@ -25,8 +26,6 @@ import org.opendaylight.controller.sal.core.spi.data.DOMStoreReadWriteTransactio import org.opendaylight.controller.sal.core.spi.data.DOMStoreTransactionChain; import org.opendaylight.controller.sal.core.spi.data.DOMStoreWriteTransaction; import org.opendaylight.yangtools.concepts.ListenerRegistration; -import org.opendaylight.yangtools.util.PropertyUtils; -import org.opendaylight.yangtools.util.concurrent.SpecialExecutors; import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier; import org.opendaylight.yangtools.yang.data.api.schema.NormalizedNode; import org.opendaylight.yangtools.yang.model.api.SchemaContext; @@ -39,65 +38,52 @@ import org.slf4j.LoggerFactory; */ public class DistributedDataStore implements DOMStore, SchemaContextListener, AutoCloseable { - private static final Logger - LOG = LoggerFactory.getLogger(DistributedDataStore.class); + private static final Logger LOG = LoggerFactory.getLogger(DistributedDataStore.class); - private static final String EXECUTOR_MAX_POOL_SIZE_PROP = - "mdsal.dist-datastore-executor-pool.size"; - private static final int DEFAULT_EXECUTOR_MAX_POOL_SIZE = 10; + private final ActorContext actorContext; - private static final String EXECUTOR_MAX_QUEUE_SIZE_PROP = - "mdsal.dist-datastore-executor-queue.size"; - private static final int DEFAULT_EXECUTOR_MAX_QUEUE_SIZE = 5000; + public DistributedDataStore(ActorSystem actorSystem, String type, ClusterWrapper cluster, + Configuration configuration, DatastoreContext datastoreContext) { + Preconditions.checkNotNull(actorSystem, "actorSystem should not be null"); + Preconditions.checkNotNull(type, "type should not be null"); + Preconditions.checkNotNull(cluster, "cluster should not be null"); + Preconditions.checkNotNull(configuration, "configuration should not be null"); + Preconditions.checkNotNull(datastoreContext, "datastoreContext should not be null"); - private final String type; - private final ActorContext actorContext; + String shardManagerId = ShardManagerIdentifier.builder().type(type).build().toString(); - private SchemaContext schemaContext; - - /** - * Executor used to run FutureTask's - * - * This is typically used when we need to make a request to an actor and - * wait for it's response and the consumer needs to be provided a Future. - */ - private final ListeningExecutorService executor = - MoreExecutors.listeningDecorator( - SpecialExecutors.newBlockingBoundedFastThreadPool( - PropertyUtils.getIntSystemProperty( - EXECUTOR_MAX_POOL_SIZE_PROP, - DEFAULT_EXECUTOR_MAX_POOL_SIZE), - PropertyUtils.getIntSystemProperty( - EXECUTOR_MAX_QUEUE_SIZE_PROP, - DEFAULT_EXECUTOR_MAX_QUEUE_SIZE), "DistDataStore")); - - public DistributedDataStore(ActorSystem actorSystem, String type, ClusterWrapper cluster, Configuration configuration) { - this(new ActorContext(actorSystem, actorSystem - .actorOf(ShardManager.props(type, cluster, configuration), - "shardmanager-" + type), cluster, configuration), type); - } + LOG.info("Creating ShardManager : {}", shardManagerId); - public DistributedDataStore(ActorContext actorContext, String type) { - this.type = type; - this.actorContext = actorContext; + actorContext = new ActorContext(actorSystem, actorSystem.actorOf( + ShardManager.props(type, cluster, configuration, datastoreContext) + .withMailbox(ActorContext.MAILBOX), shardManagerId ), cluster, configuration); + + actorContext.setOperationTimeout(datastoreContext.getOperationTimeoutInSeconds()); } + public DistributedDataStore(ActorContext actorContext) { + this.actorContext = Preconditions.checkNotNull(actorContext, "actorContext should not be null"); + } + @SuppressWarnings("unchecked") @Override - public >> ListenerRegistration registerChangeListener( + public >> + ListenerRegistration registerChangeListener( YangInstanceIdentifier path, L listener, AsyncDataBroker.DataChangeScope scope) { + Preconditions.checkNotNull(path, "path should not be null"); + Preconditions.checkNotNull(listener, "listener should not be null"); + + LOG.debug("Registering listener: {} for path: {} scope: {}", listener, path, scope); + ActorRef dataChangeListenerActor = actorContext.getActorSystem().actorOf( - DataChangeListener.props(schemaContext,listener,path )); + DataChangeListener.props(listener )); String shardName = ShardStrategyFactory.getStrategy(path).findShard(path); Object result = actorContext.executeLocalShardOperation(shardName, - new RegisterChangeListener(path, dataChangeListenerActor.path(), - scope), - ActorContext.ASK_DURATION - ); + new RegisterChangeListener(path, dataChangeListenerActor.path(), scope)); if (result != null) { RegisterChangeListenerReply reply = (RegisterChangeListenerReply) result; @@ -109,44 +95,37 @@ public class DistributedDataStore implements DOMStore, SchemaContextListener, Au LOG.debug( "No local shard for shardName {} was found so returning a noop registration", shardName); + return new NoOpDataChangeListenerRegistration(listener); } - - - - @Override public DOMStoreTransactionChain createTransactionChain() { - return new TransactionChainProxy(actorContext, executor, schemaContext); + return new TransactionChainProxy(actorContext); } @Override public DOMStoreReadTransaction newReadOnlyTransaction() { - return new TransactionProxy(actorContext, TransactionProxy.TransactionType.READ_ONLY, - executor, schemaContext); + return new TransactionProxy(actorContext, TransactionProxy.TransactionType.READ_ONLY); } @Override public DOMStoreWriteTransaction newWriteOnlyTransaction() { - return new TransactionProxy(actorContext, TransactionProxy.TransactionType.WRITE_ONLY, - executor, schemaContext); + return new TransactionProxy(actorContext, TransactionProxy.TransactionType.WRITE_ONLY); } @Override public DOMStoreReadWriteTransaction newReadWriteTransaction() { - return new TransactionProxy(actorContext, TransactionProxy.TransactionType.READ_WRITE, - executor, schemaContext); + return new TransactionProxy(actorContext, TransactionProxy.TransactionType.READ_WRITE); } - @Override public void onGlobalContextUpdated(SchemaContext schemaContext) { - this.schemaContext = schemaContext; - actorContext.getShardManager().tell( - new UpdateSchemaContext(schemaContext), null); + @Override + public void onGlobalContextUpdated(SchemaContext schemaContext) { + actorContext.setSchemaContext(schemaContext); } - @Override public void close() throws Exception { + @Override + public void close() throws Exception { actorContext.shutdown(); - } }