X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-distributed-datastore%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Fdatastore%2FLocalTransactionContext.java;h=0dbd2a284def03ae2a722dc9b7fbef62e69dbe23;hb=bfb38b42aa055a2478a5972f15ca4246dee796e9;hp=e62d15b7ffc2bb05dca59e0fdae16739e0e778e3;hpb=4379f102fa0c85abf58f60d81fec9c698582fb1a;p=controller.git diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/LocalTransactionContext.java b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/LocalTransactionContext.java index e62d15b7ff..0dbd2a284d 100644 --- a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/LocalTransactionContext.java +++ b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/LocalTransactionContext.java @@ -8,17 +8,16 @@ package org.opendaylight.controller.cluster.datastore; import akka.actor.ActorSelection; -import com.google.common.base.Optional; import com.google.common.base.Preconditions; import com.google.common.util.concurrent.FutureCallback; import com.google.common.util.concurrent.Futures; import com.google.common.util.concurrent.SettableFuture; -import org.opendaylight.controller.cluster.datastore.identifiers.TransactionIdentifier; +import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier; +import org.opendaylight.controller.cluster.datastore.messages.AbstractRead; +import org.opendaylight.controller.cluster.datastore.modification.AbstractModification; import org.opendaylight.controller.sal.core.spi.data.DOMStoreReadTransaction; import org.opendaylight.controller.sal.core.spi.data.DOMStoreTransaction; import org.opendaylight.controller.sal.core.spi.data.DOMStoreWriteTransaction; -import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier; -import org.opendaylight.yangtools.yang.data.api.schema.NormalizedNode; import scala.concurrent.Future; /** @@ -29,10 +28,14 @@ import scala.concurrent.Future; */ abstract class LocalTransactionContext extends AbstractTransactionContext { private final DOMStoreTransaction txDelegate; + private final LocalTransactionReadySupport readySupport; + private Exception operationError; - LocalTransactionContext(DOMStoreTransaction txDelegate, TransactionIdentifier identifier) { + LocalTransactionContext(DOMStoreTransaction txDelegate, TransactionIdentifier identifier, + LocalTransactionReadySupport readySupport) { super(identifier); this.txDelegate = Preconditions.checkNotNull(txDelegate); + this.readySupport = readySupport; } protected abstract DOMStoreWriteTransaction getWriteDelegate(); @@ -40,43 +43,22 @@ abstract class LocalTransactionContext extends AbstractTransactionContext { protected abstract DOMStoreReadTransaction getReadDelegate(); @Override - public void writeData(YangInstanceIdentifier path, NormalizedNode data) { + public void executeModification(AbstractModification modification) { incrementModificationCount(); - getWriteDelegate().write(path, data); - } - - @Override - public void mergeData(YangInstanceIdentifier path, NormalizedNode data) { - incrementModificationCount(); - getWriteDelegate().merge(path, data); - } - - @Override - public void deleteData(YangInstanceIdentifier path) { - incrementModificationCount(); - getWriteDelegate().delete(path); - } - - @Override - public void readData(YangInstanceIdentifier path, final SettableFuture>> proxyFuture) { - Futures.addCallback(getReadDelegate().read(path), new FutureCallback>>() { - @Override - public void onSuccess(final Optional> result) { - proxyFuture.set(result); + if(operationError == null) { + try { + modification.apply(getWriteDelegate()); + } catch (Exception e) { + operationError = e; } - - @Override - public void onFailure(final Throwable t) { - proxyFuture.setException(t); - } - }); + } } @Override - public void dataExists(YangInstanceIdentifier path, final SettableFuture proxyFuture) { - Futures.addCallback(getReadDelegate().exists(path), new FutureCallback() { + public void executeRead(AbstractRead readCmd, final SettableFuture proxyFuture) { + Futures.addCallback(readCmd.apply(getReadDelegate()), new FutureCallback() { @Override - public void onSuccess(final Boolean result) { + public void onSuccess(final T result) { proxyFuture.set(result); } @@ -89,7 +71,7 @@ abstract class LocalTransactionContext extends AbstractTransactionContext { private LocalThreePhaseCommitCohort ready() { logModificationCount(); - return (LocalThreePhaseCommitCohort) getWriteDelegate().ready(); + return readySupport.onTransactionReady(getWriteDelegate(), operationError); } @Override @@ -104,11 +86,6 @@ abstract class LocalTransactionContext extends AbstractTransactionContext { return cohort.initiateDirectCommit(); } - @Override - public boolean supportsDirectCommit() { - return true; - } - @Override public void closeTransaction() { txDelegate.close();