X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-distributed-datastore%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Fdatastore%2FShard.java;h=0bb886a12defb5a70df4f39b34866f4a2cc3890f;hb=f6f6dcaf827bcad41a3f9045f2dc74a36371e1b4;hp=7b34f5df6097ce4ea00c49233f3f4a4a8e5c7728;hpb=0b9b1dcba996fd76e0e1bde731692570747f5efd;p=controller.git diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/Shard.java b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/Shard.java index 7b34f5df60..0bb886a12d 100644 --- a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/Shard.java +++ b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/Shard.java @@ -12,14 +12,13 @@ import akka.actor.ActorRef; import akka.actor.ActorSelection; import akka.actor.Cancellable; import akka.actor.Props; -import akka.japi.Creator; import akka.persistence.RecoveryFailure; import akka.serialization.Serialization; import com.google.common.annotations.VisibleForTesting; import com.google.common.base.Optional; import com.google.common.base.Preconditions; import java.io.IOException; -import java.util.HashMap; +import java.util.Collections; import java.util.Map; import java.util.concurrent.TimeUnit; import javax.annotation.Nonnull; @@ -40,7 +39,10 @@ import org.opendaylight.controller.cluster.datastore.messages.CommitTransaction; import org.opendaylight.controller.cluster.datastore.messages.CommitTransactionReply; import org.opendaylight.controller.cluster.datastore.messages.CreateTransaction; import org.opendaylight.controller.cluster.datastore.messages.CreateTransactionReply; +import org.opendaylight.controller.cluster.datastore.messages.DatastoreSnapshot; +import org.opendaylight.controller.cluster.datastore.messages.DatastoreSnapshot.ShardSnapshot; import org.opendaylight.controller.cluster.datastore.messages.ForwardedReadyTransaction; +import org.opendaylight.controller.cluster.datastore.messages.GetShardDataTree; import org.opendaylight.controller.cluster.datastore.messages.PeerAddressResolved; import org.opendaylight.controller.cluster.datastore.messages.ReadyLocalTransaction; import org.opendaylight.controller.cluster.datastore.messages.RegisterChangeListener; @@ -61,6 +63,7 @@ import org.opendaylight.controller.cluster.raft.RaftActorSnapshotCohort; import org.opendaylight.controller.cluster.raft.RaftState; import org.opendaylight.controller.cluster.raft.base.messages.FollowerInitialSyncUpStatus; import org.opendaylight.controller.cluster.raft.messages.AppendEntriesReply; +import org.opendaylight.controller.cluster.raft.messages.ServerRemoved; import org.opendaylight.controller.cluster.raft.protobuff.client.messages.CompositeModificationByteStringPayload; import org.opendaylight.controller.cluster.raft.protobuff.client.messages.CompositeModificationPayload; import org.opendaylight.yangtools.yang.data.api.schema.tree.DataTree; @@ -114,19 +117,25 @@ public class Shard extends RaftActor { private final DataTreeChangeListenerSupport treeChangeSupport = new DataTreeChangeListenerSupport(this); private final DataChangeListenerSupport changeSupport = new DataChangeListenerSupport(this); - protected Shard(final ShardIdentifier name, final Map peerAddresses, - final DatastoreContext datastoreContext, final SchemaContext schemaContext) { - super(name.toString(), new HashMap<>(peerAddresses), Optional.of(datastoreContext.getShardRaftConfig()), - DataStoreVersions.CURRENT_VERSION); - this.name = name.toString(); - this.datastoreContext = datastoreContext; + private ShardSnapshot restoreFromSnapshot; + + + + protected Shard(AbstractBuilder builder) { + super(builder.getId().toString(), builder.getPeerAddresses(), + Optional.of(builder.getDatastoreContext().getShardRaftConfig()), DataStoreVersions.CURRENT_VERSION); + + this.name = builder.getId().toString(); + this.datastoreContext = builder.getDatastoreContext(); + this.restoreFromSnapshot = builder.getRestoreFromSnapshot(); setPersistence(datastoreContext.isPersistent()); LOG.info("Shard created : {}, persistent : {}", name, datastoreContext.isPersistent()); - store = new ShardDataTree(schemaContext); + // FIXME: BUG-1014: pass down the proper TreeType + store = new ShardDataTree(builder.getSchemaContext()); shardMBean = ShardMBeanFactory.getShardStatsMBean(name.toString(), datastoreContext.getDataStoreMXBeanType()); @@ -138,7 +147,7 @@ public class Shard extends RaftActor { commitCoordinator = new ShardCommitCoordinator(store, datastoreContext.getShardCommitQueueExpiryTimeoutInMillis(), - datastoreContext.getShardTransactionCommitQueueCapacity(), self(), LOG, this.name); + datastoreContext.getShardTransactionCommitQueueCapacity(), LOG, this.name); setTransactionCommitTimeout(); @@ -155,6 +164,7 @@ public class Shard extends RaftActor { snapshotCohort = new ShardSnapshotCohort(transactionActorFactory, store, LOG, this.name); + } private void setTransactionCommitTimeout() { @@ -162,11 +172,6 @@ public class Shard extends RaftActor { datastoreContext.getShardTransactionCommitTimeoutInSeconds(), TimeUnit.SECONDS) / 2; } - public static Props props(final ShardIdentifier name, final Map peerAddresses, - final DatastoreContext datastoreContext, final SchemaContext schemaContext) { - return Props.create(new ShardCreator(name, peerAddresses, datastoreContext, schemaContext)); - } - private Optional createRoleChangeNotifier(String shardId) { ActorRef shardRoleChangeNotifier = this.getContext().actorOf( RoleChangeNotifier.getProps(shardId), shardId + "-notifier"); @@ -257,6 +262,10 @@ public class Shard extends RaftActor { context().parent().tell(message, self()); } else if(GET_SHARD_MBEAN_MESSAGE.equals(message)){ sender().tell(getShardMBean(), self()); + } else if(message instanceof GetShardDataTree) { + sender().tell(store.getDataTree(), self()); + } else if(message instanceof ServerRemoved){ + context().parent().forward(message, context()); } else { super.onReceiveCommand(message); } @@ -319,7 +328,7 @@ public class Shard extends RaftActor { return ModificationType.UNMODIFIED.equals(candidate.getRootNode().getModificationType()); } - void continueCommit(final CohortEntry cohortEntry) throws Exception { + void continueCommit(final CohortEntry cohortEntry) { final DataTreeCandidate candidate = cohortEntry.getCandidate(); // If we do not have any followers and we are not using persistence @@ -329,7 +338,7 @@ public class Shard extends RaftActor { applyModificationToState(cohortEntry.getReplySender(), cohortEntry.getTransactionID(), candidate); } else { Shard.this.persistData(cohortEntry.getReplySender(), cohortEntry.getTransactionID(), - DataTreeCandidatePayload.create(candidate)); + DataTreeCandidatePayload.create(candidate)); } } @@ -408,6 +417,16 @@ public class Shard extends RaftActor { getSender().tell(new akka.actor.Status.Failure(new NoShardLeaderException(errMessage, persistenceId())), getSelf()); } + protected void handleBatchedModificationsLocal(BatchedModifications batched, ActorRef sender) { + try { + commitCoordinator.handleBatchedModifications(batched, sender, this); + } catch (Exception e) { + LOG.error("{}: Error handling BatchedModifications for Tx {}", persistenceId(), + batched.getTransactionID(), e); + sender.tell(new akka.actor.Status.Failure(e), getSelf()); + } + } + private void handleBatchedModifications(BatchedModifications batched) { // This message is sent to prepare the modifications transaction directly on the Shard as an // optimization to avoid the extra overhead of a separate ShardTransaction actor. On the last @@ -424,13 +443,7 @@ public class Shard extends RaftActor { if(isLeader()) { failIfIsolatedLeader(getSender()); - try { - commitCoordinator.handleBatchedModifications(batched, getSender(), this); - } catch (Exception e) { - LOG.error("{}: Error handling BatchedModifications for Tx {}", persistenceId(), - batched.getTransactionID(), e); - getSender().tell(new akka.actor.Status.Failure(e), getSelf()); - } + handleBatchedModificationsLocal(batched, getSender()); } else { ActorSelection leader = getLeader(); if(leader != null) { @@ -446,7 +459,7 @@ public class Shard extends RaftActor { } private boolean failIfIsolatedLeader(ActorRef sender) { - if(getRaftState() == RaftState.IsolatedLeader) { + if(isIsolatedLeader()) { sender.tell(new akka.actor.Status.Failure(new NoShardLeaderException(String.format( "Shard %s was the leader but has lost contact with all of its followers. Either all" + " other follower nodes are down or this node is isolated by a network partition.", @@ -457,6 +470,10 @@ public class Shard extends RaftActor { return false; } + protected boolean isIsolatedLeader() { + return getRaftState() == RaftState.IsolatedLeader; + } + private void handleReadyLocalTransaction(final ReadyLocalTransaction message) { if (isLeader()) { failIfIsolatedLeader(getSender()); @@ -581,11 +598,14 @@ public class Shard extends RaftActor { @Override @Nonnull protected RaftActorRecoveryCohort getRaftActorRecoveryCohort() { - return new ShardRecoveryCoordinator(store, store.getSchemaContext(), persistenceId(), LOG); + return new ShardRecoveryCoordinator(store, store.getSchemaContext(), + restoreFromSnapshot != null ? restoreFromSnapshot.getSnapshot() : null, persistenceId(), LOG); } @Override protected void onRecoveryComplete() { + restoreFromSnapshot = null; + //notify shard manager getContext().parent().tell(new ActorInitialized(), getSelf()); @@ -684,44 +704,113 @@ public class Shard extends RaftActor { return commitCoordinator; } - protected abstract static class AbstractShardCreator implements Creator { - private static final long serialVersionUID = 1L; + public DatastoreContext getDatastoreContext() { + return datastoreContext; + } + + @VisibleForTesting + public ShardDataTree getDataStore() { + return store; + } - protected final ShardIdentifier name; - protected final Map peerAddresses; - protected final DatastoreContext datastoreContext; - protected final SchemaContext schemaContext; + @VisibleForTesting + ShardStats getShardMBean() { + return shardMBean; + } - protected AbstractShardCreator(final ShardIdentifier name, final Map peerAddresses, - final DatastoreContext datastoreContext, final SchemaContext schemaContext) { - this.name = Preconditions.checkNotNull(name, "name should not be null"); - this.peerAddresses = Preconditions.checkNotNull(peerAddresses, "peerAddresses should not be null"); - this.datastoreContext = Preconditions.checkNotNull(datastoreContext, "dataStoreContext should not be null"); - this.schemaContext = Preconditions.checkNotNull(schemaContext, "schemaContext should not be null"); - } + public static Builder builder() { + return new Builder(); } - private static class ShardCreator extends AbstractShardCreator { - private static final long serialVersionUID = 1L; + public static abstract class AbstractBuilder, S extends Shard> { + private final Class shardClass; + private ShardIdentifier id; + private Map peerAddresses = Collections.emptyMap(); + private DatastoreContext datastoreContext; + private SchemaContext schemaContext; + private DatastoreSnapshot.ShardSnapshot restoreFromSnapshot; + private volatile boolean sealed; - ShardCreator(final ShardIdentifier name, final Map peerAddresses, - final DatastoreContext datastoreContext, final SchemaContext schemaContext) { - super(name, peerAddresses, datastoreContext, schemaContext); + protected AbstractBuilder(Class shardClass) { + this.shardClass = shardClass; } - @Override - public Shard create() throws Exception { - return new Shard(name, peerAddresses, datastoreContext, schemaContext); + protected void checkSealed() { + Preconditions.checkState(!sealed, "Builder isalready sealed - further modifications are not allowed"); } - } - @VisibleForTesting - public ShardDataTree getDataStore() { - return store; + @SuppressWarnings("unchecked") + private T self() { + return (T) this; + } + + public T id(ShardIdentifier id) { + checkSealed(); + this.id = id; + return self(); + } + + public T peerAddresses(Map peerAddresses) { + checkSealed(); + this.peerAddresses = peerAddresses; + return self(); + } + + public T datastoreContext(DatastoreContext datastoreContext) { + checkSealed(); + this.datastoreContext = datastoreContext; + return self(); + } + + public T schemaContext(SchemaContext schemaContext) { + checkSealed(); + this.schemaContext = schemaContext; + return self(); + } + + public T restoreFromSnapshot(DatastoreSnapshot.ShardSnapshot restoreFromSnapshot) { + checkSealed(); + this.restoreFromSnapshot = restoreFromSnapshot; + return self(); + } + + public ShardIdentifier getId() { + return id; + } + + public Map getPeerAddresses() { + return peerAddresses; + } + + public DatastoreContext getDatastoreContext() { + return datastoreContext; + } + + public SchemaContext getSchemaContext() { + return schemaContext; + } + + public DatastoreSnapshot.ShardSnapshot getRestoreFromSnapshot() { + return restoreFromSnapshot; + } + + protected void verify() { + Preconditions.checkNotNull(id, "id should not be null"); + Preconditions.checkNotNull(peerAddresses, "peerAddresses should not be null"); + Preconditions.checkNotNull(datastoreContext, "dataStoreContext should not be null"); + Preconditions.checkNotNull(schemaContext, "schemaContext should not be null"); + } + + public Props props() { + sealed = true; + verify(); + return Props.create(shardClass, this); + } } - @VisibleForTesting - ShardStats getShardMBean() { - return shardMBean; + public static class Builder extends AbstractBuilder { + private Builder() { + super(Shard.class); + } } }