X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-distributed-datastore%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Fdatastore%2FShardDataTree.java;h=edf05f2a25bb9fe5bb108b18dd5fcd10709266e8;hb=17211c982bcee83306af49b1b75c764dcb504b5d;hp=618ea90e265c33b13c3df266b6ab2f38bb43c52b;hpb=1d3c54640b9fff649fe8d0f57e20d56f8f936cc1;p=controller.git diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/ShardDataTree.java b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/ShardDataTree.java index 618ea90e26..edf05f2a25 100644 --- a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/ShardDataTree.java +++ b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/ShardDataTree.java @@ -9,16 +9,18 @@ package org.opendaylight.controller.cluster.datastore; import com.google.common.base.Optional; import com.google.common.base.Preconditions; -import com.google.common.base.Strings; import java.util.AbstractMap.SimpleEntry; import java.util.HashMap; import java.util.Map; import java.util.Map.Entry; import javax.annotation.concurrent.NotThreadSafe; +import org.opendaylight.controller.cluster.access.concepts.LocalHistoryIdentifier; +import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier; import org.opendaylight.controller.md.sal.common.api.data.AsyncDataBroker.DataChangeScope; import org.opendaylight.controller.md.sal.common.api.data.AsyncDataChangeListener; import org.opendaylight.controller.md.sal.dom.api.DOMDataTreeChangeListener; import org.opendaylight.controller.md.sal.dom.store.impl.DataChangeListenerRegistration; +import org.opendaylight.yangtools.concepts.Identifier; import org.opendaylight.yangtools.concepts.ListenerRegistration; import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier; import org.opendaylight.yangtools.yang.data.api.schema.NormalizedNode; @@ -45,9 +47,8 @@ import org.slf4j.LoggerFactory; @NotThreadSafe public class ShardDataTree extends ShardDataTreeTransactionParent { private static final Logger LOG = LoggerFactory.getLogger(ShardDataTree.class); - private static final YangInstanceIdentifier ROOT_PATH = YangInstanceIdentifier.builder().build(); - private final Map transactionChains = new HashMap<>(); + private final Map transactionChains = new HashMap<>(); private final ShardDataTreeChangeListenerPublisher treeChangeListenerPublisher; private final ShardDataChangeListenerPublisher dataChangeListenerPublisher; private final TipProducingDataTree dataTree; @@ -59,9 +60,10 @@ public class ShardDataTree extends ShardDataTreeTransactionParent { final ShardDataChangeListenerPublisher dataChangeListenerPublisher, final String logContext) { dataTree = InMemoryDataTreeFactory.getInstance().create(treeType); updateSchemaContext(schemaContext); - this.treeChangeListenerPublisher = treeChangeListenerPublisher; - this.dataChangeListenerPublisher = dataChangeListenerPublisher; - this.logContext = logContext; + + this.treeChangeListenerPublisher = Preconditions.checkNotNull(treeChangeListenerPublisher); + this.dataChangeListenerPublisher = Preconditions.checkNotNull(dataChangeListenerPublisher); + this.logContext = Preconditions.checkNotNull(logContext); } public ShardDataTree(final SchemaContext schemaContext, final TreeType treeType) { @@ -78,36 +80,35 @@ public class ShardDataTree extends ShardDataTreeTransactionParent { } void updateSchemaContext(final SchemaContext schemaContext) { - Preconditions.checkNotNull(schemaContext); - this.schemaContext = schemaContext; dataTree.setSchemaContext(schemaContext); + this.schemaContext = Preconditions.checkNotNull(schemaContext); } - private ShardDataTreeTransactionChain ensureTransactionChain(final String chainId) { - ShardDataTreeTransactionChain chain = transactionChains.get(chainId); + private ShardDataTreeTransactionChain ensureTransactionChain(final LocalHistoryIdentifier localHistoryIdentifier) { + ShardDataTreeTransactionChain chain = transactionChains.get(localHistoryIdentifier); if (chain == null) { - chain = new ShardDataTreeTransactionChain(chainId, this); - transactionChains.put(chainId, chain); + chain = new ShardDataTreeTransactionChain(localHistoryIdentifier, this); + transactionChains.put(localHistoryIdentifier, chain); } return chain; } - ReadOnlyShardDataTreeTransaction newReadOnlyTransaction(final String txId, final String chainId) { - if (Strings.isNullOrEmpty(chainId)) { + ReadOnlyShardDataTreeTransaction newReadOnlyTransaction(final TransactionIdentifier txId) { + if (txId.getHistoryId().getHistoryId() == 0) { return new ReadOnlyShardDataTreeTransaction(txId, dataTree.takeSnapshot()); } - return ensureTransactionChain(chainId).newReadOnlyTransaction(txId); + return ensureTransactionChain(txId.getHistoryId()).newReadOnlyTransaction(txId); } - ReadWriteShardDataTreeTransaction newReadWriteTransaction(final String txId, final String chainId) { - if (Strings.isNullOrEmpty(chainId)) { + ReadWriteShardDataTreeTransaction newReadWriteTransaction(final TransactionIdentifier txId) { + if (txId.getHistoryId().getHistoryId() == 0) { return new ReadWriteShardDataTreeTransaction(ShardDataTree.this, txId, dataTree.takeSnapshot() .newModification()); } - return ensureTransactionChain(chainId).newReadWriteTransaction(txId); + return ensureTransactionChain(txId.getHistoryId()).newReadWriteTransaction(txId); } public void notifyListeners(final DataTreeCandidate candidate) { @@ -115,10 +116,9 @@ public class ShardDataTree extends ShardDataTreeTransactionParent { dataChangeListenerPublisher.publishChanges(candidate, logContext); } - void notifyOfInitialData(DataChangeListenerRegistration>> listenerReg, Optional currentState) { - - if(currentState.isPresent()) { + void notifyOfInitialData(final DataChangeListenerRegistration>> listenerReg, final Optional currentState) { + if (currentState.isPresent()) { ShardDataChangeListenerPublisher localPublisher = dataChangeListenerPublisher.newInstance(); localPublisher.registerDataChangeListener(listenerReg.getPath(), listenerReg.getInstance(), listenerReg.getScope()); @@ -128,7 +128,7 @@ public class ShardDataTree extends ShardDataTreeTransactionParent { void notifyOfInitialData(final YangInstanceIdentifier path, final DOMDataTreeChangeListener listener, final Optional currentState) { - if(currentState.isPresent()) { + if (currentState.isPresent()) { ShardDataTreeChangeListenerPublisher localPublisher = treeChangeListenerPublisher.newInstance(); localPublisher.registerTreeChangeListener(path, listener); localPublisher.publishChanges(currentState.get(), logContext); @@ -143,7 +143,7 @@ public class ShardDataTree extends ShardDataTreeTransactionParent { transactionChains.clear(); } - void closeTransactionChain(final String transactionChainId) { + void closeTransactionChain(final LocalHistoryIdentifier transactionChainId) { final ShardDataTreeTransactionChain chain = transactionChains.remove(transactionChainId); if (chain != null) { chain.close(); @@ -163,9 +163,9 @@ public class ShardDataTree extends ShardDataTreeTransactionParent { } private Optional readCurrentData() { - final Optional> currentState = dataTree.takeSnapshot().readNode(ROOT_PATH); + final Optional> currentState = dataTree.takeSnapshot().readNode(YangInstanceIdentifier.EMPTY); return currentState.isPresent() ? Optional.of(DataTreeCandidates.fromNormalizedNode( - ROOT_PATH, currentState.get())) : Optional.absent(); + YangInstanceIdentifier.EMPTY, currentState.get())) : Optional.absent(); } public Entry, Optional> registerTreeChangeListener( @@ -176,7 +176,7 @@ public class ShardDataTree extends ShardDataTreeTransactionParent { return new SimpleEntry<>(reg, readCurrentData()); } - void applyForeignCandidate(final String identifier, final DataTreeCandidate foreign) throws DataValidationFailedException { + void applyForeignCandidate(final Identifier identifier, final DataTreeCandidate foreign) throws DataValidationFailedException { LOG.debug("{}: Applying foreign transaction {}", logContext, identifier); final DataTreeModification mod = dataTree.takeSnapshot().newModification(); @@ -202,7 +202,7 @@ public class ShardDataTree extends ShardDataTreeTransactionParent { return new SimpleShardDataTreeCohort(this, snapshot, transaction.getId()); } - public Optional> readNode(YangInstanceIdentifier path) { + public Optional> readNode(final YangInstanceIdentifier path) { return dataTree.takeSnapshot().readNode(path); } @@ -215,7 +215,7 @@ public class ShardDataTree extends ShardDataTreeTransactionParent { } // FIXME: This should be removed, it violates encapsulation - public DataTreeCandidate commit(DataTreeModification modification) throws DataValidationFailedException { + public DataTreeCandidate commit(final DataTreeModification modification) throws DataValidationFailedException { modification.ready(); dataTree.validate(modification); DataTreeCandidateTip candidate = dataTree.prepare(modification);