X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-distributed-datastore%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Fdatastore%2FShardTransaction.java;h=2421cce26c0afa6f7a7c7cc3cf6b5da5830f6fd0;hb=4639f61a41a93d6a762af97b819d164781b0f9f8;hp=737f57bf5d7314536f5fc20b1cbc45167f1b6e97;hpb=c222e37f2a0f0f3f6266242fbea2d3b018f4e6e3;p=controller.git diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/ShardTransaction.java b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/ShardTransaction.java index 737f57bf5d..2421cce26c 100644 --- a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/ShardTransaction.java +++ b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/ShardTransaction.java @@ -11,37 +11,22 @@ package org.opendaylight.controller.cluster.datastore; import akka.actor.ActorRef; import akka.actor.PoisonPill; import akka.actor.Props; -import akka.event.Logging; -import akka.event.LoggingAdapter; +import akka.actor.ReceiveTimeout; import akka.japi.Creator; import com.google.common.base.Optional; -import com.google.common.util.concurrent.ListenableFuture; +import com.google.common.base.Preconditions; +import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier; +import org.opendaylight.controller.cluster.common.actor.AbstractUntypedActorWithMetering; +import org.opendaylight.controller.cluster.datastore.jmx.mbeans.shard.ShardStats; import org.opendaylight.controller.cluster.datastore.messages.CloseTransaction; import org.opendaylight.controller.cluster.datastore.messages.CloseTransactionReply; -import org.opendaylight.controller.cluster.datastore.messages.DeleteData; -import org.opendaylight.controller.cluster.datastore.messages.DeleteDataReply; -import org.opendaylight.controller.cluster.datastore.messages.MergeData; -import org.opendaylight.controller.cluster.datastore.messages.MergeDataReply; +import org.opendaylight.controller.cluster.datastore.messages.DataExists; +import org.opendaylight.controller.cluster.datastore.messages.DataExistsReply; import org.opendaylight.controller.cluster.datastore.messages.ReadData; import org.opendaylight.controller.cluster.datastore.messages.ReadDataReply; -import org.opendaylight.controller.cluster.datastore.messages.ReadyTransaction; -import org.opendaylight.controller.cluster.datastore.messages.ReadyTransactionReply; -import org.opendaylight.controller.cluster.datastore.messages.WriteData; -import org.opendaylight.controller.cluster.datastore.messages.WriteDataReply; -import org.opendaylight.controller.cluster.datastore.modification.CompositeModification; -import org.opendaylight.controller.cluster.datastore.modification.DeleteModification; -import org.opendaylight.controller.cluster.datastore.modification.ImmutableCompositeModification; -import org.opendaylight.controller.cluster.datastore.modification.MergeModification; -import org.opendaylight.controller.cluster.datastore.modification.MutableCompositeModification; -import org.opendaylight.controller.cluster.datastore.modification.WriteModification; -import org.opendaylight.controller.sal.core.spi.data.DOMStoreReadWriteTransaction; -import org.opendaylight.controller.sal.core.spi.data.DOMStoreThreePhaseCommitCohort; -import org.opendaylight.controller.sal.core.spi.data.DOMStoreTransactionChain; +import org.opendaylight.controller.md.sal.common.api.data.ReadFailedException; import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier; import org.opendaylight.yangtools.yang.data.api.schema.NormalizedNode; -import org.opendaylight.yangtools.yang.model.api.SchemaContext; - -import java.util.concurrent.ExecutionException; /** * The ShardTransaction Actor represents a remote transaction @@ -49,186 +34,133 @@ import java.util.concurrent.ExecutionException; * The ShardTransaction Actor delegates all actions to DOMDataReadWriteTransaction *

*

- * Even though the DOMStore and the DOMStoreTransactionChain implement multiple types of transactions - * the ShardTransaction Actor only works with read-write transactions. This is just to keep the logic simple. At this - * time there are no known advantages for creating a read-only or write-only transaction which may change over time - * at which point we can optimize things in the distributed store as well. - *

- *

* Handles Messages
* ----------------
*

  • {@link org.opendaylight.controller.cluster.datastore.messages.ReadData} - *
  • {@link org.opendaylight.controller.cluster.datastore.messages.WriteData} - *
  • {@link org.opendaylight.controller.cluster.datastore.messages.MergeData} - *
  • {@link org.opendaylight.controller.cluster.datastore.messages.DeleteData} - *
  • {@link org.opendaylight.controller.cluster.datastore.messages.ReadyTransaction} *
  • {@link org.opendaylight.controller.cluster.datastore.messages.CloseTransaction} *

    */ -public class ShardTransaction extends AbstractUntypedActor { - +public abstract class ShardTransaction extends AbstractUntypedActorWithMetering { private final ActorRef shardActor; - private final SchemaContext schemaContext; - - // FIXME : see below - // If transactionChain is not null then this transaction is part of a - // transactionChain. Not really clear as to what that buys us - private final DOMStoreTransactionChain transactionChain; + private final ShardStats shardStats; + private final TransactionIdentifier transactionID; - private final DOMStoreReadWriteTransaction transaction; - - private final MutableCompositeModification modification = - new MutableCompositeModification(); - - private final LoggingAdapter log = - Logging.getLogger(getContext().system(), this); - - public ShardTransaction(DOMStoreReadWriteTransaction transaction, - ActorRef shardActor, SchemaContext schemaContext) { - this(null, transaction, shardActor, schemaContext); - } - - public ShardTransaction(DOMStoreTransactionChain transactionChain, DOMStoreReadWriteTransaction transaction, - ActorRef shardActor, SchemaContext schemaContext) { - this.transactionChain = transactionChain; - this.transaction = transaction; + protected ShardTransaction(ActorRef shardActor, ShardStats shardStats, TransactionIdentifier transactionID) { + super("shard-tx"); //actor name override used for metering. This does not change the "real" actor name this.shardActor = shardActor; - this.schemaContext = schemaContext; + this.shardStats = shardStats; + this.transactionID = Preconditions.checkNotNull(transactionID); } - - - public static Props props(final DOMStoreReadWriteTransaction transaction, - final ActorRef shardActor, final SchemaContext schemaContext) { - return Props.create(new Creator() { - - @Override - public ShardTransaction create() throws Exception { - return new ShardTransaction(transaction, shardActor, schemaContext); - } - }); + public static Props props(TransactionType type, AbstractShardDataTreeTransaction transaction, ActorRef shardActor, + DatastoreContext datastoreContext, ShardStats shardStats) { + return Props.create(new ShardTransactionCreator(type, transaction, shardActor, datastoreContext, shardStats)); } - public static Props props(final DOMStoreTransactionChain transactionChain, final DOMStoreReadWriteTransaction transaction, - final ActorRef shardActor, final SchemaContext schemaContext) { - return Props.create(new Creator() { + protected abstract AbstractShardDataTreeTransaction getDOMStoreTransaction(); - @Override - public ShardTransaction create() throws Exception { - return new ShardTransaction(transactionChain, transaction, shardActor, schemaContext); - } - }); + protected ActorRef getShardActor() { + return shardActor; } + protected final TransactionIdentifier getTransactionID() { + return transactionID; + } @Override - public void handleReceive(Object message) throws Exception { - if (ReadData.SERIALIZABLE_CLASS.equals(message.getClass())) { - readData(ReadData.fromSerializable(message)); - } else if (WriteData.SERIALIZABLE_CLASS.equals(message.getClass())) { - writeData(WriteData.fromSerializable(message, schemaContext)); - } else if (MergeData.SERIALIZABLE_CLASS.equals(message.getClass())) { - mergeData(MergeData.fromSerializable(message, schemaContext)); - } else if (DeleteData.SERIALIZABLE_CLASS.equals(message.getClass())) { - deleteData(DeleteData.fromSerizalizable(message)); - } else if (ReadyTransaction.SERIALIZABLE_CLASS.equals(message.getClass())) { - readyTransaction(new ReadyTransaction()); - } else if (message.getClass().equals(CloseTransaction.SERIALIZABLE_CLASS)) { - closeTransaction(new CloseTransaction()); - } else if (message instanceof GetCompositedModification) { - // This is here for testing only - getSender().tell(new GetCompositeModificationReply( - new ImmutableCompositeModification(modification)), getSelf()); - }else{ - throw new Exception ("Shard:handleRecieve received an unknown message"+message); + public void handleReceive(Object message) { + if (CloseTransaction.isSerializedType(message)) { + closeTransaction(true); + } else if (message instanceof ReceiveTimeout) { + LOG.debug("Got ReceiveTimeout for inactivity - closing transaction {}", transactionID); + closeTransaction(false); + } else { + unknownMessage(message); } } - private void readData(ReadData message) { - final ActorRef sender = getSender(); - final ActorRef self = getSelf(); - final YangInstanceIdentifier path = message.getPath(); - final ListenableFuture>> future = - transaction.read(path); - - future.addListener(new Runnable() { - @Override - public void run() { - try { - Optional> optional = future.get(); - if (optional.isPresent()) { - sender.tell(new ReadDataReply(schemaContext,optional.get()).toSerializable(), self); - } else { - sender.tell(new ReadDataReply(schemaContext,null).toSerializable(), self); - } - } catch (InterruptedException | ExecutionException e) { - log.error(e, - "An exception happened when reading data from path : " - + path.toString()); - } - - } - }, getContext().dispatcher()); + protected boolean returnCloseTransactionReply() { + return true; } + private void closeTransaction(boolean sendReply) { + getDOMStoreTransaction().abort(); - private void writeData(WriteData message) { - modification.addModification( - new WriteModification(message.getPath(), message.getData(),schemaContext)); - LOG.debug("writeData at path : " + message.getPath().toString()); - transaction.write(message.getPath(), message.getData()); - getSender().tell(new WriteDataReply().toSerializable(), getSelf()); - } + if(sendReply && returnCloseTransactionReply()) { + getSender().tell(new CloseTransactionReply(), getSelf()); + } - private void mergeData(MergeData message) { - modification.addModification( - new MergeModification(message.getPath(), message.getData(), schemaContext)); - LOG.debug("mergeData at path : " + message.getPath().toString()); - transaction.merge(message.getPath(), message.getData()); - getSender().tell(new MergeDataReply().toSerializable(), getSelf()); + getSelf().tell(PoisonPill.getInstance(), getSelf()); } - private void deleteData(DeleteData message) { - modification.addModification(new DeleteModification(message.getPath())); - transaction.delete(message.getPath()); - getSender().tell(new DeleteDataReply().toSerializable(), getSelf()); + private boolean checkClosed(AbstractShardDataTreeTransaction transaction) { + final boolean ret = transaction.isClosed(); + if (ret) { + shardStats.incrementFailedReadTransactionsCount(); + getSender().tell(new akka.actor.Status.Failure(new ReadFailedException("Transaction is closed")), getSelf()); + } + return ret; } - private void readyTransaction(ReadyTransaction message) { - DOMStoreThreePhaseCommitCohort cohort = transaction.ready(); - ActorRef cohortActor = getContext().actorOf( - ThreePhaseCommitCohort.props(cohort, shardActor, modification), "cohort"); - getSender() - .tell(new ReadyTransactionReply(cohortActor.path()).toSerializable(), getSelf()); - - } + protected void readData(AbstractShardDataTreeTransaction transaction, ReadData message) { + if (checkClosed(transaction)) { + return; + } - private void closeTransaction(CloseTransaction message) { - transaction.close(); - getSender().tell(new CloseTransactionReply().toSerializable(), getSelf()); - getSelf().tell(PoisonPill.getInstance(), getSelf()); + final YangInstanceIdentifier path = message.getPath(); + Optional> optional = transaction.getSnapshot().readNode(path); + ReadDataReply readDataReply = new ReadDataReply(optional.orNull(), message.getVersion()); + sender().tell(readDataReply.toSerializable(), self()); } + protected void dataExists(AbstractShardDataTreeTransaction transaction, DataExists message) { + if (checkClosed(transaction)) { + return; + } - // These classes are in here for test purposes only - - - static class GetCompositedModification { - + final YangInstanceIdentifier path = message.getPath(); + boolean exists = transaction.getSnapshot().readNode(path).isPresent(); + getSender().tell(new DataExistsReply(exists, message.getVersion()).toSerializable(), getSelf()); } + private static class ShardTransactionCreator implements Creator { - static class GetCompositeModificationReply { - private final CompositeModification modification; + private static final long serialVersionUID = 1L; + final AbstractShardDataTreeTransaction transaction; + final ActorRef shardActor; + final DatastoreContext datastoreContext; + final ShardStats shardStats; + final TransactionType type; - GetCompositeModificationReply(CompositeModification modification) { - this.modification = modification; + ShardTransactionCreator(TransactionType type, AbstractShardDataTreeTransaction transaction, ActorRef shardActor, + DatastoreContext datastoreContext, ShardStats shardStats) { + this.transaction = Preconditions.checkNotNull(transaction); + this.shardActor = shardActor; + this.shardStats = shardStats; + this.datastoreContext = datastoreContext; + this.type = type; } + @Override + public ShardTransaction create() throws Exception { + final ShardTransaction tx; + switch (type) { + case READ_ONLY: + tx = new ShardReadTransaction(transaction, shardActor, shardStats); + break; + case READ_WRITE: + tx = new ShardReadWriteTransaction((ReadWriteShardDataTreeTransaction)transaction, shardActor, shardStats); + break; + case WRITE_ONLY: + tx = new ShardWriteTransaction((ReadWriteShardDataTreeTransaction)transaction, shardActor, shardStats); + break; + default: + throw new IllegalArgumentException("Unhandled transaction type " + type); + } - public CompositeModification getModification() { - return modification; + tx.getContext().setReceiveTimeout(datastoreContext.getShardTransactionIdleTimeout()); + return tx; } } }