X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-distributed-datastore%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Fdatastore%2FThreePhaseCommitCohortProxy.java;h=fc455b193e27118f6dcfcc2de93032f2676c5619;hb=d0bf270d0493c04ac2e9e4a9f7de56e5b65a4ef2;hp=197b3b70cefa292e3829b776560b4cd2ae99967f;hpb=2d16cfa0af7079ff969dcb81da6071ecacb3a5f6;p=controller.git diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/ThreePhaseCommitCohortProxy.java b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/ThreePhaseCommitCohortProxy.java index 197b3b70ce..fc455b193e 100644 --- a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/ThreePhaseCommitCohortProxy.java +++ b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/ThreePhaseCommitCohortProxy.java @@ -9,8 +9,28 @@ package org.opendaylight.controller.cluster.datastore; import akka.actor.ActorPath; +import akka.actor.ActorSelection; +import akka.dispatch.Futures; +import akka.dispatch.OnComplete; + +import com.google.common.collect.Lists; import com.google.common.util.concurrent.ListenableFuture; +import com.google.common.util.concurrent.SettableFuture; + +import org.opendaylight.controller.cluster.datastore.messages.AbortTransaction; +import org.opendaylight.controller.cluster.datastore.messages.AbortTransactionReply; +import org.opendaylight.controller.cluster.datastore.messages.CanCommitTransaction; +import org.opendaylight.controller.cluster.datastore.messages.CanCommitTransactionReply; +import org.opendaylight.controller.cluster.datastore.messages.CommitTransaction; +import org.opendaylight.controller.cluster.datastore.messages.CommitTransactionReply; +import org.opendaylight.controller.cluster.datastore.messages.PreCommitTransaction; +import org.opendaylight.controller.cluster.datastore.messages.PreCommitTransactionReply; +import org.opendaylight.controller.cluster.datastore.utils.ActorContext; import org.opendaylight.controller.sal.core.spi.data.DOMStoreThreePhaseCommitCohort; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import scala.concurrent.Future; import java.util.Collections; import java.util.List; @@ -18,30 +38,148 @@ import java.util.List; /** * ThreePhaseCommitCohortProxy represents a set of remote cohort proxies */ -public class ThreePhaseCommitCohortProxy implements - DOMStoreThreePhaseCommitCohort{ +public class ThreePhaseCommitCohortProxy implements DOMStoreThreePhaseCommitCohort{ - private final List cohortPaths; + private static final Logger LOG = LoggerFactory.getLogger(DistributedDataStore.class); - public ThreePhaseCommitCohortProxy(List cohortPaths) { + private final ActorContext actorContext; + private final List cohortPaths; + private final String transactionId; + public ThreePhaseCommitCohortProxy(ActorContext actorContext, List cohortPaths, + String transactionId) { + this.actorContext = actorContext; this.cohortPaths = cohortPaths; + this.transactionId = transactionId; } - @Override public ListenableFuture canCommit() { - throw new UnsupportedOperationException("canCommit"); + @Override + public ListenableFuture canCommit() { + LOG.debug("txn {} canCommit", transactionId); + + Future> combinedFuture = + invokeCohorts(new CanCommitTransaction().toSerializable()); + + final SettableFuture returnFuture = SettableFuture.create(); + + combinedFuture.onComplete(new OnComplete>() { + @Override + public void onComplete(Throwable failure, Iterable responses) throws Throwable { + if(failure != null) { + returnFuture.setException(failure); + return; + } + + boolean result = true; + for(Object response: responses) { + if (response.getClass().equals(CanCommitTransactionReply.SERIALIZABLE_CLASS)) { + CanCommitTransactionReply reply = + CanCommitTransactionReply.fromSerializable(response); + if (!reply.getCanCommit()) { + result = false; + break; + } + } else { + LOG.error("Unexpected response type {}", response.getClass()); + returnFuture.setException(new IllegalArgumentException( + String.format("Unexpected response type {}", response.getClass()))); + return; + } + } + + returnFuture.set(Boolean.valueOf(result)); + } + }, actorContext.getActorSystem().dispatcher()); + + return returnFuture; } - @Override public ListenableFuture preCommit() { - throw new UnsupportedOperationException("preCommit"); + private Future> invokeCohorts(Object message) { + List> futureList = Lists.newArrayListWithCapacity(cohortPaths.size()); + for(ActorPath actorPath : cohortPaths) { + + LOG.debug("txn {} Sending {} to {}", transactionId, message, actorPath); + + ActorSelection cohort = actorContext.actorSelection(actorPath); + + futureList.add(actorContext.executeRemoteOperationAsync(cohort, message, + ActorContext.ASK_DURATION)); + } + + return Futures.sequence(futureList, actorContext.getActorSystem().dispatcher()); + } + + @Override + public ListenableFuture preCommit() { + LOG.debug("txn {} preCommit", transactionId); + return voidOperation(new PreCommitTransaction().toSerializable(), + PreCommitTransactionReply.SERIALIZABLE_CLASS, true); + } + + @Override + public ListenableFuture abort() { + LOG.debug("txn {} abort", transactionId); + + // Note - we pass false for propagateException. In the front-end data broker, this method + // is called when one of the 3 phases fails with an exception. We'd rather have that + // original exception propagated to the client. If our abort fails and we propagate the + // exception then that exception will supersede and suppress the original exception. But + // it's the original exception that is the root cause and of more interest to the client. + + return voidOperation(new AbortTransaction().toSerializable(), + AbortTransactionReply.SERIALIZABLE_CLASS, false); } - @Override public ListenableFuture abort() { - throw new UnsupportedOperationException("abort"); + @Override + public ListenableFuture commit() { + LOG.debug("txn {} commit", transactionId); + return voidOperation(new CommitTransaction().toSerializable(), + CommitTransactionReply.SERIALIZABLE_CLASS, true); } - @Override public ListenableFuture commit() { - throw new UnsupportedOperationException("commit"); + private ListenableFuture voidOperation(final Object message, + final Class expectedResponseClass, final boolean propagateException) { + + Future> combinedFuture = invokeCohorts(message); + + final SettableFuture returnFuture = SettableFuture.create(); + + combinedFuture.onComplete(new OnComplete>() { + @Override + public void onComplete(Throwable failure, Iterable responses) throws Throwable { + + Throwable exceptionToPropagate = failure; + if(exceptionToPropagate == null) { + for(Object response: responses) { + if(!response.getClass().equals(expectedResponseClass)) { + exceptionToPropagate = new IllegalArgumentException( + String.format("Unexpected response type {}", + response.getClass())); + break; + } + } + } + + if(exceptionToPropagate != null) { + if(propagateException) { + // We don't log the exception here to avoid redundant logging since we're + // propagating to the caller in MD-SAL core who will log it. + returnFuture.setException(exceptionToPropagate); + } else { + // Since the caller doesn't want us to propagate the exception we'll also + // not log it normally. But it's usually not good to totally silence + // exceptions so we'll log it to debug level. + LOG.debug(String.format("%s failed", message.getClass().getSimpleName()), + exceptionToPropagate); + returnFuture.set(null); + } + } else { + returnFuture.set(null); + } + } + }, actorContext.getActorSystem().dispatcher()); + + return returnFuture; } public List getCohortPaths() {