X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-distributed-datastore%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Fdatastore%2FTransactionContextFactory.java;h=d7f493565b7fd8eaa923ca614ed02c47ab142fd7;hb=b5cb353e3553a39f576c284119af75ffa5ea66a9;hp=8d7ca990dd48f3605854a3ea00f67dbf6c85cd3d;hpb=daaef05cbf70e6cbec9af181258faead6d9620a6;p=controller.git diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/TransactionContextFactory.java b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/TransactionContextFactory.java index 8d7ca990dd..d7f493565b 100644 --- a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/TransactionContextFactory.java +++ b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/TransactionContextFactory.java @@ -8,13 +8,13 @@ package org.opendaylight.controller.cluster.datastore; import akka.actor.ActorSelection; -import java.util.ArrayList; import java.util.Collection; -import javax.annotation.concurrent.GuardedBy; -import org.opendaylight.controller.cluster.datastore.identifiers.TransactionIdentifier; +import java.util.concurrent.atomic.AtomicLong; +import org.opendaylight.controller.cluster.access.concepts.ClientIdentifier; +import org.opendaylight.controller.cluster.access.concepts.LocalHistoryIdentifier; +import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier; import org.opendaylight.controller.cluster.datastore.messages.PrimaryShardInfo; import org.opendaylight.controller.cluster.datastore.utils.ActorContext; -import org.opendaylight.controller.cluster.datastore.utils.ShardInfoListenerRegistration; import org.opendaylight.controller.sal.core.spi.data.DOMStoreTransactionChain; import org.opendaylight.yangtools.yang.data.api.schema.tree.DataTree; import scala.concurrent.Future; @@ -24,74 +24,39 @@ import scala.concurrent.Future; * transactions (ie not chained). */ final class TransactionContextFactory extends AbstractTransactionContextFactory { + private final AtomicLong nextHistory = new AtomicLong(1); - @GuardedBy("childChains") - private final Collection childChains = new ArrayList<>(); - - private final ShardInfoListenerRegistration reg; - - private TransactionContextFactory(final ActorContext actorContext) { - super(actorContext); - this.reg = actorContext.registerShardInfoListener(this); - } - - static TransactionContextFactory create(final ActorContext actorContext) { - return new TransactionContextFactory(actorContext); + TransactionContextFactory(final ActorContext actorContext, final ClientIdentifier clientId) { + super(actorContext, new LocalHistoryIdentifier(clientId, 0)); } @Override public void close() { - reg.close(); - } - - @Override - protected TransactionIdentifier nextIdentifier() { - return TransactionIdentifier.create(getMemberName(), TX_COUNTER.getAndIncrement(), null); } @Override - protected LocalTransactionFactoryImpl factoryForShard(final String shardName, final ActorSelection shardLeader, final DataTree dataTree) { + protected LocalTransactionFactoryImpl factoryForShard(final String shardName, final ActorSelection shardLeader, + final DataTree dataTree) { return new LocalTransactionFactoryImpl(getActorContext(), shardLeader, dataTree); } @Override - protected Future findPrimaryShard(final String shardName) { + protected Future findPrimaryShard(final String shardName, TransactionIdentifier txId) { return getActorContext().findPrimaryShardAsync(shardName); } @Override - protected void onTransactionReady(final TransactionIdentifier transaction, final Collection> cohortFutures) { + protected void onTransactionReady(final TransactionIdentifier transaction, + final Collection> cohortFutures) { // Transactions are disconnected, this is a no-op } DOMStoreTransactionChain createTransactionChain() { - final TransactionChainProxy ret = new TransactionChainProxy(this); - - synchronized (childChains) { - childChains.add(ret); - } - - return ret; - } - - void removeTransactionChain(final TransactionChainProxy chain) { - synchronized (childChains) { - childChains.remove(chain); - } - } - - @Override - public void onShardInfoUpdated(final String shardName, final PrimaryShardInfo primaryShardInfo) { - synchronized (childChains) { - for (TransactionChainProxy chain : childChains) { - chain.onShardInfoUpdated(shardName, primaryShardInfo); - } - super.onShardInfoUpdated(shardName, primaryShardInfo); - } + return new TransactionChainProxy(this, new LocalHistoryIdentifier(getHistoryId().getClientId(), + nextHistory.getAndIncrement())); } @Override - protected DataTree dataTreeForFactory(final LocalTransactionFactoryImpl factory) { - return factory.getDataTree(); + protected void onTransactionContextCreated(final TransactionIdentifier transactionId) { } }