X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-distributed-datastore%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Fdatastore%2Fentityownership%2FEntityOwnerChangeListener.java;h=050ee5d4a57214092abbf07cb736610b91b0e64c;hb=17211c982bcee83306af49b1b75c764dcb504b5d;hp=bea0caa7c666ed2ae158a6e130cf32c04e703730;hpb=ecccb6d5b43dd73aef0d2d19349d19ee9b4728f7;p=controller.git diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/entityownership/EntityOwnerChangeListener.java b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/entityownership/EntityOwnerChangeListener.java index bea0caa7c6..050ee5d4a5 100644 --- a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/entityownership/EntityOwnerChangeListener.java +++ b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/entityownership/EntityOwnerChangeListener.java @@ -7,17 +7,15 @@ */ package org.opendaylight.controller.cluster.datastore.entityownership; -import static org.opendaylight.controller.cluster.datastore.entityownership.EntityOwnersModel.ENTITY_OWNERS_PATH; -import static org.opendaylight.controller.cluster.datastore.entityownership.EntityOwnersModel.ENTITY_QNAME; import static org.opendaylight.controller.cluster.datastore.entityownership.EntityOwnersModel.createEntity; -import com.google.common.base.Objects; import com.google.common.base.Optional; +import com.google.common.base.Preconditions; +import com.google.common.base.Strings; +import com.google.common.base.Verify; import java.util.Collection; -import org.opendaylight.controller.cluster.datastore.ShardDataTree; -import org.opendaylight.controller.md.sal.common.api.clustering.Entity; -import org.opendaylight.controller.md.sal.dom.api.DOMDataTreeChangeListener; -import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.md.sal.clustering.entity.owners.rev150804.entity.owners.EntityType; -import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier; +import java.util.Objects; +import org.opendaylight.controller.cluster.access.concepts.MemberName; +import org.opendaylight.mdsal.eos.dom.api.DOMEntity; import org.opendaylight.yangtools.yang.data.api.schema.LeafNode; import org.opendaylight.yangtools.yang.data.api.schema.NormalizedNode; import org.opendaylight.yangtools.yang.data.api.schema.tree.DataTreeCandidate; @@ -30,24 +28,19 @@ import org.slf4j.LoggerFactory; * * @author Thomas Pantelis */ -class EntityOwnerChangeListener implements DOMDataTreeChangeListener { +class EntityOwnerChangeListener extends AbstractEntityOwnerChangeListener { private static final Logger LOG = LoggerFactory.getLogger(EntityOwnerChangeListener.class); private final String localMemberName; private final EntityOwnershipListenerSupport listenerSupport; - EntityOwnerChangeListener(String localMemberName, EntityOwnershipListenerSupport listenerSupport) { - this.localMemberName = localMemberName; - this.listenerSupport = listenerSupport; - } - - void init(ShardDataTree shardDataTree) { - shardDataTree.registerTreeChangeListener(YangInstanceIdentifier.builder(ENTITY_OWNERS_PATH). - node(EntityType.QNAME).node(EntityType.QNAME).node(ENTITY_QNAME).node(ENTITY_QNAME).node(EntityOwnersModel.ENTITY_OWNER_QNAME).build(), this); + EntityOwnerChangeListener(final MemberName localMemberName, final EntityOwnershipListenerSupport listenerSupport) { + this.localMemberName = Verify.verifyNotNull(localMemberName.getName()); + this.listenerSupport = Preconditions.checkNotNull(listenerSupport); } @Override - public void onDataTreeChanged(Collection changes) { + public void onDataTreeChanged(final Collection changes) { for(DataTreeCandidate change: changes) { DataTreeCandidateNode changeRoot = change.getRootNode(); LeafNode ownerLeaf = (LeafNode) changeRoot.getDataAfter().get(); @@ -64,12 +57,12 @@ class EntityOwnerChangeListener implements DOMDataTreeChangeListener { LOG.debug("{}: New owner: {}, Original owner: {}", logId(), newOwner, origOwner); - if(!Objects.equal(origOwner, newOwner)) { - boolean isOwner = Objects.equal(localMemberName, newOwner); - boolean wasOwner = Objects.equal(localMemberName, origOwner); - boolean hasOwner = newOwner != null && !newOwner.toString().isEmpty(); + if (!Objects.equals(origOwner, newOwner)) { + boolean isOwner = localMemberName.equals(newOwner); + boolean wasOwner = localMemberName.equals(origOwner); + boolean hasOwner = !Strings.isNullOrEmpty(newOwner); - Entity entity = createEntity(change.getRootPath()); + DOMEntity entity = createEntity(change.getRootPath()); LOG.debug("{}: Calling notifyEntityOwnershipListeners: entity: {}, wasOwner: {}, isOwner: {}, hasOwner: {}", logId(), entity, wasOwner, isOwner, hasOwner); @@ -79,11 +72,6 @@ class EntityOwnerChangeListener implements DOMDataTreeChangeListener { } } - private static String extractOwner(LeafNode ownerLeaf) { - Object value = ownerLeaf.getValue(); - return value != null ? value.toString() : null; - } - private String logId() { return listenerSupport.getLogId(); }