X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-distributed-datastore%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Fdatastore%2Fmessages%2FReadData.java;h=6352b5734b9dae632f187792c5119d1ce815fb10;hb=7a38f0591bc527178510d749ae361e317dcc9788;hp=7837493970cb2860fd7d819876f848318068f143;hpb=909831d806ef3b35358206559523f09716214e58;p=controller.git diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/messages/ReadData.java b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/messages/ReadData.java index 7837493970..6352b5734b 100644 --- a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/messages/ReadData.java +++ b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/messages/ReadData.java @@ -8,14 +8,12 @@ package org.opendaylight.controller.cluster.datastore.messages; -import com.google.common.base.Optional; -import com.google.common.util.concurrent.CheckedFuture; +import com.google.common.base.Preconditions; +import com.google.common.util.concurrent.FluentFuture; import com.google.common.util.concurrent.SettableFuture; -import org.opendaylight.controller.cluster.datastore.DataStoreVersions; -import org.opendaylight.controller.cluster.datastore.util.InstanceIdentifierUtils; -import org.opendaylight.controller.md.sal.common.api.data.ReadFailedException; -import org.opendaylight.controller.protobuff.messages.transaction.ShardTransactionMessages; -import org.opendaylight.controller.sal.core.spi.data.DOMStoreReadTransaction; +import java.util.Optional; +import org.opendaylight.mdsal.common.api.ReadFailedException; +import org.opendaylight.mdsal.dom.spi.store.DOMStoreReadTransaction; import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier; import org.opendaylight.yangtools.yang.data.api.schema.NormalizedNode; @@ -30,21 +28,15 @@ public class ReadData extends AbstractRead>> { } @Override - protected Object newLegacySerializedInstance() { - return ShardTransactionMessages.ReadData.newBuilder() - .setInstanceIdentifierPathArguments(InstanceIdentifierUtils.toSerializable(getPath())).build(); - } - - @Override - public CheckedFuture>, ReadFailedException> apply(DOMStoreReadTransaction readDelegate) { + public FluentFuture>> apply(DOMStoreReadTransaction readDelegate) { return readDelegate.read(getPath()); } @Override public void processResponse(Object readResponse, SettableFuture>> returnFuture) { - if(ReadDataReply.isSerializedType(readResponse)) { + if (ReadDataReply.isSerializedType(readResponse)) { ReadDataReply reply = ReadDataReply.fromSerializable(readResponse); - returnFuture.set(Optional.> fromNullable(reply.getNormalizedNode())); + returnFuture.set(Optional.>ofNullable(reply.getNormalizedNode())); } else { returnFuture.setException(new ReadFailedException("Invalid response reading data for path " + getPath())); } @@ -56,16 +48,11 @@ public class ReadData extends AbstractRead>> { } public static ReadData fromSerializable(final Object serializable) { - if(serializable instanceof ReadData) { - return (ReadData)serializable; - } else { - ShardTransactionMessages.ReadData o = (ShardTransactionMessages.ReadData)serializable; - return new ReadData(InstanceIdentifierUtils.fromSerializable(o.getInstanceIdentifierPathArguments()), - DataStoreVersions.LITHIUM_VERSION); - } + Preconditions.checkArgument(serializable instanceof ReadData); + return (ReadData)serializable; } public static boolean isSerializedType(Object message) { - return message instanceof ReadData || message instanceof ShardTransactionMessages.ReadData; + return message instanceof ReadData; } }