X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-distributed-datastore%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Fdatastore%2Fmessages%2FReadData.java;h=e79513e06a0a13e293bfb8b47b46c08cb317d278;hb=583f30d1c7a8199b401c9393745c62fe27b5ced8;hp=c2709d757fdacc83ea6932337dd27ee64f7ab46f;hpb=e448e4e5f1f071aa61152b2f49b239d878c0a580;p=controller.git diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/messages/ReadData.java b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/messages/ReadData.java index c2709d757f..e79513e06a 100644 --- a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/messages/ReadData.java +++ b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/messages/ReadData.java @@ -9,12 +9,10 @@ package org.opendaylight.controller.cluster.datastore.messages; import com.google.common.base.Optional; +import com.google.common.base.Preconditions; import com.google.common.util.concurrent.CheckedFuture; import com.google.common.util.concurrent.SettableFuture; -import org.opendaylight.controller.cluster.datastore.DataStoreVersions; -import org.opendaylight.controller.cluster.datastore.util.InstanceIdentifierUtils; import org.opendaylight.controller.md.sal.common.api.data.ReadFailedException; -import org.opendaylight.controller.protobuff.messages.transaction.ShardTransactionMessages; import org.opendaylight.controller.sal.core.spi.data.DOMStoreReadTransaction; import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier; import org.opendaylight.yangtools.yang.data.api.schema.NormalizedNode; @@ -30,25 +28,16 @@ public class ReadData extends AbstractRead>> { } @Override - public Object toSerializable() { - if(getVersion() >= DataStoreVersions.BORON_VERSION) { - return this; - } else { - return ShardTransactionMessages.ReadData.newBuilder().setInstanceIdentifierPathArguments( - InstanceIdentifierUtils.toSerializable(getPath())).build(); - } - } - - @Override - public CheckedFuture>, ReadFailedException> apply(DOMStoreReadTransaction readDelegate) { + public CheckedFuture>, ReadFailedException> apply( + DOMStoreReadTransaction readDelegate) { return readDelegate.read(getPath()); } @Override public void processResponse(Object readResponse, SettableFuture>> returnFuture) { - if(ReadDataReply.isSerializedType(readResponse)) { + if (ReadDataReply.isSerializedType(readResponse)) { ReadDataReply reply = ReadDataReply.fromSerializable(readResponse); - returnFuture.set(Optional.> fromNullable(reply.getNormalizedNode())); + returnFuture.set(Optional.>fromNullable(reply.getNormalizedNode())); } else { returnFuture.setException(new ReadFailedException("Invalid response reading data for path " + getPath())); } @@ -60,16 +49,11 @@ public class ReadData extends AbstractRead>> { } public static ReadData fromSerializable(final Object serializable) { - if(serializable instanceof ReadData) { - return (ReadData)serializable; - } else { - ShardTransactionMessages.ReadData o = (ShardTransactionMessages.ReadData)serializable; - return new ReadData(InstanceIdentifierUtils.fromSerializable(o.getInstanceIdentifierPathArguments()), - DataStoreVersions.LITHIUM_VERSION); - } + Preconditions.checkArgument(serializable instanceof ReadData); + return (ReadData)serializable; } public static boolean isSerializedType(Object message) { - return message instanceof ReadData || message instanceof ShardTransactionMessages.ReadData; + return message instanceof ReadData; } }