X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-distributed-datastore%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Fdatastore%2Fmessages%2FReadData.java;h=e79513e06a0a13e293bfb8b47b46c08cb317d278;hb=b5cb353e3553a39f576c284119af75ffa5ea66a9;hp=6a01f281aa8c7539ad7f73d2f28b42d8d6f04c62;hpb=dd16edd5a758f0e51727de511f9868c72b2a1dd0;p=controller.git diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/messages/ReadData.java b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/messages/ReadData.java index 6a01f281aa..e79513e06a 100644 --- a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/messages/ReadData.java +++ b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/messages/ReadData.java @@ -9,12 +9,10 @@ package org.opendaylight.controller.cluster.datastore.messages; import com.google.common.base.Optional; +import com.google.common.base.Preconditions; import com.google.common.util.concurrent.CheckedFuture; import com.google.common.util.concurrent.SettableFuture; -import org.opendaylight.controller.cluster.datastore.DataStoreVersions; -import org.opendaylight.controller.cluster.datastore.util.InstanceIdentifierUtils; import org.opendaylight.controller.md.sal.common.api.data.ReadFailedException; -import org.opendaylight.controller.protobuff.messages.transaction.ShardTransactionMessages; import org.opendaylight.controller.sal.core.spi.data.DOMStoreReadTransaction; import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier; import org.opendaylight.yangtools.yang.data.api.schema.NormalizedNode; @@ -29,23 +27,17 @@ public class ReadData extends AbstractRead>> { super(path, version); } - @Deprecated @Override - protected Object newLegacySerializedInstance() { - return ShardTransactionMessages.ReadData.newBuilder() - .setInstanceIdentifierPathArguments(InstanceIdentifierUtils.toSerializable(getPath())).build(); - } - - @Override - public CheckedFuture>, ReadFailedException> apply(DOMStoreReadTransaction readDelegate) { + public CheckedFuture>, ReadFailedException> apply( + DOMStoreReadTransaction readDelegate) { return readDelegate.read(getPath()); } @Override public void processResponse(Object readResponse, SettableFuture>> returnFuture) { - if(ReadDataReply.isSerializedType(readResponse)) { + if (ReadDataReply.isSerializedType(readResponse)) { ReadDataReply reply = ReadDataReply.fromSerializable(readResponse); - returnFuture.set(Optional.> fromNullable(reply.getNormalizedNode())); + returnFuture.set(Optional.>fromNullable(reply.getNormalizedNode())); } else { returnFuture.setException(new ReadFailedException("Invalid response reading data for path " + getPath())); } @@ -57,16 +49,11 @@ public class ReadData extends AbstractRead>> { } public static ReadData fromSerializable(final Object serializable) { - if(serializable instanceof ReadData) { - return (ReadData)serializable; - } else { - ShardTransactionMessages.ReadData o = (ShardTransactionMessages.ReadData)serializable; - return new ReadData(InstanceIdentifierUtils.fromSerializable(o.getInstanceIdentifierPathArguments()), - DataStoreVersions.LITHIUM_VERSION); - } + Preconditions.checkArgument(serializable instanceof ReadData); + return (ReadData)serializable; } public static boolean isSerializedType(Object message) { - return message instanceof ReadData || message instanceof ShardTransactionMessages.ReadData; + return message instanceof ReadData; } }