X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-distributed-datastore%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Fdatastore%2Fpersisted%2FAbstractIdentifiablePayload.java;h=de9b0bba8a3acd6668fd8c0c54b7edb4d9998092;hb=1d5ca4009be6c61d7b61989799037ad8f1ab7a75;hp=b0ad960cb84af19642cdd8571ee48ba6b5fbe684;hpb=2d60632f7cf63712e8357a3cf3fc40d83366e5e6;p=controller.git diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/persisted/AbstractIdentifiablePayload.java b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/persisted/AbstractIdentifiablePayload.java index b0ad960cb8..de9b0bba8a 100644 --- a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/persisted/AbstractIdentifiablePayload.java +++ b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/persisted/AbstractIdentifiablePayload.java @@ -7,8 +7,9 @@ */ package org.opendaylight.controller.cluster.datastore.persisted; -import com.google.common.base.Preconditions; -import com.google.common.base.Verify; +import static com.google.common.base.Verify.verifyNotNull; +import static java.util.Objects.requireNonNull; + import com.google.common.io.ByteStreams; import java.io.DataInput; import java.io.Externalizable; @@ -16,7 +17,8 @@ import java.io.IOException; import java.io.ObjectInput; import java.io.ObjectOutput; import java.io.Serializable; -import javax.annotation.Nonnull; +import org.eclipse.jdt.annotation.NonNull; +import org.opendaylight.controller.cluster.raft.protobuff.client.messages.IdentifiablePayload; import org.opendaylight.controller.cluster.raft.protobuff.client.messages.Payload; import org.opendaylight.yangtools.concepts.Identifiable; import org.opendaylight.yangtools.concepts.Identifier; @@ -26,10 +28,11 @@ import org.opendaylight.yangtools.concepts.Identifier; * * @author Robert Varga */ -public abstract class AbstractIdentifiablePayload - extends Payload implements Identifiable, Serializable { +public abstract class AbstractIdentifiablePayload extends IdentifiablePayload + implements Serializable { protected abstract static class AbstractProxy implements Externalizable { private static final long serialVersionUID = 1L; + private byte[] serialized; private T identifier; @@ -38,7 +41,7 @@ public abstract class AbstractIdentifiablePayload } protected AbstractProxy(final byte[] serialized) { - this.serialized = Preconditions.checkNotNull(serialized); + this.serialized = requireNonNull(serialized); } @Override @@ -48,32 +51,31 @@ public abstract class AbstractIdentifiablePayload } @Override - public final void readExternal(final ObjectInput in) throws IOException, ClassNotFoundException { + public final void readExternal(final ObjectInput in) throws IOException { final int length = in.readInt(); serialized = new byte[length]; in.readFully(serialized); - identifier = Verify.verifyNotNull(readIdentifier(ByteStreams.newDataInput(serialized))); + identifier = verifyNotNull(readIdentifier(ByteStreams.newDataInput(serialized))); } protected final Object readResolve() { - return Verify.verifyNotNull(createObject(identifier, serialized)); + return verifyNotNull(createObject(identifier, serialized)); } - @Nonnull - protected abstract T readIdentifier(@Nonnull DataInput in) throws IOException; + protected abstract @NonNull T readIdentifier(@NonNull DataInput in) throws IOException; - @Nonnull @SuppressWarnings("checkstyle:hiddenField") - protected abstract Identifiable createObject(@Nonnull T identifier, @Nonnull byte[] serialized); + protected abstract @NonNull Identifiable createObject(@NonNull T identifier, byte @NonNull[] serialized); } private static final long serialVersionUID = 1L; - private final byte[] serialized; - private final T identifier; - AbstractIdentifiablePayload(@Nonnull final T identifier, @Nonnull final byte[] serialized) { - this.identifier = Preconditions.checkNotNull(identifier); - this.serialized = Preconditions.checkNotNull(serialized); + private final byte @NonNull [] serialized; + private final @NonNull T identifier; + + AbstractIdentifiablePayload(final @NonNull T identifier, final byte @NonNull[] serialized) { + this.identifier = requireNonNull(identifier); + this.serialized = requireNonNull(serialized); } @Override @@ -87,10 +89,9 @@ public abstract class AbstractIdentifiablePayload } protected final Object writeReplace() { - return Verify.verifyNotNull(externalizableProxy(serialized)); + return verifyNotNull(externalizableProxy(serialized)); } - @Nonnull @SuppressWarnings("checkstyle:hiddenField") - protected abstract AbstractProxy externalizableProxy(@Nonnull byte[] serialized); + protected abstract @NonNull AbstractProxy externalizableProxy(byte @NonNull[] serialized); }