X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-distributed-datastore%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Fdatastore%2Fpersisted%2FDataTreeCandidateInputOutput.java;h=0771b439e226f8abea4d4645ee427a85ff3895cf;hb=8e1d3c4f9001fbc8a5d3d3bea57916c5099078b2;hp=a3b30466c87e9d94bccdbe1702bae08adeab8282;hpb=55ac0d700c4b20f145924b169b938321dc10a476;p=controller.git diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/persisted/DataTreeCandidateInputOutput.java b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/persisted/DataTreeCandidateInputOutput.java index a3b30466c8..0771b439e2 100644 --- a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/persisted/DataTreeCandidateInputOutput.java +++ b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/persisted/DataTreeCandidateInputOutput.java @@ -85,22 +85,15 @@ public final class DataTreeCandidateInputOutput { private static DataTreeCandidateNode readNode(final NormalizedNodeDataInput in, final ReusableStreamReceiver receiver) throws IOException { final byte type = in.readByte(); - switch (type) { - case APPEARED: - return readModifiedNode(ModificationType.APPEARED, in, receiver); - case DELETE: - return DeletedDataTreeCandidateNode.create(in.readPathArgument()); - case DISAPPEARED: - return readModifiedNode(ModificationType.DISAPPEARED, in, receiver); - case SUBTREE_MODIFIED: - return readModifiedNode(ModificationType.SUBTREE_MODIFIED, in, receiver); - case UNMODIFIED: - return null; - case WRITE: - return DataTreeCandidateNodes.written(in.readNormalizedNode(receiver)); - default: - throw new IllegalArgumentException("Unhandled node type " + type); - } + return switch (type) { + case APPEARED -> readModifiedNode(ModificationType.APPEARED, in, receiver); + case DELETE -> DeletedDataTreeCandidateNode.create(in.readPathArgument()); + case DISAPPEARED -> readModifiedNode(ModificationType.DISAPPEARED, in, receiver); + case SUBTREE_MODIFIED -> readModifiedNode(ModificationType.SUBTREE_MODIFIED, in, receiver); + case UNMODIFIED -> null; + case WRITE -> DataTreeCandidateNodes.written(in.readNormalizedNode(receiver)); + default -> throw new IllegalArgumentException("Unhandled node type " + type); + }; } @NonNullByDefault @@ -129,33 +122,18 @@ public final class DataTreeCandidateInputOutput { final YangInstanceIdentifier rootPath = reader.readYangInstanceIdentifier(); final byte type = reader.readByte(); - final DataTreeCandidateNode rootNode; - switch (type) { - case APPEARED: - rootNode = ModifiedDataTreeCandidateNode.create(ModificationType.APPEARED, - readChildren(reader, receiver)); - break; - case DELETE: - rootNode = DeletedDataTreeCandidateNode.create(); - break; - case DISAPPEARED: - rootNode = ModifiedDataTreeCandidateNode.create(ModificationType.DISAPPEARED, - readChildren(reader, receiver)); - break; - case SUBTREE_MODIFIED: - rootNode = ModifiedDataTreeCandidateNode.create(ModificationType.SUBTREE_MODIFIED, - readChildren(reader, receiver)); - break; - case WRITE: - rootNode = DataTreeCandidateNodes.written(reader.readNormalizedNode(receiver)); - break; - case UNMODIFIED: - rootNode = AbstractDataTreeCandidateNode.createUnmodified(); - break; - default: - throw new IllegalArgumentException("Unhandled node type " + type); - } - + final DataTreeCandidateNode rootNode = switch (type) { + case APPEARED -> ModifiedDataTreeCandidateNode.create(ModificationType.APPEARED, + readChildren(reader, receiver)); + case DELETE -> DeletedDataTreeCandidateNode.create(); + case DISAPPEARED -> ModifiedDataTreeCandidateNode.create(ModificationType.DISAPPEARED, + readChildren(reader, receiver)); + case SUBTREE_MODIFIED -> ModifiedDataTreeCandidateNode.create(ModificationType.SUBTREE_MODIFIED, + readChildren(reader, receiver)); + case WRITE -> DataTreeCandidateNodes.written(reader.readNormalizedNode(receiver)); + case UNMODIFIED -> AbstractDataTreeCandidateNode.createUnmodified(); + default -> throw new IllegalArgumentException("Unhandled node type " + type); + }; return new DataTreeCandidateWithVersion(DataTreeCandidates.newDataTreeCandidate(rootPath, rootNode), reader.getVersion()); } @@ -192,7 +170,7 @@ public final class DataTreeCandidateInputOutput { break; case WRITE: out.writeByte(WRITE); - out.writeNormalizedNode(node.getDataAfter().get()); + out.writeNormalizedNode(node.getDataAfter().orElseThrow()); break; case UNMODIFIED: out.writeByte(UNMODIFIED); @@ -230,7 +208,7 @@ public final class DataTreeCandidateInputOutput { break; case WRITE: writer.writeByte(WRITE); - writer.writeNormalizedNode(node.getDataAfter().get()); + writer.writeNormalizedNode(node.getDataAfter().orElseThrow()); break; default: throwUnhandledNodeType(node);