X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-distributed-datastore%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Fdatastore%2Fpersisted%2FShardSnapshotState.java;h=a294584227e92765fa84e3ebfe4a6cb6bc9aa5d3;hb=1d5ca4009be6c61d7b61989799037ad8f1ab7a75;hp=8f22c0ec2dc2b2fe5bed0033b2bd18657263c27d;hpb=12fcdfe39aa26dcba7fd3bb4d4c68e3d02e65c51;p=controller.git diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/persisted/ShardSnapshotState.java b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/persisted/ShardSnapshotState.java index 8f22c0ec2d..a294584227 100644 --- a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/persisted/ShardSnapshotState.java +++ b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/persisted/ShardSnapshotState.java @@ -7,13 +7,15 @@ */ package org.opendaylight.controller.cluster.datastore.persisted; -import com.google.common.base.Preconditions; +import static java.util.Objects.requireNonNull; + +import com.google.common.annotations.VisibleForTesting; import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import java.io.Externalizable; import java.io.IOException; import java.io.ObjectInput; import java.io.ObjectOutput; -import javax.annotation.Nonnull; +import org.eclipse.jdt.annotation.NonNull; import org.opendaylight.controller.cluster.raft.persisted.Snapshot; /** @@ -47,7 +49,7 @@ public class ShardSnapshotState implements Snapshot.State { @Override public void readExternal(final ObjectInput in) throws IOException { - snapshotState = new ShardSnapshotState(ShardDataTreeSnapshot.deserialize(in)); + snapshotState = ShardDataTreeSnapshot.deserialize(in); } private Object readResolve() { @@ -58,17 +60,28 @@ public class ShardSnapshotState implements Snapshot.State { @SuppressFBWarnings(value = "SE_BAD_FIELD", justification = "This field is not Serializable but this class " + "implements writeReplace to delegate serialization to a Proxy class and thus instances of this class " + "aren't serialized. FindBugs does not recognize this.") - private final ShardDataTreeSnapshot snapshot; + private final @NonNull ShardDataTreeSnapshot snapshot; + private final boolean migrated; + + @VisibleForTesting + public ShardSnapshotState(final @NonNull ShardDataTreeSnapshot snapshot, final boolean migrated) { + this.snapshot = requireNonNull(snapshot); + this.migrated = migrated; + } - public ShardSnapshotState(@Nonnull final ShardDataTreeSnapshot snapshot) { - this.snapshot = Preconditions.checkNotNull(snapshot); + public ShardSnapshotState(final @NonNull ShardDataTreeSnapshot snapshot) { + this(snapshot, false); } - @Nonnull - public ShardDataTreeSnapshot getSnapshot() { + public @NonNull ShardDataTreeSnapshot getSnapshot() { return snapshot; } + @Override + public boolean needsMigration() { + return migrated; + } + private Object writeReplace() { return new Proxy(this); }