X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-distributed-datastore%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Fdatastore%2Fshardstrategy%2FShardStrategyFactory.java;h=7b574530ee490824cf4f3a10343eea367cef6ef1;hb=55a9b9f42a14c56060f74b38f84d444c0fbfecc4;hp=8ca615003872116f84138bba22ddca177da4e28c;hpb=18ecb07132281d3152a49baf50e8c020403588f9;p=controller.git diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/shardstrategy/ShardStrategyFactory.java b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/shardstrategy/ShardStrategyFactory.java index 8ca6150038..7b574530ee 100644 --- a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/shardstrategy/ShardStrategyFactory.java +++ b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/shardstrategy/ShardStrategyFactory.java @@ -5,38 +5,48 @@ * terms of the Eclipse Public License v1.0 which accompanies this distribution, * and is available at http://www.eclipse.org/legal/epl-v10.html */ - package org.opendaylight.controller.cluster.datastore.shardstrategy; -import com.google.common.base.Preconditions; +import static com.google.common.base.Preconditions.checkState; +import static java.util.Objects.requireNonNull; + import org.opendaylight.controller.cluster.datastore.config.Configuration; +import org.opendaylight.mdsal.common.api.LogicalDatastoreType; +import org.opendaylight.mdsal.dom.api.DOMDataTreeIdentifier; import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier; public class ShardStrategyFactory { private static final String UNKNOWN_MODULE_NAME = "unknown"; private final Configuration configuration; + private final LogicalDatastoreType logicalStoreType; - public ShardStrategyFactory(final Configuration configuration) { - Preconditions.checkState(configuration != null, "configuration should not be missing"); + public ShardStrategyFactory(final Configuration configuration, final LogicalDatastoreType logicalStoreType) { + checkState(configuration != null, "configuration should not be missing"); this.configuration = configuration; + this.logicalStoreType = requireNonNull(logicalStoreType); } public ShardStrategy getStrategy(final YangInstanceIdentifier path) { - Preconditions.checkNotNull(path, "path should not be null"); - - String moduleName = getModuleName(path); - ShardStrategy shardStrategy = configuration.getStrategyForModule(moduleName); + // try with the legacy module based shard mapping + final String moduleName = getModuleName(requireNonNull(path, "path should not be null")); + final ShardStrategy shardStrategy = configuration.getStrategyForModule(moduleName); if (shardStrategy == null) { - return DefaultShardStrategy.getInstance(); + // retry with prefix based sharding + final ShardStrategy strategyForPrefix = + configuration.getStrategyForPrefix(new DOMDataTreeIdentifier(logicalStoreType, path)); + if (strategyForPrefix == null) { + return DefaultShardStrategy.getInstance(); + } + return strategyForPrefix; } return shardStrategy; } - public static ShardStrategy newShardStrategyInstance(String moduleName, String strategyName, - Configuration configuration) { - if(ModuleShardStrategy.NAME.equals(strategyName)){ + public static ShardStrategy newShardStrategyInstance(final String moduleName, final String strategyName, + final Configuration configuration) { + if (ModuleShardStrategy.NAME.equals(strategyName)) { return new ModuleShardStrategy(moduleName, configuration); } @@ -48,7 +58,7 @@ public class ShardStrategyFactory { return UNKNOWN_MODULE_NAME; } - String namespace = path.getPathArguments().iterator().next().getNodeType().getNamespace().toASCIIString(); + String namespace = path.getPathArguments().get(0).getNodeType().getNamespace().toASCIIString(); String moduleName = configuration.getModuleNameFromNameSpace(namespace); return moduleName != null ? moduleName : UNKNOWN_MODULE_NAME; }