X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-distributed-datastore%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Fdatastore%2Futils%2FPruningDataTreeModification.java;h=0e97cd958804ce632d1b45af74f7f6b4192f36c7;hb=b5cb353e3553a39f576c284119af75ffa5ea66a9;hp=a44b6861ba922e826c1e99e493c7880e316a330d;hpb=34c6032dd81c2d76720cce53478c38f5e5cdddc4;p=controller.git diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/utils/PruningDataTreeModification.java b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/utils/PruningDataTreeModification.java index a44b6861ba..0e97cd9588 100644 --- a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/utils/PruningDataTreeModification.java +++ b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/utils/PruningDataTreeModification.java @@ -10,8 +10,11 @@ package org.opendaylight.controller.cluster.datastore.utils; import com.google.common.annotations.VisibleForTesting; import com.google.common.base.Optional; +import com.google.common.base.Preconditions; +import com.google.common.collect.ForwardingObject; import java.io.IOException; import org.opendaylight.controller.cluster.datastore.node.utils.transformer.NormalizedNodePruner; +import org.opendaylight.controller.cluster.datastore.util.AbstractDataTreeModificationCursor; import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier; import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier.PathArgument; import org.opendaylight.yangtools.yang.data.api.schema.NormalizedNode; @@ -26,9 +29,9 @@ import org.slf4j.LoggerFactory; /** * The PruningDataTreeModification first removes all entries from the data which do not belong in the schemaContext - * before delegating it to the actual DataTreeModification + * before delegating it to the actual DataTreeModification. */ -public class PruningDataTreeModification implements DataTreeModification { +public class PruningDataTreeModification extends ForwardingObject implements DataTreeModification { private static final Logger LOG = LoggerFactory.getLogger(PruningDataTreeModification.class); private DataTreeModification delegate; @@ -36,16 +39,21 @@ public class PruningDataTreeModification implements DataTreeModification { private final DataTree dataTree; public PruningDataTreeModification(DataTreeModification delegate, DataTree dataTree, SchemaContext schemaContext) { - this.delegate = delegate; - this.dataTree = dataTree; - this.schemaContext = schemaContext; + this.delegate = Preconditions.checkNotNull(delegate); + this.dataTree = Preconditions.checkNotNull(dataTree); + this.schemaContext = Preconditions.checkNotNull(schemaContext); + } + + @Override + public DataTreeModification delegate() { + return delegate; } @Override public void delete(YangInstanceIdentifier yangInstanceIdentifier) { try { delegate.delete(yangInstanceIdentifier); - } catch(SchemaValidationFailedException e){ + } catch (SchemaValidationFailedException e) { LOG.warn("Node at path : {} does not exist ignoring delete", yangInstanceIdentifier); } } @@ -53,12 +61,12 @@ public class PruningDataTreeModification implements DataTreeModification { @Override public void merge(YangInstanceIdentifier yangInstanceIdentifier, NormalizedNode normalizedNode) { try { - if(YangInstanceIdentifier.EMPTY.equals(yangInstanceIdentifier)){ + if (YangInstanceIdentifier.EMPTY.equals(yangInstanceIdentifier)) { pruneAndMergeNode(yangInstanceIdentifier, normalizedNode); } else { delegate.merge(yangInstanceIdentifier, normalizedNode); } - } catch (SchemaValidationFailedException e){ + } catch (SchemaValidationFailedException e) { LOG.warn("Node at path {} was pruned during merge due to validation error: {}", yangInstanceIdentifier, e.getMessage()); @@ -70,7 +78,7 @@ public class PruningDataTreeModification implements DataTreeModification { private void pruneAndMergeNode(YangInstanceIdentifier yangInstanceIdentifier, NormalizedNode normalizedNode) { NormalizedNode pruned = pruneNormalizedNode(yangInstanceIdentifier, normalizedNode); - if(pruned != null) { + if (pruned != null) { delegate.merge(yangInstanceIdentifier, pruned); } } @@ -78,12 +86,12 @@ public class PruningDataTreeModification implements DataTreeModification { @Override public void write(YangInstanceIdentifier yangInstanceIdentifier, NormalizedNode normalizedNode) { try { - if(YangInstanceIdentifier.EMPTY.equals(yangInstanceIdentifier)){ + if (YangInstanceIdentifier.EMPTY.equals(yangInstanceIdentifier)) { pruneAndWriteNode(yangInstanceIdentifier, normalizedNode); } else { delegate.write(yangInstanceIdentifier, normalizedNode); } - } catch (SchemaValidationFailedException e){ + } catch (SchemaValidationFailedException e) { LOG.warn("Node at path : {} was pruned during write due to validation error: {}", yangInstanceIdentifier, e.getMessage()); @@ -94,7 +102,7 @@ public class PruningDataTreeModification implements DataTreeModification { private void pruneAndWriteNode(YangInstanceIdentifier yangInstanceIdentifier, NormalizedNode normalizedNode) { NormalizedNode pruned = pruneNormalizedNode(yangInstanceIdentifier, normalizedNode); - if(pruned != null) { + if (pruned != null) { delegate.write(yangInstanceIdentifier, pruned); } } @@ -139,10 +147,6 @@ public class PruningDataTreeModification implements DataTreeModification { return pruner.normalizedNode(); } - public DataTreeModification getResultingModification(){ - return delegate; - } - private static class PruningDataTreeModificationCursor extends AbstractDataTreeModificationCursor { private final DataTreeModification toModification; private final PruningDataTreeModification pruningModification; @@ -155,18 +159,18 @@ public class PruningDataTreeModification implements DataTreeModification { @Override public void write(PathArgument child, NormalizedNode data) { - YangInstanceIdentifier path = next(child); + YangInstanceIdentifier path = current().node(child); NormalizedNode prunedNode = pruningModification.pruneNormalizedNode(path, data); - if(prunedNode != null) { + if (prunedNode != null) { toModification.write(path, prunedNode); } } @Override public void merge(PathArgument child, NormalizedNode data) { - YangInstanceIdentifier path = next(child); + YangInstanceIdentifier path = current().node(child); NormalizedNode prunedNode = pruningModification.pruneNormalizedNode(path, data); - if(prunedNode != null) { + if (prunedNode != null) { toModification.merge(path, prunedNode); } } @@ -174,8 +178,8 @@ public class PruningDataTreeModification implements DataTreeModification { @Override public void delete(PathArgument child) { try { - toModification.delete(next(child)); - } catch(SchemaValidationFailedException e) { + toModification.delete(current().node(child)); + } catch (SchemaValidationFailedException e) { // Ignoring since we would've already logged this in the call to the original modification. } }