X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-distributed-datastore%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Fsharding%2FPrefixedShardConfigUpdateHandler.java;h=3e5a3adfa10ac23423fd07ed3edfe9523a56a210;hb=refs%2Fchanges%2F70%2F91770%2F4;hp=0fdd25b736d4e28dc641de5bcbfc4fa1e793e9b9;hpb=f41c5e6e6f6e10b36b1e4b1992877e38e718c8fb;p=controller.git diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/sharding/PrefixedShardConfigUpdateHandler.java b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/sharding/PrefixedShardConfigUpdateHandler.java index 0fdd25b736..3e5a3adfa1 100644 --- a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/sharding/PrefixedShardConfigUpdateHandler.java +++ b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/sharding/PrefixedShardConfigUpdateHandler.java @@ -5,23 +5,21 @@ * terms of the Eclipse Public License v1.0 which accompanies this distribution, * and is available at http://www.eclipse.org/legal/epl-v10.html */ - package org.opendaylight.controller.cluster.sharding; import static akka.actor.ActorRef.noSender; +import static java.util.Objects.requireNonNull; import static org.opendaylight.controller.cluster.datastore.utils.ClusterUtils.SHARD_PREFIX_QNAME; import static org.opendaylight.controller.cluster.datastore.utils.ClusterUtils.SHARD_REPLICAS_QNAME; import static org.opendaylight.controller.cluster.datastore.utils.ClusterUtils.SHARD_REPLICA_QNAME; import akka.actor.ActorRef; -import com.google.common.base.Preconditions; import java.util.Collection; import java.util.EnumMap; import java.util.List; import java.util.stream.Collectors; -import javax.annotation.Nonnull; import org.opendaylight.controller.cluster.access.concepts.MemberName; -import org.opendaylight.controller.cluster.datastore.AbstractDataStore; +import org.opendaylight.controller.cluster.datastore.DistributedDataStoreInterface; import org.opendaylight.controller.cluster.datastore.config.PrefixShardConfiguration; import org.opendaylight.controller.cluster.datastore.shardstrategy.PrefixShardStrategy; import org.opendaylight.controller.cluster.datastore.utils.ClusterUtils; @@ -58,11 +56,11 @@ public class PrefixedShardConfigUpdateHandler { new EnumMap<>(LogicalDatastoreType.class); public PrefixedShardConfigUpdateHandler(final ActorRef handlingActor, final MemberName memberName) { - this.handlingActor = Preconditions.checkNotNull(handlingActor); - this.memberName = Preconditions.checkNotNull(memberName); + this.handlingActor = requireNonNull(handlingActor); + this.memberName = requireNonNull(memberName); } - public void initListener(final AbstractDataStore dataStore, final LogicalDatastoreType type) { + public void initListener(final DistributedDataStoreInterface dataStore, final LogicalDatastoreType type) { registrations.put(type, dataStore.registerShardConfigListener( ClusterUtils.SHARD_LIST_PATH, new ShardConfigHandler(memberName, type, handlingActor))); } @@ -89,7 +87,7 @@ public class PrefixedShardConfigUpdateHandler { } @Override - public void onDataTreeChanged(@Nonnull final Collection changes) { + public void onDataTreeChanged(final Collection changes) { changes.forEach(this::resolveChange); } @@ -97,21 +95,19 @@ public class PrefixedShardConfigUpdateHandler { switch (candidate.getRootNode().getModificationType()) { case UNMODIFIED: break; - case SUBTREE_MODIFIED: case APPEARED: - case WRITE: - resolveWrite(candidate.getRootNode()); - break; case DELETE: case DISAPPEARED: - resolveDelete(candidate.getRootNode()); + case SUBTREE_MODIFIED: + case WRITE: + resolveModifiedRoot(candidate.getRootNode()); break; default: break; } } - private void resolveWrite(final DataTreeCandidateNode rootNode) { + private void resolveModifiedRoot(final DataTreeCandidateNode rootNode) { LOG.debug("{}: New config received {}", logName, rootNode); LOG.debug("{}: Data after: {}", logName, rootNode.getDataAfter()); @@ -183,10 +179,6 @@ public class PrefixedShardConfigUpdateHandler { handlingActor.tell(message, noSender()); } - private void resolveDelete(final DataTreeCandidateNode rootNode) { - - } - @Override public String toString() { return "ShardConfigHandler [logName=" + logName + ", handlingActor=" + handlingActor + "]";