X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-distributed-datastore%2Fsrc%2Ftest%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Fdatabroker%2Factors%2Fdds%2FDirectTransactionCommitCohortTest.java;h=1dd86b0028910beee395f43e3733647ad7294f4c;hb=refs%2Fchanges%2F61%2F96761%2F2;hp=41f48c963c3ef8a5e4b5806650da029b5707ee88;hpb=12fcdfe39aa26dcba7fd3bb4d4c68e3d02e65c51;p=controller.git diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/databroker/actors/dds/DirectTransactionCommitCohortTest.java b/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/databroker/actors/dds/DirectTransactionCommitCohortTest.java index 41f48c963c..1dd86b0028 100644 --- a/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/databroker/actors/dds/DirectTransactionCommitCohortTest.java +++ b/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/databroker/actors/dds/DirectTransactionCommitCohortTest.java @@ -7,6 +7,9 @@ */ package org.opendaylight.controller.cluster.databroker.actors.dds; +import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertNull; +import static org.junit.Assert.assertTrue; import static org.mockito.Mockito.verify; import static org.opendaylight.controller.cluster.databroker.actors.dds.TestUtils.CLIENT_ID; import static org.opendaylight.controller.cluster.databroker.actors.dds.TestUtils.HISTORY_ID; @@ -20,11 +23,11 @@ import com.google.common.primitives.UnsignedLong; import com.google.common.util.concurrent.ListenableFuture; import java.util.Optional; import org.junit.After; -import org.junit.Assert; import org.junit.Before; import org.junit.Test; +import org.junit.runner.RunWith; import org.mockito.Mock; -import org.mockito.MockitoAnnotations; +import org.mockito.junit.MockitoJUnitRunner; import org.opendaylight.controller.cluster.access.ABIVersion; import org.opendaylight.controller.cluster.access.client.AbstractClientConnection; import org.opendaylight.controller.cluster.access.client.AccessClientUtil; @@ -34,6 +37,7 @@ import org.opendaylight.controller.cluster.access.commands.PersistenceProtocol; import org.opendaylight.controller.cluster.access.commands.TransactionCommitSuccess; import org.opendaylight.controller.cluster.access.concepts.RequestSuccess; +@RunWith(MockitoJUnitRunner.StrictStubs.class) public class DirectTransactionCommitCohortTest { private static final String PERSISTENCE_ID = "per-1"; @@ -46,7 +50,6 @@ public class DirectTransactionCommitCohortTest { @Before public void setUp() { - MockitoAnnotations.initMocks(this); system = ActorSystem.apply(); final TestProbe clientContextProbe = new TestProbe(system, "clientContext"); final ClientActorContext context = @@ -66,32 +69,32 @@ public class DirectTransactionCommitCohortTest { public void testCanCommit() throws Exception { final ListenableFuture canCommit = cohort.canCommit(); final ModifyTransactionRequest request = transaction.expectTransactionRequest(ModifyTransactionRequest.class); - Assert.assertTrue(request.getPersistenceProtocol().isPresent()); - Assert.assertEquals(PersistenceProtocol.SIMPLE, request.getPersistenceProtocol().get()); + assertTrue(request.getPersistenceProtocol().isPresent()); + assertEquals(PersistenceProtocol.SIMPLE, request.getPersistenceProtocol().get()); final RequestSuccess success = new TransactionCommitSuccess(transaction.getTransaction().getIdentifier(), transaction.getLastReceivedMessage().getSequence()); transaction.replySuccess(success); - Assert.assertTrue(getWithTimeout(canCommit)); + assertEquals(Boolean.TRUE, getWithTimeout(canCommit)); } @Test public void testPreCommit() throws Exception { final ListenableFuture preCommit = cohort.preCommit(); - Assert.assertNull(getWithTimeout(preCommit)); + assertNull(getWithTimeout(preCommit)); } @Test public void testAbort() throws Exception { final ListenableFuture abort = cohort.abort(); verify(history).onTransactionComplete(transaction.getTransaction().getIdentifier()); - Assert.assertNull(getWithTimeout(abort)); + assertNull(getWithTimeout(abort)); } @Test public void testCommit() throws Exception { final ListenableFuture commit = cohort.commit(); verify(history).onTransactionComplete(transaction.getTransaction().getIdentifier()); - Assert.assertNull(getWithTimeout(commit)); + assertNull(getWithTimeout(commit)); } private static TransactionTester createTransactionTester(final TestProbe backendProbe,