X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-distributed-datastore%2Fsrc%2Ftest%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Fdatastore%2FDataTreeChangeListenerActorTest.java;h=726b29007a426f734f539b069945141979f3d207;hb=bd11e415d86b815a30e3559e199f1ad4637bd02b;hp=6b8658cc4989e39be2f42a935c227389a08be07c;hpb=5464f50be733df1bbbe31cf05665d542d3b7c5e7;p=controller.git diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/DataTreeChangeListenerActorTest.java b/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/DataTreeChangeListenerActorTest.java index 6b8658cc49..726b29007a 100644 --- a/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/DataTreeChangeListenerActorTest.java +++ b/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/DataTreeChangeListenerActorTest.java @@ -7,10 +7,12 @@ */ package org.opendaylight.controller.cluster.datastore; +import static org.opendaylight.controller.md.cluster.datastore.model.TestModel.TEST_PATH; + import akka.actor.ActorRef; import akka.actor.DeadLetter; import akka.actor.Props; -import akka.testkit.JavaTestKit; +import akka.testkit.javadsl.TestKit; import com.google.common.collect.ImmutableList; import org.junit.Assert; import org.junit.Test; @@ -19,24 +21,24 @@ import org.mockito.Mockito; import org.opendaylight.controller.cluster.datastore.messages.DataTreeChanged; import org.opendaylight.controller.cluster.datastore.messages.DataTreeChangedReply; import org.opendaylight.controller.cluster.datastore.messages.EnableNotification; -import org.opendaylight.controller.md.sal.dom.api.DOMDataTreeChangeListener; +import org.opendaylight.mdsal.dom.api.DOMDataTreeChangeListener; import org.opendaylight.yangtools.yang.data.api.schema.tree.DataTreeCandidate; public class DataTreeChangeListenerActorTest extends AbstractActorTest { @Test public void testDataChangedWhenNotificationsAreEnabled() { - new JavaTestKit(getSystem()) { + new TestKit(getSystem()) { { final DataTreeCandidate mockTreeCandidate = Mockito.mock(DataTreeCandidate.class); final ImmutableList mockCandidates = ImmutableList.of(mockTreeCandidate); final DOMDataTreeChangeListener mockListener = Mockito.mock(DOMDataTreeChangeListener.class); - final Props props = DataTreeChangeListenerActor.props(mockListener); + final Props props = DataTreeChangeListenerActor.props(mockListener, TEST_PATH); final ActorRef subject = getSystem().actorOf(props, "testDataTreeChangedNotificationsEnabled"); // Let the DataChangeListener know that notifications should be // enabled - subject.tell(new EnableNotification(true), getRef()); + subject.tell(new EnableNotification(true, "test"), getRef()); subject.tell(new DataTreeChanged(mockCandidates), getRef()); @@ -49,37 +51,34 @@ public class DataTreeChangeListenerActorTest extends AbstractActorTest { @Test public void testDataChangedWhenNotificationsAreDisabled() { - new JavaTestKit(getSystem()) { + new TestKit(getSystem()) { { final DataTreeCandidate mockTreeCandidate = Mockito.mock(DataTreeCandidate.class); final ImmutableList mockCandidates = ImmutableList.of(mockTreeCandidate); final DOMDataTreeChangeListener mockListener = Mockito.mock(DOMDataTreeChangeListener.class); - final Props props = DataTreeChangeListenerActor.props(mockListener); + final Props props = DataTreeChangeListenerActor.props(mockListener, TEST_PATH); final ActorRef subject = getSystem().actorOf(props, "testDataTreeChangedNotificationsDisabled"); subject.tell(new DataTreeChanged(mockCandidates), getRef()); - new Within(duration("1 seconds")) { - @Override - protected void run() { - expectNoMsg(); - - Mockito.verify(mockListener, Mockito.never()) - .onDataTreeChanged(Matchers.anyCollectionOf(DataTreeCandidate.class)); - } - }; + within(duration("1 seconds"), () -> { + expectNoMsg(); + Mockito.verify(mockListener, Mockito.never()) + .onDataTreeChanged(Matchers.anyCollectionOf(DataTreeCandidate.class)); + return null; + }); } }; } @Test public void testDataChangedWithNoSender() { - new JavaTestKit(getSystem()) { + new TestKit(getSystem()) { { final DataTreeCandidate mockTreeCandidate = Mockito.mock(DataTreeCandidate.class); final ImmutableList mockCandidates = ImmutableList.of(mockTreeCandidate); final DOMDataTreeChangeListener mockListener = Mockito.mock(DOMDataTreeChangeListener.class); - final Props props = DataTreeChangeListenerActor.props(mockListener); + final Props props = DataTreeChangeListenerActor.props(mockListener, TEST_PATH); final ActorRef subject = getSystem().actorOf(props, "testDataTreeChangedWithNoSender"); getSystem().eventStream().subscribe(getRef(), DeadLetter.class); @@ -107,7 +106,7 @@ public class DataTreeChangeListenerActorTest extends AbstractActorTest { @Test public void testDataChangedWithListenerRuntimeEx() { - new JavaTestKit(getSystem()) { + new TestKit(getSystem()) { { final DataTreeCandidate mockTreeCandidate1 = Mockito.mock(DataTreeCandidate.class); final ImmutableList mockCandidates1 = ImmutableList.of(mockTreeCandidate1); @@ -119,12 +118,12 @@ public class DataTreeChangeListenerActorTest extends AbstractActorTest { final DOMDataTreeChangeListener mockListener = Mockito.mock(DOMDataTreeChangeListener.class); Mockito.doThrow(new RuntimeException("mock")).when(mockListener).onDataTreeChanged(mockCandidates2); - Props props = DataTreeChangeListenerActor.props(mockListener); + Props props = DataTreeChangeListenerActor.props(mockListener, TEST_PATH); ActorRef subject = getSystem().actorOf(props, "testDataTreeChangedWithListenerRuntimeEx"); // Let the DataChangeListener know that notifications should be // enabled - subject.tell(new EnableNotification(true), getRef()); + subject.tell(new EnableNotification(true, "test"), getRef()); subject.tell(new DataTreeChanged(mockCandidates1), getRef()); expectMsgClass(DataTreeChangedReply.class);