X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-distributed-datastore%2Fsrc%2Ftest%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Fdatastore%2FLocalTransactionContextTest.java;h=1fb2f8eea57b11278806bcc9e9a4b876fd0c28cd;hb=9905bf0575ff196a531eb114e89b1bdb7226bc6c;hp=bb32aca53313bd0d88272361f15f354eb9fdc5d8;hpb=e448e4e5f1f071aa61152b2f49b239d878c0a580;p=controller.git diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/LocalTransactionContextTest.java b/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/LocalTransactionContextTest.java index bb32aca533..1fb2f8eea5 100644 --- a/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/LocalTransactionContextTest.java +++ b/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/LocalTransactionContextTest.java @@ -5,7 +5,6 @@ * terms of the Eclipse Public License v1.0 which accompanies this distribution, * and is available at http://www.eclipse.org/legal/epl-v10.html */ - package org.opendaylight.controller.cluster.datastore; import static org.junit.Assert.assertTrue; @@ -13,6 +12,7 @@ import static org.mockito.Mockito.doReturn; import static org.mockito.Mockito.doThrow; import static org.mockito.Mockito.mock; import static org.mockito.Mockito.verify; + import akka.actor.ActorSelection; import com.google.common.base.Optional; import com.google.common.util.concurrent.Futures; @@ -21,15 +21,14 @@ import org.junit.Before; import org.junit.Test; import org.mockito.Mock; import org.mockito.MockitoAnnotations; -import org.opendaylight.controller.cluster.datastore.identifiers.TransactionIdentifier; import org.opendaylight.controller.cluster.datastore.messages.DataExists; import org.opendaylight.controller.cluster.datastore.messages.ReadData; import org.opendaylight.controller.cluster.datastore.modification.DeleteModification; import org.opendaylight.controller.cluster.datastore.modification.MergeModification; import org.opendaylight.controller.cluster.datastore.modification.WriteModification; -import org.opendaylight.controller.sal.core.spi.data.DOMStoreReadTransaction; -import org.opendaylight.controller.sal.core.spi.data.DOMStoreReadWriteTransaction; -import org.opendaylight.controller.sal.core.spi.data.DOMStoreWriteTransaction; +import org.opendaylight.mdsal.dom.spi.store.DOMStoreReadTransaction; +import org.opendaylight.mdsal.dom.spi.store.DOMStoreReadWriteTransaction; +import org.opendaylight.mdsal.dom.spi.store.DOMStoreWriteTransaction; import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier; import org.opendaylight.yangtools.yang.data.api.schema.NormalizedNode; import scala.concurrent.Future; @@ -37,23 +36,21 @@ import scala.concurrent.Future; public class LocalTransactionContextTest { @Mock - OperationLimiter limiter; - - @Mock - TransactionIdentifier identifier; + private OperationLimiter limiter; @Mock - DOMStoreReadWriteTransaction readWriteTransaction; + private DOMStoreReadWriteTransaction readWriteTransaction; @Mock - LocalTransactionReadySupport mockReadySupport; + private LocalTransactionReadySupport mockReadySupport; - LocalTransactionContext localTransactionContext; + private LocalTransactionContext localTransactionContext; @Before public void setUp() { MockitoAnnotations.initMocks(this); - localTransactionContext = new LocalTransactionContext(readWriteTransaction, limiter.getIdentifier(), mockReadySupport) { + localTransactionContext = new LocalTransactionContext(readWriteTransaction, limiter.getIdentifier(), + mockReadySupport) { @Override protected DOMStoreWriteTransaction getWriteDelegate() { return readWriteTransaction; @@ -68,54 +65,58 @@ public class LocalTransactionContextTest { @Test public void testWrite() { - YangInstanceIdentifier yangInstanceIdentifier = YangInstanceIdentifier.builder().build(); + YangInstanceIdentifier yangInstanceIdentifier = YangInstanceIdentifier.EMPTY; NormalizedNode normalizedNode = mock(NormalizedNode.class); - localTransactionContext.executeModification(new WriteModification(yangInstanceIdentifier, normalizedNode)); + localTransactionContext.executeModification(new WriteModification(yangInstanceIdentifier, normalizedNode), + null); verify(readWriteTransaction).write(yangInstanceIdentifier, normalizedNode); } @Test public void testMerge() { - YangInstanceIdentifier yangInstanceIdentifier = YangInstanceIdentifier.builder().build(); + YangInstanceIdentifier yangInstanceIdentifier = YangInstanceIdentifier.EMPTY; NormalizedNode normalizedNode = mock(NormalizedNode.class); - localTransactionContext.executeModification(new MergeModification(yangInstanceIdentifier, normalizedNode)); + localTransactionContext.executeModification(new MergeModification(yangInstanceIdentifier, normalizedNode), + null); verify(readWriteTransaction).merge(yangInstanceIdentifier, normalizedNode); } @Test public void testDelete() { - YangInstanceIdentifier yangInstanceIdentifier = YangInstanceIdentifier.builder().build(); - localTransactionContext.executeModification(new DeleteModification(yangInstanceIdentifier)); + YangInstanceIdentifier yangInstanceIdentifier = YangInstanceIdentifier.EMPTY; + localTransactionContext.executeModification(new DeleteModification(yangInstanceIdentifier), null); verify(readWriteTransaction).delete(yangInstanceIdentifier); } @Test public void testRead() { - YangInstanceIdentifier yangInstanceIdentifier = YangInstanceIdentifier.builder().build(); + YangInstanceIdentifier yangInstanceIdentifier = YangInstanceIdentifier.EMPTY; NormalizedNode normalizedNode = mock(NormalizedNode.class); - doReturn(Futures.immediateCheckedFuture(Optional.of(normalizedNode))).when(readWriteTransaction).read(yangInstanceIdentifier); + doReturn(Futures.immediateCheckedFuture(Optional.of(normalizedNode))).when(readWriteTransaction) + .read(yangInstanceIdentifier); localTransactionContext.executeRead(new ReadData(yangInstanceIdentifier, DataStoreVersions.CURRENT_VERSION), - SettableFuture.>>create()); + SettableFuture.create(), null); verify(readWriteTransaction).read(yangInstanceIdentifier); } @Test public void testExists() { - YangInstanceIdentifier yangInstanceIdentifier = YangInstanceIdentifier.builder().build(); + YangInstanceIdentifier yangInstanceIdentifier = YangInstanceIdentifier.EMPTY; doReturn(Futures.immediateCheckedFuture(true)).when(readWriteTransaction).exists(yangInstanceIdentifier); localTransactionContext.executeRead(new DataExists(yangInstanceIdentifier, DataStoreVersions.CURRENT_VERSION), - SettableFuture.create()); + SettableFuture.create(), null); verify(readWriteTransaction).exists(yangInstanceIdentifier); } @Test public void testReady() { final LocalThreePhaseCommitCohort mockCohort = mock(LocalThreePhaseCommitCohort.class); - doReturn(akka.dispatch.Futures.successful(null)).when(mockCohort).initiateCoordinatedCommit(); + doReturn(akka.dispatch.Futures.successful(null)).when(mockCohort).initiateCoordinatedCommit( + java.util.Optional.empty()); doReturn(mockCohort).when(mockReadySupport).onTransactionReady(readWriteTransaction, null); - Future future = localTransactionContext.readyTransaction(); + Future future = localTransactionContext.readyTransaction(null, java.util.Optional.empty()); assertTrue(future.isCompleted()); verify(mockReadySupport).onTransactionReady(readWriteTransaction, null); @@ -123,13 +124,15 @@ public class LocalTransactionContextTest { @Test public void testReadyWithWriteError() { - YangInstanceIdentifier yangInstanceIdentifier = YangInstanceIdentifier.builder().build(); + YangInstanceIdentifier yangInstanceIdentifier = YangInstanceIdentifier.EMPTY; NormalizedNode normalizedNode = mock(NormalizedNode.class); RuntimeException error = new RuntimeException("mock"); doThrow(error).when(readWriteTransaction).write(yangInstanceIdentifier, normalizedNode); - localTransactionContext.executeModification(new WriteModification(yangInstanceIdentifier, normalizedNode)); - localTransactionContext.executeModification(new WriteModification(yangInstanceIdentifier, normalizedNode)); + localTransactionContext.executeModification(new WriteModification(yangInstanceIdentifier, normalizedNode), + null); + localTransactionContext.executeModification(new WriteModification(yangInstanceIdentifier, normalizedNode), + null); verify(readWriteTransaction).write(yangInstanceIdentifier, normalizedNode); @@ -138,13 +141,15 @@ public class LocalTransactionContextTest { @Test public void testReadyWithMergeError() { - YangInstanceIdentifier yangInstanceIdentifier = YangInstanceIdentifier.builder().build(); + YangInstanceIdentifier yangInstanceIdentifier = YangInstanceIdentifier.EMPTY; NormalizedNode normalizedNode = mock(NormalizedNode.class); RuntimeException error = new RuntimeException("mock"); doThrow(error).when(readWriteTransaction).merge(yangInstanceIdentifier, normalizedNode); - localTransactionContext.executeModification(new MergeModification(yangInstanceIdentifier, normalizedNode)); - localTransactionContext.executeModification(new MergeModification(yangInstanceIdentifier, normalizedNode)); + localTransactionContext.executeModification(new MergeModification(yangInstanceIdentifier, normalizedNode), + null); + localTransactionContext.executeModification(new MergeModification(yangInstanceIdentifier, normalizedNode), + null); verify(readWriteTransaction).merge(yangInstanceIdentifier, normalizedNode); @@ -153,23 +158,24 @@ public class LocalTransactionContextTest { @Test public void testReadyWithDeleteError() { - YangInstanceIdentifier yangInstanceIdentifier = YangInstanceIdentifier.builder().build(); + YangInstanceIdentifier yangInstanceIdentifier = YangInstanceIdentifier.EMPTY; RuntimeException error = new RuntimeException("mock"); doThrow(error).when(readWriteTransaction).delete(yangInstanceIdentifier); - localTransactionContext.executeModification(new DeleteModification(yangInstanceIdentifier)); - localTransactionContext.executeModification(new DeleteModification(yangInstanceIdentifier)); + localTransactionContext.executeModification(new DeleteModification(yangInstanceIdentifier), null); + localTransactionContext.executeModification(new DeleteModification(yangInstanceIdentifier), null); verify(readWriteTransaction).delete(yangInstanceIdentifier); doReadyWithExpectedError(error); } - private void doReadyWithExpectedError(RuntimeException expError) { + private void doReadyWithExpectedError(final RuntimeException expError) { LocalThreePhaseCommitCohort mockCohort = mock(LocalThreePhaseCommitCohort.class); - doReturn(akka.dispatch.Futures.successful(null)).when(mockCohort).initiateCoordinatedCommit(); + doReturn(akka.dispatch.Futures.successful(null)).when(mockCohort).initiateCoordinatedCommit( + java.util.Optional.empty()); doReturn(mockCohort).when(mockReadySupport).onTransactionReady(readWriteTransaction, expError); - localTransactionContext.readyTransaction(); + localTransactionContext.readyTransaction(null, java.util.Optional.empty()); } }