X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-distributed-datastore%2Fsrc%2Ftest%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Fdatastore%2FLocalTransactionContextTest.java;h=bb32aca53313bd0d88272361f15f354eb9fdc5d8;hb=2b43286e7f65957e6ef73fd76ccac9d5db4089cc;hp=08c4813523064441219977a2a388a1ff0ae3c2c2;hpb=c3ea6ff9c64bcd51e46767a18a1370a2b3819dca;p=controller.git diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/LocalTransactionContextTest.java b/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/LocalTransactionContextTest.java index 08c4813523..bb32aca533 100644 --- a/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/LocalTransactionContextTest.java +++ b/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/LocalTransactionContextTest.java @@ -22,6 +22,11 @@ import org.junit.Test; import org.mockito.Mock; import org.mockito.MockitoAnnotations; import org.opendaylight.controller.cluster.datastore.identifiers.TransactionIdentifier; +import org.opendaylight.controller.cluster.datastore.messages.DataExists; +import org.opendaylight.controller.cluster.datastore.messages.ReadData; +import org.opendaylight.controller.cluster.datastore.modification.DeleteModification; +import org.opendaylight.controller.cluster.datastore.modification.MergeModification; +import org.opendaylight.controller.cluster.datastore.modification.WriteModification; import org.opendaylight.controller.sal.core.spi.data.DOMStoreReadTransaction; import org.opendaylight.controller.sal.core.spi.data.DOMStoreReadWriteTransaction; import org.opendaylight.controller.sal.core.spi.data.DOMStoreWriteTransaction; @@ -65,7 +70,7 @@ public class LocalTransactionContextTest { public void testWrite() { YangInstanceIdentifier yangInstanceIdentifier = YangInstanceIdentifier.builder().build(); NormalizedNode normalizedNode = mock(NormalizedNode.class); - localTransactionContext.writeData(yangInstanceIdentifier, normalizedNode); + localTransactionContext.executeModification(new WriteModification(yangInstanceIdentifier, normalizedNode)); verify(readWriteTransaction).write(yangInstanceIdentifier, normalizedNode); } @@ -73,14 +78,14 @@ public class LocalTransactionContextTest { public void testMerge() { YangInstanceIdentifier yangInstanceIdentifier = YangInstanceIdentifier.builder().build(); NormalizedNode normalizedNode = mock(NormalizedNode.class); - localTransactionContext.mergeData(yangInstanceIdentifier, normalizedNode); + localTransactionContext.executeModification(new MergeModification(yangInstanceIdentifier, normalizedNode)); verify(readWriteTransaction).merge(yangInstanceIdentifier, normalizedNode); } @Test public void testDelete() { YangInstanceIdentifier yangInstanceIdentifier = YangInstanceIdentifier.builder().build(); - localTransactionContext.deleteData(yangInstanceIdentifier); + localTransactionContext.executeModification(new DeleteModification(yangInstanceIdentifier)); verify(readWriteTransaction).delete(yangInstanceIdentifier); } @@ -90,7 +95,8 @@ public class LocalTransactionContextTest { YangInstanceIdentifier yangInstanceIdentifier = YangInstanceIdentifier.builder().build(); NormalizedNode normalizedNode = mock(NormalizedNode.class); doReturn(Futures.immediateCheckedFuture(Optional.of(normalizedNode))).when(readWriteTransaction).read(yangInstanceIdentifier); - localTransactionContext.readData(yangInstanceIdentifier, SettableFuture.>>create()); + localTransactionContext.executeRead(new ReadData(yangInstanceIdentifier, DataStoreVersions.CURRENT_VERSION), + SettableFuture.>>create()); verify(readWriteTransaction).read(yangInstanceIdentifier); } @@ -98,7 +104,8 @@ public class LocalTransactionContextTest { public void testExists() { YangInstanceIdentifier yangInstanceIdentifier = YangInstanceIdentifier.builder().build(); doReturn(Futures.immediateCheckedFuture(true)).when(readWriteTransaction).exists(yangInstanceIdentifier); - localTransactionContext.dataExists(yangInstanceIdentifier, SettableFuture. create()); + localTransactionContext.executeRead(new DataExists(yangInstanceIdentifier, DataStoreVersions.CURRENT_VERSION), + SettableFuture.create()); verify(readWriteTransaction).exists(yangInstanceIdentifier); } @@ -106,12 +113,12 @@ public class LocalTransactionContextTest { public void testReady() { final LocalThreePhaseCommitCohort mockCohort = mock(LocalThreePhaseCommitCohort.class); doReturn(akka.dispatch.Futures.successful(null)).when(mockCohort).initiateCoordinatedCommit(); - doReturn(mockCohort).when(mockReadySupport).onTransactionReady(readWriteTransaction); + doReturn(mockCohort).when(mockReadySupport).onTransactionReady(readWriteTransaction, null); Future future = localTransactionContext.readyTransaction(); assertTrue(future.isCompleted()); - verify(mockReadySupport).onTransactionReady(readWriteTransaction); + verify(mockReadySupport).onTransactionReady(readWriteTransaction, null); } @Test @@ -121,8 +128,8 @@ public class LocalTransactionContextTest { RuntimeException error = new RuntimeException("mock"); doThrow(error).when(readWriteTransaction).write(yangInstanceIdentifier, normalizedNode); - localTransactionContext.writeData(yangInstanceIdentifier, normalizedNode); - localTransactionContext.writeData(yangInstanceIdentifier, normalizedNode); + localTransactionContext.executeModification(new WriteModification(yangInstanceIdentifier, normalizedNode)); + localTransactionContext.executeModification(new WriteModification(yangInstanceIdentifier, normalizedNode)); verify(readWriteTransaction).write(yangInstanceIdentifier, normalizedNode); @@ -136,8 +143,8 @@ public class LocalTransactionContextTest { RuntimeException error = new RuntimeException("mock"); doThrow(error).when(readWriteTransaction).merge(yangInstanceIdentifier, normalizedNode); - localTransactionContext.mergeData(yangInstanceIdentifier, normalizedNode); - localTransactionContext.mergeData(yangInstanceIdentifier, normalizedNode); + localTransactionContext.executeModification(new MergeModification(yangInstanceIdentifier, normalizedNode)); + localTransactionContext.executeModification(new MergeModification(yangInstanceIdentifier, normalizedNode)); verify(readWriteTransaction).merge(yangInstanceIdentifier, normalizedNode); @@ -150,8 +157,8 @@ public class LocalTransactionContextTest { RuntimeException error = new RuntimeException("mock"); doThrow(error).when(readWriteTransaction).delete(yangInstanceIdentifier); - localTransactionContext.deleteData(yangInstanceIdentifier); - localTransactionContext.deleteData(yangInstanceIdentifier); + localTransactionContext.executeModification(new DeleteModification(yangInstanceIdentifier)); + localTransactionContext.executeModification(new DeleteModification(yangInstanceIdentifier)); verify(readWriteTransaction).delete(yangInstanceIdentifier); @@ -161,10 +168,8 @@ public class LocalTransactionContextTest { private void doReadyWithExpectedError(RuntimeException expError) { LocalThreePhaseCommitCohort mockCohort = mock(LocalThreePhaseCommitCohort.class); doReturn(akka.dispatch.Futures.successful(null)).when(mockCohort).initiateCoordinatedCommit(); - doReturn(mockCohort).when(mockReadySupport).onTransactionReady(readWriteTransaction); + doReturn(mockCohort).when(mockReadySupport).onTransactionReady(readWriteTransaction, expError); localTransactionContext.readyTransaction(); - - verify(mockCohort).setOperationError(expError); } }