X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-distributed-datastore%2Fsrc%2Ftest%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Fdatastore%2FLocalTransactionContextTest.java;h=e32d0e4642ebd3efc8cbf09199174010a7c8a4e2;hb=70b924258e6c87219c38bcfefb3781ee3d2e2d02;hp=e2d6127708171cfdb05ed562f04e7329e7b8834c;hpb=340a2d4c979ac6f8d5adff8bd9e1c9f724e7a164;p=controller.git diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/LocalTransactionContextTest.java b/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/LocalTransactionContextTest.java index e2d6127708..e32d0e4642 100644 --- a/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/LocalTransactionContextTest.java +++ b/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/LocalTransactionContextTest.java @@ -1,3 +1,11 @@ +/* + * Copyright (c) 2015 Cisco Systems, Inc. and others. All rights reserved. + * + * This program and the accompanying materials are made available under the + * terms of the Eclipse Public License v1.0 which accompanies this distribution, + * and is available at http://www.eclipse.org/legal/epl-v10.html + */ + package org.opendaylight.controller.cluster.datastore; import static org.junit.Assert.assertTrue; @@ -13,7 +21,11 @@ import org.junit.Before; import org.junit.Test; import org.mockito.Mock; import org.mockito.MockitoAnnotations; -import org.opendaylight.controller.cluster.datastore.identifiers.TransactionIdentifier; +import org.opendaylight.controller.cluster.datastore.messages.DataExists; +import org.opendaylight.controller.cluster.datastore.messages.ReadData; +import org.opendaylight.controller.cluster.datastore.modification.DeleteModification; +import org.opendaylight.controller.cluster.datastore.modification.MergeModification; +import org.opendaylight.controller.cluster.datastore.modification.WriteModification; import org.opendaylight.controller.sal.core.spi.data.DOMStoreReadTransaction; import org.opendaylight.controller.sal.core.spi.data.DOMStoreReadWriteTransaction; import org.opendaylight.controller.sal.core.spi.data.DOMStoreWriteTransaction; @@ -24,18 +36,15 @@ import scala.concurrent.Future; public class LocalTransactionContextTest { @Mock - OperationLimiter limiter; - - @Mock - TransactionIdentifier identifier; + private OperationLimiter limiter; @Mock - DOMStoreReadWriteTransaction readWriteTransaction; + private DOMStoreReadWriteTransaction readWriteTransaction; @Mock - LocalTransactionReadySupport mockReadySupport; + private LocalTransactionReadySupport mockReadySupport; - LocalTransactionContext localTransactionContext; + private LocalTransactionContext localTransactionContext; @Before public void setUp() { @@ -55,42 +64,44 @@ public class LocalTransactionContextTest { @Test public void testWrite() { - YangInstanceIdentifier yangInstanceIdentifier = YangInstanceIdentifier.builder().build(); + YangInstanceIdentifier yangInstanceIdentifier = YangInstanceIdentifier.EMPTY; NormalizedNode normalizedNode = mock(NormalizedNode.class); - localTransactionContext.writeData(yangInstanceIdentifier, normalizedNode); + localTransactionContext.executeModification(new WriteModification(yangInstanceIdentifier, normalizedNode)); verify(readWriteTransaction).write(yangInstanceIdentifier, normalizedNode); } @Test public void testMerge() { - YangInstanceIdentifier yangInstanceIdentifier = YangInstanceIdentifier.builder().build(); + YangInstanceIdentifier yangInstanceIdentifier = YangInstanceIdentifier.EMPTY; NormalizedNode normalizedNode = mock(NormalizedNode.class); - localTransactionContext.mergeData(yangInstanceIdentifier, normalizedNode); + localTransactionContext.executeModification(new MergeModification(yangInstanceIdentifier, normalizedNode)); verify(readWriteTransaction).merge(yangInstanceIdentifier, normalizedNode); } @Test public void testDelete() { - YangInstanceIdentifier yangInstanceIdentifier = YangInstanceIdentifier.builder().build(); - localTransactionContext.deleteData(yangInstanceIdentifier); + YangInstanceIdentifier yangInstanceIdentifier = YangInstanceIdentifier.EMPTY; + localTransactionContext.executeModification(new DeleteModification(yangInstanceIdentifier)); verify(readWriteTransaction).delete(yangInstanceIdentifier); } @Test public void testRead() { - YangInstanceIdentifier yangInstanceIdentifier = YangInstanceIdentifier.builder().build(); + YangInstanceIdentifier yangInstanceIdentifier = YangInstanceIdentifier.EMPTY; NormalizedNode normalizedNode = mock(NormalizedNode.class); doReturn(Futures.immediateCheckedFuture(Optional.of(normalizedNode))).when(readWriteTransaction).read(yangInstanceIdentifier); - localTransactionContext.readData(yangInstanceIdentifier, SettableFuture.>>create()); + localTransactionContext.executeRead(new ReadData(yangInstanceIdentifier, DataStoreVersions.CURRENT_VERSION), + SettableFuture.>>create()); verify(readWriteTransaction).read(yangInstanceIdentifier); } @Test public void testExists() { - YangInstanceIdentifier yangInstanceIdentifier = YangInstanceIdentifier.builder().build(); + YangInstanceIdentifier yangInstanceIdentifier = YangInstanceIdentifier.EMPTY; doReturn(Futures.immediateCheckedFuture(true)).when(readWriteTransaction).exists(yangInstanceIdentifier); - localTransactionContext.dataExists(yangInstanceIdentifier, SettableFuture. create()); + localTransactionContext.executeRead(new DataExists(yangInstanceIdentifier, DataStoreVersions.CURRENT_VERSION), + SettableFuture.create()); verify(readWriteTransaction).exists(yangInstanceIdentifier); } @@ -98,23 +109,23 @@ public class LocalTransactionContextTest { public void testReady() { final LocalThreePhaseCommitCohort mockCohort = mock(LocalThreePhaseCommitCohort.class); doReturn(akka.dispatch.Futures.successful(null)).when(mockCohort).initiateCoordinatedCommit(); - doReturn(mockCohort).when(mockReadySupport).onTransactionReady(readWriteTransaction); + doReturn(mockCohort).when(mockReadySupport).onTransactionReady(readWriteTransaction, null); Future future = localTransactionContext.readyTransaction(); assertTrue(future.isCompleted()); - verify(mockReadySupport).onTransactionReady(readWriteTransaction); + verify(mockReadySupport).onTransactionReady(readWriteTransaction, null); } @Test public void testReadyWithWriteError() { - YangInstanceIdentifier yangInstanceIdentifier = YangInstanceIdentifier.builder().build(); + YangInstanceIdentifier yangInstanceIdentifier = YangInstanceIdentifier.EMPTY; NormalizedNode normalizedNode = mock(NormalizedNode.class); RuntimeException error = new RuntimeException("mock"); doThrow(error).when(readWriteTransaction).write(yangInstanceIdentifier, normalizedNode); - localTransactionContext.writeData(yangInstanceIdentifier, normalizedNode); - localTransactionContext.writeData(yangInstanceIdentifier, normalizedNode); + localTransactionContext.executeModification(new WriteModification(yangInstanceIdentifier, normalizedNode)); + localTransactionContext.executeModification(new WriteModification(yangInstanceIdentifier, normalizedNode)); verify(readWriteTransaction).write(yangInstanceIdentifier, normalizedNode); @@ -123,13 +134,13 @@ public class LocalTransactionContextTest { @Test public void testReadyWithMergeError() { - YangInstanceIdentifier yangInstanceIdentifier = YangInstanceIdentifier.builder().build(); + YangInstanceIdentifier yangInstanceIdentifier = YangInstanceIdentifier.EMPTY; NormalizedNode normalizedNode = mock(NormalizedNode.class); RuntimeException error = new RuntimeException("mock"); doThrow(error).when(readWriteTransaction).merge(yangInstanceIdentifier, normalizedNode); - localTransactionContext.mergeData(yangInstanceIdentifier, normalizedNode); - localTransactionContext.mergeData(yangInstanceIdentifier, normalizedNode); + localTransactionContext.executeModification(new MergeModification(yangInstanceIdentifier, normalizedNode)); + localTransactionContext.executeModification(new MergeModification(yangInstanceIdentifier, normalizedNode)); verify(readWriteTransaction).merge(yangInstanceIdentifier, normalizedNode); @@ -138,12 +149,12 @@ public class LocalTransactionContextTest { @Test public void testReadyWithDeleteError() { - YangInstanceIdentifier yangInstanceIdentifier = YangInstanceIdentifier.builder().build(); + YangInstanceIdentifier yangInstanceIdentifier = YangInstanceIdentifier.EMPTY; RuntimeException error = new RuntimeException("mock"); doThrow(error).when(readWriteTransaction).delete(yangInstanceIdentifier); - localTransactionContext.deleteData(yangInstanceIdentifier); - localTransactionContext.deleteData(yangInstanceIdentifier); + localTransactionContext.executeModification(new DeleteModification(yangInstanceIdentifier)); + localTransactionContext.executeModification(new DeleteModification(yangInstanceIdentifier)); verify(readWriteTransaction).delete(yangInstanceIdentifier); @@ -153,10 +164,8 @@ public class LocalTransactionContextTest { private void doReadyWithExpectedError(RuntimeException expError) { LocalThreePhaseCommitCohort mockCohort = mock(LocalThreePhaseCommitCohort.class); doReturn(akka.dispatch.Futures.successful(null)).when(mockCohort).initiateCoordinatedCommit(); - doReturn(mockCohort).when(mockReadySupport).onTransactionReady(readWriteTransaction); + doReturn(mockCohort).when(mockReadySupport).onTransactionReady(readWriteTransaction, expError); localTransactionContext.readyTransaction(); - - verify(mockCohort).setOperationError(expError); } }