X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-distributed-datastore%2Fsrc%2Ftest%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Fdatastore%2FRemoteTransactionContextTest.java;h=6eedc7d8add6a9a9e6495234f8c3f81262dac0c6;hb=7ce039b3e55d153fc75bc88198c49536ab83befc;hp=93c83a463315aa771e40e653d9742be75ce30ab3;hpb=466078ab1dc8a8cc2981b161051f6edecd6af85a;p=controller.git diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/RemoteTransactionContextTest.java b/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/RemoteTransactionContextTest.java index 93c83a4633..6eedc7d8ad 100644 --- a/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/RemoteTransactionContextTest.java +++ b/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/RemoteTransactionContextTest.java @@ -34,8 +34,7 @@ import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier import org.opendaylight.controller.cluster.datastore.config.Configuration; import org.opendaylight.controller.cluster.datastore.messages.BatchedModifications; import org.opendaylight.controller.cluster.datastore.messages.DataExists; -import org.opendaylight.controller.cluster.datastore.modification.DeleteModification; -import org.opendaylight.controller.cluster.datastore.utils.ActorContext; +import org.opendaylight.controller.cluster.datastore.utils.ActorUtils; import scala.concurrent.Await; import scala.concurrent.Future; import scala.concurrent.duration.FiniteDuration; @@ -47,20 +46,19 @@ public class RemoteTransactionContextTest extends AbstractActorTest { private static final TransactionIdentifier TX_ID = new TransactionIdentifier(new LocalHistoryIdentifier( ClientIdentifier.create(FrontendIdentifier.create(MemberName.forName("test"), FrontendType.forName("test")), 0), 0), 0); - private static final DeleteModification DELETE = new DeleteModification(DataStoreVersions.CURRENT_VERSION); private OperationLimiter limiter; private RemoteTransactionContext txContext; - private ActorContext actorContext; + private ActorUtils actorUtils; private TestKit kit; @Before public void before() { kit = new TestKit(getSystem()); - actorContext = Mockito.spy(new ActorContext(getSystem(), kit.getRef(), mock(ClusterWrapper.class), + actorUtils = Mockito.spy(new ActorUtils(getSystem(), kit.getRef(), mock(ClusterWrapper.class), mock(Configuration.class))); limiter = new OperationLimiter(TX_ID, 4, 0); - txContext = new RemoteTransactionContext(TX_ID, actorContext.actorSelection(kit.getRef().path()), actorContext, + txContext = new RemoteTransactionContext(TX_ID, actorUtils.actorSelection(kit.getRef().path()), actorUtils, DataStoreVersions.CURRENT_VERSION, limiter); txContext.operationHandOffComplete(); } @@ -72,8 +70,8 @@ public class RemoteTransactionContextTest extends AbstractActorTest { */ @Test public void testLimiterOnFailure() throws TimeoutException, InterruptedException { - txContext.executeModification(DELETE, null); - txContext.executeModification(DELETE, null); + txContext.executeDelete(null, null); + txContext.executeDelete(null, null); assertEquals(2, limiter.availablePermits()); final Future sendFuture = txContext.sendBatchedModifications(); @@ -83,14 +81,14 @@ public class RemoteTransactionContextTest extends AbstractActorTest { assertEquals(2, msg.getModifications().size()); assertEquals(1, msg.getTotalMessagesSent()); sendReply(new Failure(new NullPointerException())); - assertFuture(sendFuture, new OnComplete() { + assertFuture(sendFuture, new OnComplete<>() { @Override public void onComplete(final Throwable failure, final Object success) { assertTrue(failure instanceof NullPointerException); assertEquals(4, limiter.availablePermits()); // The transaction has failed, no throttling should occur - txContext.executeModification(DELETE, null); + txContext.executeDelete(null, null); assertEquals(4, limiter.availablePermits()); // Executing a read should result in immediate failure @@ -115,7 +113,7 @@ public class RemoteTransactionContextTest extends AbstractActorTest { assertTrue(msg.isReady()); assertEquals(2, msg.getTotalMessagesSent()); sendReply(new Failure(new IllegalStateException())); - assertFuture(commitFuture, new OnComplete() { + assertFuture(commitFuture, new OnComplete<>() { @Override public void onComplete(final Throwable failure, final Object success) { assertTrue(failure instanceof IllegalStateException); @@ -131,12 +129,12 @@ public class RemoteTransactionContextTest extends AbstractActorTest { */ @Test public void testLimiterOnOverflowFailure() throws TimeoutException, InterruptedException { - txContext.executeModification(DELETE, null); - txContext.executeModification(DELETE, null); - txContext.executeModification(DELETE, null); - txContext.executeModification(DELETE, null); + txContext.executeDelete(null, null); + txContext.executeDelete(null, null); + txContext.executeDelete(null, null); + txContext.executeDelete(null, null); assertEquals(0, limiter.availablePermits()); - txContext.executeModification(DELETE, null); + txContext.executeDelete(null, null); // Last acquire should have failed ... assertEquals(0, limiter.availablePermits()); @@ -149,7 +147,7 @@ public class RemoteTransactionContextTest extends AbstractActorTest { assertEquals(1, msg.getTotalMessagesSent()); sendReply(new Failure(new NullPointerException())); - assertFuture(future, new OnComplete() { + assertFuture(future, new OnComplete<>() { @Override public void onComplete(final Throwable failure, final Object success) { assertTrue(failure instanceof NullPointerException);