X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-distributed-datastore%2Fsrc%2Ftest%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Fdatastore%2FShardDataTreeTest.java;h=f900ec7c05af02ca82b043d16e3a105763b6c892;hb=43f9589c1138bd3e39f0791916a2d611cd084a7b;hp=099f514e66948a76eca1e121c95963e5ddca6290;hpb=e84f63ee098fff5b02cbce1281ca0d1208f966fa;p=controller.git diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/ShardDataTreeTest.java b/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/ShardDataTreeTest.java index 099f514e66..f900ec7c05 100644 --- a/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/ShardDataTreeTest.java +++ b/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/ShardDataTreeTest.java @@ -36,7 +36,6 @@ import com.google.common.base.Ticker; import com.google.common.primitives.UnsignedLong; import com.google.common.util.concurrent.FutureCallback; import java.io.IOException; -import java.math.BigInteger; import java.util.ArrayList; import java.util.Collection; import java.util.HashMap; @@ -57,6 +56,7 @@ import org.opendaylight.controller.md.cluster.datastore.model.CarsModel; import org.opendaylight.controller.md.cluster.datastore.model.PeopleModel; import org.opendaylight.controller.md.cluster.datastore.model.SchemaContextHelper; import org.opendaylight.mdsal.dom.api.DOMDataTreeChangeListener; +import org.opendaylight.yangtools.yang.common.Empty; import org.opendaylight.yangtools.yang.common.Uint64; import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier; import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier.NodeIdentifier; @@ -194,14 +194,14 @@ public class ShardDataTreeTest extends AbstractTest { addCar(shardDataTree, "optima"); verifyOnDataTreeChanged(listener, dtc -> { - assertEquals("getModificationType", ModificationType.WRITE, dtc.getRootNode().getModificationType()); + assertEquals("getModificationType", ModificationType.WRITE, dtc.getRootNode().modificationType()); assertEquals("getRootPath", CarsModel.newCarPath("optima"), dtc.getRootPath()); }); addCar(shardDataTree, "sportage"); verifyOnDataTreeChanged(listener, dtc -> { - assertEquals("getModificationType", ModificationType.WRITE, dtc.getRootNode().getModificationType()); + assertEquals("getModificationType", ModificationType.WRITE, dtc.getRootNode().modificationType()); assertEquals("getRootPath", CarsModel.newCarPath("sportage"), dtc.getRootPath()); }); @@ -219,7 +219,7 @@ public class ShardDataTreeTest extends AbstractTest { verifyOnDataTreeChanged(listener, dtc -> { ModificationType expType = expChanges.remove(dtc.getRootPath()); assertNotNull("Got unexpected change for " + dtc.getRootPath(), expType); - assertEquals("getModificationType", expType, dtc.getRootNode().getModificationType()); + assertEquals("getModificationType", expType, dtc.getRootNode().modificationType()); }); if (!expChanges.isEmpty()) { @@ -244,21 +244,21 @@ public class ShardDataTreeTest extends AbstractTest { final ShardDataTreeCohort cohort4 = newShardDataTreeCohort(snapshot -> snapshot.write(carPath, carNode)); immediateCanCommit(cohort1); - final FutureCallback canCommitCallback2 = coordinatedCanCommit(cohort2); - final FutureCallback canCommitCallback3 = coordinatedCanCommit(cohort3); - final FutureCallback canCommitCallback4 = coordinatedCanCommit(cohort4); + final FutureCallback canCommitCallback2 = coordinatedCanCommit(cohort2); + final FutureCallback canCommitCallback3 = coordinatedCanCommit(cohort3); + final FutureCallback canCommitCallback4 = coordinatedCanCommit(cohort4); final FutureCallback preCommitCallback1 = coordinatedPreCommit(cohort1); verify(preCommitCallback1).onSuccess(cohort1.getCandidate()); - verify(canCommitCallback2).onSuccess(null); + verify(canCommitCallback2).onSuccess(Empty.value()); final FutureCallback preCommitCallback2 = coordinatedPreCommit(cohort2); verify(preCommitCallback2).onSuccess(cohort2.getCandidate()); - verify(canCommitCallback3).onSuccess(null); + verify(canCommitCallback3).onSuccess(Empty.value()); final FutureCallback preCommitCallback3 = coordinatedPreCommit(cohort3); verify(preCommitCallback3).onSuccess(cohort3.getCandidate()); - verify(canCommitCallback4).onSuccess(null); + verify(canCommitCallback4).onSuccess(Empty.value()); final FutureCallback preCommitCallback4 = coordinatedPreCommit(cohort4); verify(preCommitCallback4).onSuccess(cohort4.getCandidate()); @@ -293,7 +293,7 @@ public class ShardDataTreeTest extends AbstractTest { final ShardDataTreeCohort cohort5 = newShardDataTreeCohort(snapshot -> snapshot.merge(CarsModel.BASE_PATH, CarsModel.emptyContainer())); - final FutureCallback canCommitCallback5 = coordinatedCanCommit(cohort5); + final FutureCallback canCommitCallback5 = coordinatedCanCommit(cohort5); // The payload instance doesn't matter - it just needs to be of type CommitTransactionPayload. CommitTransactionPayload mockPayload = CommitTransactionPayload.create(nextTransactionId(), @@ -309,17 +309,12 @@ public class ShardDataTreeTest extends AbstractTest { inOrder.verify(commitCallback3).onSuccess(any(UnsignedLong.class)); inOrder.verify(commitCallback4).onSuccess(any(UnsignedLong.class)); - verify(canCommitCallback5).onSuccess(null); + verify(canCommitCallback5).onSuccess(Empty.value()); final DataTreeSnapshot snapshot = shardDataTree.newReadOnlyTransaction(nextTransactionId()).getSnapshot(); - Optional optional = snapshot.readNode(carPath); - assertTrue("Car node present", optional.isPresent()); - assertEquals("Car node", carNode, optional.get()); - - optional = snapshot.readNode(PeopleModel.BASE_PATH); - assertTrue("People node present", optional.isPresent()); - assertEquals("People node", peopleNode, optional.get()); + assertEquals("Car node", Optional.of(carNode), snapshot.readNode(carPath)); + assertEquals("People node", Optional.of(peopleNode), snapshot.readNode(PeopleModel.BASE_PATH)); } @Test @@ -360,9 +355,7 @@ public class ShardDataTreeTest extends AbstractTest { final DataTreeSnapshot snapshot = shardDataTree.newReadOnlyTransaction(nextTransactionId()).getSnapshot(); - Optional optional = snapshot.readNode(carPath); - assertTrue("Car node present", optional.isPresent()); - assertEquals("Car node", carNode, optional.get()); + assertEquals("Car node", Optional.of(carNode), snapshot.readNode(carPath)); } @Test @@ -418,10 +411,10 @@ public class ShardDataTreeTest extends AbstractTest { coordinatedPreCommit(cohort2); coordinatedPreCommit(cohort3); - FutureCallback mockAbortCallback = mock(FutureCallback.class); - doNothing().when(mockAbortCallback).onSuccess(null); + FutureCallback mockAbortCallback = mock(FutureCallback.class); + doNothing().when(mockAbortCallback).onSuccess(Empty.value()); cohort2.abort(mockAbortCallback); - verify(mockAbortCallback).onSuccess(null); + verify(mockAbortCallback).onSuccess(Empty.value()); coordinatedPreCommit(cohort4); coordinatedCommit(cohort1); @@ -446,8 +439,7 @@ public class ShardDataTreeTest extends AbstractTest { final DataTreeSnapshot snapshot = shardDataTree.newReadOnlyTransaction(nextTransactionId()).getSnapshot(); Optional optional = snapshot.readNode(carPath); - assertTrue("Car node present", optional.isPresent()); - assertEquals("Car node", carNode, optional.get()); + assertEquals("Car node", Optional.of(carNode), optional); } @SuppressWarnings("unchecked") @@ -466,15 +458,15 @@ public class ShardDataTreeTest extends AbstractTest { snapshot.write(PeopleModel.BASE_PATH, peopleNode)); immediateCanCommit(cohort1); - FutureCallback canCommitCallback2 = coordinatedCanCommit(cohort2); + FutureCallback canCommitCallback2 = coordinatedCanCommit(cohort2); coordinatedPreCommit(cohort1); - verify(canCommitCallback2).onSuccess(null); + verify(canCommitCallback2).onSuccess(Empty.value()); - FutureCallback mockAbortCallback = mock(FutureCallback.class); - doNothing().when(mockAbortCallback).onSuccess(null); + FutureCallback mockAbortCallback = mock(FutureCallback.class); + doNothing().when(mockAbortCallback).onSuccess(Empty.value()); cohort1.abort(mockAbortCallback); - verify(mockAbortCallback).onSuccess(null); + verify(mockAbortCallback).onSuccess(Empty.value()); FutureCallback preCommitCallback2 = coordinatedPreCommit(cohort2); verify(preCommitCallback2).onFailure(any(Throwable.class)); @@ -486,15 +478,14 @@ public class ShardDataTreeTest extends AbstractTest { final DataTreeSnapshot snapshot = shardDataTree.newReadOnlyTransaction(nextTransactionId()).getSnapshot(); Optional optional = snapshot.readNode(PeopleModel.BASE_PATH); - assertTrue("People node present", optional.isPresent()); - assertEquals("People node", peopleNode, optional.get()); + assertEquals("People node", Optional.of(peopleNode), optional); } @Test public void testUintCommitPayload() throws IOException { shardDataTree.applyRecoveryPayload(CommitTransactionPayload.create(nextTransactionId(), - DataTreeCandidates.fromNormalizedNode(YangInstanceIdentifier.empty(), bigIntegerRoot()), - PayloadVersion.SODIUM_SR1)); + DataTreeCandidates.fromNormalizedNode(YangInstanceIdentifier.of(), bigIntegerRoot()), + PayloadVersion.POTASSIUM)); assertCarsUint64(); } @@ -520,7 +511,7 @@ public class ShardDataTreeTest extends AbstractTest { .withNodeIdentifier(new NodeIdentifier(CarsModel.BASE_QNAME)) .withChild(Builders.mapBuilder() .withNodeIdentifier(new NodeIdentifier(CarsModel.CAR_QNAME)) - .withChild(createCar("one", BigInteger.ONE)) + .withChild(createCar("one", Uint64.ONE)) .build()) .build()); mod.ready(); @@ -529,7 +520,7 @@ public class ShardDataTreeTest extends AbstractTest { dataTree.commit(first); mod = dataTree.takeSnapshot().newModification(); - mod.write(CarsModel.newCarPath("two"), createCar("two", BigInteger.TWO)); + mod.write(CarsModel.newCarPath("two"), createCar("two", Uint64.TWO)); mod.ready(); dataTree.validate(mod); final DataTreeCandidate second = dataTree.prepare(mod); @@ -538,7 +529,7 @@ public class ShardDataTreeTest extends AbstractTest { mod = dataTree.takeSnapshot().newModification(); mod.merge(CarsModel.CAR_LIST_PATH, Builders.mapBuilder() .withNodeIdentifier(new NodeIdentifier(CarsModel.CAR_QNAME)) - .withChild(createCar("three", BigInteger.TEN)) + .withChild(createCar("three", Uint64.TEN)) .build()); mod.ready(); dataTree.validate(mod); @@ -546,17 +537,16 @@ public class ShardDataTreeTest extends AbstractTest { dataTree.commit(third); // Apply first candidate as a snapshot - shardDataTree.applyRecoverySnapshot( - new ShardSnapshotState(new MetadataShardDataTreeSnapshot(first.getRootNode().getDataAfter().get()), true)); + shardDataTree.applyRecoverySnapshot(new ShardSnapshotState( + new MetadataShardDataTreeSnapshot(first.getRootNode().getDataAfter()), true)); // Apply the other two snapshots as transactions shardDataTree.applyRecoveryPayload(CommitTransactionPayload.create(nextTransactionId(), second, - PayloadVersion.SODIUM_SR1)); + PayloadVersion.POTASSIUM)); shardDataTree.applyRecoveryPayload(CommitTransactionPayload.create(nextTransactionId(), third, - PayloadVersion.SODIUM_SR1)); + PayloadVersion.POTASSIUM)); // Verify uint translation final DataTreeSnapshot snapshot = shardDataTree.newReadOnlyTransaction(nextTransactionId()).getSnapshot(); - final NormalizedNode cars = snapshot.readNode(CarsModel.CAR_LIST_PATH).get(); assertEquals(Builders.mapBuilder() .withNodeIdentifier(new NodeIdentifier(CarsModel.CAR_QNAME)) @@ -564,12 +554,12 @@ public class ShardDataTreeTest extends AbstractTest { .withChild(createCar("one", Uint64.ONE)) .withChild(createCar("two", Uint64.TWO)) .withChild(createCar("three", Uint64.TEN)) - .build(), cars); + .build(), snapshot.readNode(CarsModel.CAR_LIST_PATH).orElseThrow()); } private void assertCarsUint64() { final DataTreeSnapshot snapshot = shardDataTree.newReadOnlyTransaction(nextTransactionId()).getSnapshot(); - final NormalizedNode cars = snapshot.readNode(CarsModel.CAR_LIST_PATH).get(); + final NormalizedNode cars = snapshot.readNode(CarsModel.CAR_LIST_PATH).orElseThrow(); assertEquals(Builders.mapBuilder() .withNodeIdentifier(new NodeIdentifier(CarsModel.CAR_QNAME)) @@ -580,25 +570,24 @@ public class ShardDataTreeTest extends AbstractTest { private static ContainerNode bigIntegerRoot() { return Builders.containerBuilder() - .withNodeIdentifier(new NodeIdentifier(SchemaContext.NAME)) - .withChild(Builders.containerBuilder() - .withNodeIdentifier(new NodeIdentifier(CarsModel.CARS_QNAME)) - .withChild(Builders.mapBuilder() - .withNodeIdentifier(new NodeIdentifier(CarsModel.CAR_QNAME)) - // Note: BigInteger - .withChild(createCar("foo", BigInteger.ONE)) - .build()) + .withNodeIdentifier(new NodeIdentifier(SchemaContext.NAME)) + .withChild(Builders.containerBuilder() + .withNodeIdentifier(new NodeIdentifier(CarsModel.CARS_QNAME)) + .withChild(Builders.mapBuilder() + .withNodeIdentifier(new NodeIdentifier(CarsModel.CAR_QNAME)) + .withChild(createCar("foo", Uint64.ONE)) .build()) - .build(); + .build()) + .build(); } private static MapEntryNode createCar(final String name, final Object value) { return Builders.mapEntryBuilder() - .withNodeIdentifier(NodeIdentifierWithPredicates.of(CarsModel.CAR_QNAME,CarsModel.CAR_NAME_QNAME, name)) - .withChild(ImmutableNodes.leafNode(CarsModel.CAR_NAME_QNAME, name)) - // Note: old BigInteger - .withChild(ImmutableNodes.leafNode(CarsModel.CAR_PRICE_QNAME, value)) - .build(); + .withNodeIdentifier(NodeIdentifierWithPredicates.of(CarsModel.CAR_QNAME, CarsModel.CAR_NAME_QNAME, name)) + .withChild(ImmutableNodes.leafNode(CarsModel.CAR_NAME_QNAME, name)) + // Note: old BigInteger + .withChild(ImmutableNodes.leafNode(CarsModel.CAR_PRICE_QNAME, value)) + .build(); } private ShardDataTreeCohort newShardDataTreeCohort(final DataTreeOperation operation) { @@ -632,7 +621,7 @@ public class ShardDataTreeTest extends AbstractTest { assertTrue(optional.isPresent()); - return optional.get(); + return optional.orElseThrow(); } private static DataTreeCandidate addCar(final ShardDataTree shardDataTree) {