X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-distributed-datastore%2Fsrc%2Ftest%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Fdatastore%2FShardTransactionFailureTest.java;h=127f9f55f89f0bedf78e2f748cd116de3819066a;hb=2d16e0bef47638ed57073a3d9f84023aa543b3c4;hp=86016a677b3f6f357e3ad8cf31c86e174a3a2a3b;hpb=a7223085cb1b53fbe96ab5508b5bdcbff2a04224;p=controller.git diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/ShardTransactionFailureTest.java b/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/ShardTransactionFailureTest.java index 86016a677b..127f9f55f8 100644 --- a/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/ShardTransactionFailureTest.java +++ b/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/ShardTransactionFailureTest.java @@ -13,28 +13,30 @@ package org.opendaylight.controller.cluster.datastore; import akka.actor.ActorRef; import akka.actor.Props; import akka.testkit.TestActorRef; + import com.google.common.util.concurrent.ListeningExecutorService; import com.google.common.util.concurrent.MoreExecutors; -import org.junit.Assert; + +import org.junit.BeforeClass; import org.junit.Test; -import org.opendaylight.controller.cluster.datastore.messages.DeleteData; +import org.opendaylight.controller.cluster.datastore.identifiers.ShardIdentifier; import org.opendaylight.controller.md.cluster.datastore.model.TestModel; import org.opendaylight.controller.md.sal.common.api.data.ReadFailedException; import org.opendaylight.controller.md.sal.dom.store.impl.InMemoryDOMDataStore; import org.opendaylight.controller.protobuff.messages.common.NormalizedNodeMessages; import org.opendaylight.controller.protobuff.messages.transaction.ShardTransactionMessages; import org.opendaylight.yangtools.yang.model.api.SchemaContext; + import scala.concurrent.Await; import scala.concurrent.Future; import scala.concurrent.duration.Duration; import java.util.Collections; - -import static org.junit.Assert.assertEquals; -import static org.junit.Assert.assertTrue; +import java.util.concurrent.TimeUnit; /** * Covers negative test cases + * * @author Basheeruddin Ahmed */ public class ShardTransactionFailureTest extends AbstractActorTest { @@ -48,37 +50,15 @@ public class ShardTransactionFailureTest extends AbstractActorTest { private static final SchemaContext testSchemaContext = TestModel.createTestContext(); - static { - store.onGlobalContextUpdated(testSchemaContext); - } + private static final ShardIdentifier SHARD_IDENTIFIER = + ShardIdentifier.builder().memberName("member-1") + .shardName("inventory").type("operational").build(); + private final ShardContext shardContext = new ShardContext(); - @Test - public void testNegativePerformingWriteOperationOnReadTransaction() - throws Exception { - try { - - final ActorRef - shard = getSystem() - .actorOf(Shard.props("config", Collections.EMPTY_MAP)); - final Props props = - ShardTransaction - .props(store.newReadOnlyTransaction(), shard, TestModel - .createTestContext()); - final TestActorRef subject = TestActorRef.apply(props, getSystem()); - - subject - .receive(new DeleteData(TestModel.TEST_PATH).toSerializable(), - ActorRef.noSender()); - Assert.assertFalse(true); - - - } catch (Exception cs) { - assertEquals(cs.getClass().getSimpleName(), - Exception.class.getSimpleName()); - assertTrue(cs.getMessage().startsWith( - "ShardTransaction:handleRecieve received an unknown message")); - } + @BeforeClass + public static void staticSetup() { + store.onGlobalContextUpdated(testSchemaContext); } @Test(expected = ReadFailedException.class) @@ -86,10 +66,9 @@ public class ShardTransactionFailureTest extends AbstractActorTest { throws Throwable { final ActorRef shard = - getSystem().actorOf(Shard.props("config", Collections.EMPTY_MAP)); - final Props props = - ShardTransaction.props(store.newReadOnlyTransaction(), shard, - TestModel.createTestContext()); + getSystem().actorOf(Shard.props(SHARD_IDENTIFIER, Collections.EMPTY_MAP, new ShardContext())); + final Props props = ShardTransaction.props(store.newReadOnlyTransaction(), shard, + testSchemaContext, shardContext); final TestActorRef subject = TestActorRef .create(getSystem(), props, @@ -103,32 +82,27 @@ public class ShardTransactionFailureTest extends AbstractActorTest { ).build(); Future future = akka.pattern.Patterns.ask(subject, readData, 3000); - assertTrue(future.isCompleted()); - Await.result(future, Duration.Zero()); + Await.result(future, Duration.create(3, TimeUnit.SECONDS)); - ((ShardReadTransaction) subject.underlyingActor()) - .forUnitTestOnlyExplicitTransactionClose(); + subject.underlyingActor().getDOMStoreTransaction().close(); future = akka.pattern.Patterns.ask(subject, readData, 3000); - Await.result(future, Duration.Zero()); - - + Await.result(future, Duration.create(3, TimeUnit.SECONDS)); } @Test(expected = ReadFailedException.class) - public void testNegativeReadWithReadWriteOnlyTransactionClosed() + public void testNegativeReadWithReadWriteTransactionClosed() throws Throwable { final ActorRef shard = - getSystem().actorOf(Shard.props("config", Collections.EMPTY_MAP)); - final Props props = - ShardTransaction.props(store.newReadWriteTransaction(), shard, - TestModel.createTestContext()); + getSystem().actorOf(Shard.props(SHARD_IDENTIFIER, Collections.EMPTY_MAP, new ShardContext())); + final Props props = ShardTransaction.props(store.newReadWriteTransaction(), shard, + testSchemaContext, shardContext); final TestActorRef subject = TestActorRef .create(getSystem(), props, - "testNegativeReadWithReadWriteOnlyTransactionClosed"); + "testNegativeReadWithReadWriteTransactionClosed"); ShardTransactionMessages.ReadData readData = ShardTransactionMessages.ReadData.newBuilder() @@ -136,30 +110,55 @@ public class ShardTransactionFailureTest extends AbstractActorTest { NormalizedNodeMessages.InstanceIdentifier.newBuilder() .build() ).build(); + Future future = akka.pattern.Patterns.ask(subject, readData, 3000); - assertTrue(future.isCompleted()); - Await.result(future, Duration.Zero()); + Await.result(future, Duration.create(3, TimeUnit.SECONDS)); - ((ShardReadWriteTransaction) subject.underlyingActor()) - .forUnitTestOnlyExplicitTransactionClose(); + subject.underlyingActor().getDOMStoreTransaction().close(); future = akka.pattern.Patterns.ask(subject, readData, 3000); - Await.result(future, Duration.Zero()); + Await.result(future, Duration.create(3, TimeUnit.SECONDS)); + } + @Test(expected = ReadFailedException.class) + public void testNegativeExistsWithReadWriteTransactionClosed() + throws Throwable { - } + final ActorRef shard = + getSystem().actorOf(Shard.props(SHARD_IDENTIFIER, Collections.EMPTY_MAP, new ShardContext())); + final Props props = ShardTransaction.props(store.newReadWriteTransaction(), shard, + testSchemaContext, shardContext); + final TestActorRef subject = TestActorRef + .create(getSystem(), props, + "testNegativeExistsWithReadWriteTransactionClosed"); + + ShardTransactionMessages.DataExists dataExists = + ShardTransactionMessages.DataExists.newBuilder() + .setInstanceIdentifierPathArguments( + NormalizedNodeMessages.InstanceIdentifier.newBuilder() + .build() + ).build(); + + Future future = + akka.pattern.Patterns.ask(subject, dataExists, 3000); + Await.result(future, Duration.create(3, TimeUnit.SECONDS)); + + subject.underlyingActor().getDOMStoreTransaction().close(); + + future = akka.pattern.Patterns.ask(subject, dataExists, 3000); + Await.result(future, Duration.create(3, TimeUnit.SECONDS)); + } @Test(expected = IllegalStateException.class) public void testNegativeWriteWithTransactionReady() throws Exception { final ActorRef shard = - getSystem().actorOf(Shard.props("config", Collections.EMPTY_MAP)); - final Props props = - ShardTransaction.props(store.newWriteOnlyTransaction(), shard, - TestModel.createTestContext()); + getSystem().actorOf(Shard.props(SHARD_IDENTIFIER, Collections.EMPTY_MAP, new ShardContext())); + final Props props = ShardTransaction.props(store.newWriteOnlyTransaction(), shard, + testSchemaContext, shardContext); final TestActorRef subject = TestActorRef .create(getSystem(), props, @@ -170,8 +169,7 @@ public class ShardTransactionFailureTest extends AbstractActorTest { Future future = akka.pattern.Patterns.ask(subject, readyTransaction, 3000); - assertTrue(future.isCompleted()); - Await.result(future, Duration.Zero()); + Await.result(future, Duration.create(3, TimeUnit.SECONDS)); ShardTransactionMessages.WriteData writeData = ShardTransactionMessages.WriteData.newBuilder() @@ -183,22 +181,17 @@ public class ShardTransactionFailureTest extends AbstractActorTest { ).build(); future = akka.pattern.Patterns.ask(subject, writeData, 3000); - assertTrue(future.isCompleted()); - Await.result(future, Duration.Zero()); - - + Await.result(future, Duration.create(3, TimeUnit.SECONDS)); } - @Test(expected = IllegalStateException.class) public void testNegativeReadWriteWithTransactionReady() throws Exception { final ActorRef shard = - getSystem().actorOf(Shard.props("config", Collections.EMPTY_MAP)); - final Props props = - ShardTransaction.props(store.newReadWriteTransaction(), shard, - TestModel.createTestContext()); + getSystem().actorOf(Shard.props(SHARD_IDENTIFIER, Collections.EMPTY_MAP, new ShardContext())); + final Props props = ShardTransaction.props(store.newReadWriteTransaction(), shard, + testSchemaContext, shardContext); final TestActorRef subject = TestActorRef .create(getSystem(), props, @@ -209,8 +202,7 @@ public class ShardTransactionFailureTest extends AbstractActorTest { Future future = akka.pattern.Patterns.ask(subject, readyTransaction, 3000); - assertTrue(future.isCompleted()); - Await.result(future, Duration.Zero()); + Await.result(future, Duration.create(3, TimeUnit.SECONDS)); ShardTransactionMessages.WriteData writeData = ShardTransactionMessages.WriteData.newBuilder() @@ -222,10 +214,7 @@ public class ShardTransactionFailureTest extends AbstractActorTest { ).build(); future = akka.pattern.Patterns.ask(subject, writeData, 3000); - assertTrue(future.isCompleted()); - Await.result(future, Duration.Zero()); - - + Await.result(future, Duration.create(3, TimeUnit.SECONDS)); } @Test(expected = IllegalStateException.class) @@ -233,10 +222,9 @@ public class ShardTransactionFailureTest extends AbstractActorTest { final ActorRef shard = - getSystem().actorOf(Shard.props("config", Collections.EMPTY_MAP)); - final Props props = - ShardTransaction.props(store.newReadWriteTransaction(), shard, - TestModel.createTestContext()); + getSystem().actorOf(Shard.props(SHARD_IDENTIFIER, Collections.EMPTY_MAP, new ShardContext())); + final Props props = ShardTransaction.props(store.newReadWriteTransaction(), shard, + testSchemaContext, shardContext); final TestActorRef subject = TestActorRef .create(getSystem(), props, "testNegativeMergeTransactionReady"); @@ -246,8 +234,7 @@ public class ShardTransactionFailureTest extends AbstractActorTest { Future future = akka.pattern.Patterns.ask(subject, readyTransaction, 3000); - assertTrue(future.isCompleted()); - Await.result(future, Duration.Zero()); + Await.result(future, Duration.create(3, TimeUnit.SECONDS)); ShardTransactionMessages.MergeData mergeData = ShardTransactionMessages.MergeData.newBuilder() @@ -259,10 +246,7 @@ public class ShardTransactionFailureTest extends AbstractActorTest { ).build(); future = akka.pattern.Patterns.ask(subject, mergeData, 3000); - assertTrue(future.isCompleted()); - Await.result(future, Duration.Zero()); - - + Await.result(future, Duration.create(3, TimeUnit.SECONDS)); } @@ -271,10 +255,9 @@ public class ShardTransactionFailureTest extends AbstractActorTest { final ActorRef shard = - getSystem().actorOf(Shard.props("config", Collections.EMPTY_MAP)); - final Props props = - ShardTransaction.props(store.newReadWriteTransaction(), shard, - TestModel.createTestContext()); + getSystem().actorOf(Shard.props(SHARD_IDENTIFIER, Collections.EMPTY_MAP, new ShardContext())); + final Props props = ShardTransaction.props(store.newReadWriteTransaction(), shard, + testSchemaContext, shardContext); final TestActorRef subject = TestActorRef .create(getSystem(), props, @@ -285,8 +268,7 @@ public class ShardTransactionFailureTest extends AbstractActorTest { Future future = akka.pattern.Patterns.ask(subject, readyTransaction, 3000); - assertTrue(future.isCompleted()); - Await.result(future, Duration.Zero()); + Await.result(future, Duration.create(3, TimeUnit.SECONDS)); ShardTransactionMessages.DeleteData deleteData = ShardTransactionMessages.DeleteData.newBuilder() @@ -295,9 +277,6 @@ public class ShardTransactionFailureTest extends AbstractActorTest { .build()).build(); future = akka.pattern.Patterns.ask(subject, deleteData, 3000); - assertTrue(future.isCompleted()); - Await.result(future, Duration.Zero()); - - + Await.result(future, Duration.create(3, TimeUnit.SECONDS)); } }