X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-distributed-datastore%2Fsrc%2Ftest%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Fdatastore%2FShardTransactionTest.java;h=d67d5b4763eb281d5e3f266ace0f610f8fba8c59;hb=a4fcc7debbd036c6e1df8c88df1c0268c62e76e4;hp=c869be82d24bcbbd0cedca4b5a6e2a9001c46fad;hpb=ec7cac6937c6beacf4d6dd9b44bb998d7b0068d4;p=controller.git diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/ShardTransactionTest.java b/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/ShardTransactionTest.java index c869be82d2..d67d5b4763 100644 --- a/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/ShardTransactionTest.java +++ b/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/ShardTransactionTest.java @@ -1,399 +1,371 @@ +/* + * Copyright (c) 2014, 2015 Cisco Systems, Inc. and others. All rights reserved. + * + * This program and the accompanying materials are made available under the + * terms of the Eclipse Public License v1.0 which accompanies this distribution, + * and is available at http://www.eclipse.org/legal/epl-v10.html + */ package org.opendaylight.controller.cluster.datastore; import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertFalse; import static org.junit.Assert.assertNotNull; +import static org.junit.Assert.assertNull; import static org.junit.Assert.assertTrue; -import java.util.Collections; +import static org.mockito.Mockito.doThrow; +import static org.mockito.Mockito.inOrder; +import static org.mockito.Mockito.mock; + +import akka.actor.ActorRef; +import akka.actor.Props; +import akka.actor.Status.Failure; +import akka.actor.Terminated; +import akka.dispatch.Dispatchers; +import akka.testkit.TestActorRef; +import akka.testkit.javadsl.TestKit; +import com.google.common.base.Throwables; +import java.time.Duration; import java.util.concurrent.TimeUnit; -import org.junit.BeforeClass; +import org.junit.Before; import org.junit.Test; -import org.opendaylight.controller.cluster.datastore.ShardWriteTransaction.GetCompositeModificationReply; -import org.opendaylight.controller.cluster.datastore.exceptions.UnknownMessageException; +import org.mockito.InOrder; +import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier; import org.opendaylight.controller.cluster.datastore.identifiers.ShardIdentifier; -import org.opendaylight.controller.cluster.datastore.jmx.mbeans.shard.ShardStats; +import org.opendaylight.controller.cluster.datastore.messages.BatchedModifications; +import org.opendaylight.controller.cluster.datastore.messages.BatchedModificationsReply; import org.opendaylight.controller.cluster.datastore.messages.CloseTransaction; import org.opendaylight.controller.cluster.datastore.messages.CloseTransactionReply; -import org.opendaylight.controller.cluster.datastore.messages.CreateTransaction; +import org.opendaylight.controller.cluster.datastore.messages.CommitTransactionReply; import org.opendaylight.controller.cluster.datastore.messages.DataExists; import org.opendaylight.controller.cluster.datastore.messages.DataExistsReply; -import org.opendaylight.controller.cluster.datastore.messages.DeleteData; -import org.opendaylight.controller.cluster.datastore.messages.DeleteDataReply; -import org.opendaylight.controller.cluster.datastore.messages.MergeData; -import org.opendaylight.controller.cluster.datastore.messages.MergeDataReply; import org.opendaylight.controller.cluster.datastore.messages.ReadData; import org.opendaylight.controller.cluster.datastore.messages.ReadDataReply; -import org.opendaylight.controller.cluster.datastore.messages.ReadyTransaction; import org.opendaylight.controller.cluster.datastore.messages.ReadyTransactionReply; -import org.opendaylight.controller.cluster.datastore.messages.WriteData; -import org.opendaylight.controller.cluster.datastore.messages.WriteDataReply; -import org.opendaylight.controller.cluster.datastore.modification.CompositeModification; import org.opendaylight.controller.cluster.datastore.modification.DeleteModification; import org.opendaylight.controller.cluster.datastore.modification.MergeModification; -import org.opendaylight.controller.cluster.datastore.modification.Modification; import org.opendaylight.controller.cluster.datastore.modification.WriteModification; +import org.opendaylight.controller.cluster.raft.TestActorFactory; import org.opendaylight.controller.md.cluster.datastore.model.TestModel; -import org.opendaylight.controller.md.sal.dom.store.impl.InMemoryDOMDataStore; -import org.opendaylight.controller.protobuff.messages.transaction.ShardTransactionMessages; import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier; +import org.opendaylight.yangtools.yang.data.api.schema.ContainerNode; +import org.opendaylight.yangtools.yang.data.api.schema.NormalizedNode; +import org.opendaylight.yangtools.yang.data.api.schema.tree.DataTreeModification; import org.opendaylight.yangtools.yang.data.impl.schema.ImmutableNodes; +import org.opendaylight.yangtools.yang.data.impl.schema.builder.impl.ImmutableContainerNodeBuilder; import org.opendaylight.yangtools.yang.model.api.SchemaContext; -import scala.concurrent.duration.Duration; -import akka.actor.ActorRef; -import akka.actor.Props; -import akka.actor.Terminated; -import akka.testkit.JavaTestKit; -import akka.testkit.TestActorRef; -import com.google.common.util.concurrent.ListeningExecutorService; -import com.google.common.util.concurrent.MoreExecutors; public class ShardTransactionTest extends AbstractActorTest { - private static ListeningExecutorService storeExecutor = - MoreExecutors.listeningDecorator(MoreExecutors.sameThreadExecutor()); - - private static final InMemoryDOMDataStore store = - new InMemoryDOMDataStore("OPER", storeExecutor, MoreExecutors.sameThreadExecutor()); - private static final SchemaContext testSchemaContext = TestModel.createTestContext(); + private static final TransactionType RO = TransactionType.READ_ONLY; + private static final TransactionType RW = TransactionType.READ_WRITE; + private static final TransactionType WO = TransactionType.WRITE_ONLY; private static final ShardIdentifier SHARD_IDENTIFIER = - ShardIdentifier.builder().memberName("member-1") - .shardName("inventory").type("config").build(); + ShardIdentifier.create("inventory", MEMBER_NAME, "config"); + private static final SchemaContext TEST_MODEL = TestModel.createTestContext(); - private DatastoreContext datastoreContext = DatastoreContext.newBuilder().build(); + private DatastoreContext datastoreContext = DatastoreContext.newBuilder().persistent(false).build(); - private final ShardStats shardStats = new ShardStats(SHARD_IDENTIFIER.toString(), "DataStore"); + private final TestActorFactory actorFactory = new TestActorFactory(getSystem()); - @BeforeClass - public static void staticSetup() { - store.onGlobalContextUpdated(testSchemaContext); - } + private TestActorRef shard; + private ShardDataTree store; + private TestKit testKit; - private ActorRef createShard(){ - return getSystem().actorOf(Shard.props(SHARD_IDENTIFIER, - Collections.EMPTY_MAP, datastoreContext, TestModel.createTestContext())); + @Before + public void setUp() { + shard = actorFactory.createTestActor(Shard.builder().id(SHARD_IDENTIFIER).datastoreContext(datastoreContext) + .schemaContextProvider(() -> TEST_MODEL).props() + .withDispatcher(Dispatchers.DefaultDispatcherId())); + ShardTestKit.waitUntilLeader(shard); + store = shard.underlyingActor().getDataStore(); + testKit = new TestKit(getSystem()); } - @Test - public void testOnReceiveReadData() throws Exception { - new JavaTestKit(getSystem()) {{ - final ActorRef shard = createShard(); - Props props = ShardTransaction.props(store.newReadOnlyTransaction(), shard, - testSchemaContext, datastoreContext, shardStats, "txn", - CreateTransaction.CURRENT_VERSION); - - testOnReceiveReadData(getSystem().actorOf(props, "testReadDataRO")); - - props = ShardTransaction.props(store.newReadWriteTransaction(), shard, - testSchemaContext, datastoreContext, shardStats, "txn", - CreateTransaction.CURRENT_VERSION); - - testOnReceiveReadData(getSystem().actorOf(props, "testReadDataRW")); - } + private ActorRef newTransactionActor(final TransactionType type, + final AbstractShardDataTreeTransaction transaction, final String name) { + Props props = ShardTransaction.props(type, transaction, shard, datastoreContext, + shard.underlyingActor().getShardMBean()); + return actorFactory.createActorNoVerify(props, name); + } - private void testOnReceiveReadData(final ActorRef transaction) { - //serialized read - transaction.tell(new ReadData(YangInstanceIdentifier.builder().build()).toSerializable(), - getRef()); + private ReadOnlyShardDataTreeTransaction readOnlyTransaction() { + return store.newReadOnlyTransaction(nextTransactionId()); + } - ShardTransactionMessages.ReadDataReply replySerialized = - expectMsgClass(duration("5 seconds"), ReadDataReply.SERIALIZABLE_CLASS); + private ReadWriteShardDataTreeTransaction readWriteTransaction() { + return store.newReadWriteTransaction(nextTransactionId()); + } - assertNotNull(ReadDataReply.fromSerializable( - testSchemaContext,YangInstanceIdentifier.builder().build(), replySerialized) - .getNormalizedNode()); + @Test + public void testOnReceiveReadData() { + testOnReceiveReadData(newTransactionActor(RO, readOnlyTransaction(), "testReadDataRO")); + testOnReceiveReadData(newTransactionActor(RW, readWriteTransaction(), "testReadDataRW")); + } - // unserialized read - transaction.tell(new ReadData(YangInstanceIdentifier.builder().build()),getRef()); + private void testOnReceiveReadData(final ActorRef transaction) { + transaction.tell(new ReadData(YangInstanceIdentifier.EMPTY, DataStoreVersions.CURRENT_VERSION), + testKit.getRef()); - ReadDataReply reply = expectMsgClass(duration("5 seconds"), ReadDataReply.class); + ReadDataReply reply = testKit.expectMsgClass(Duration.ofSeconds(5), ReadDataReply.class); - assertNotNull(reply.getNormalizedNode()); - }}; + assertNotNull(reply.getNormalizedNode()); } @Test - public void testOnReceiveReadDataWhenDataNotFound() throws Exception { - new JavaTestKit(getSystem()) {{ - final ActorRef shard = createShard(); - Props props = ShardTransaction.props( store.newReadOnlyTransaction(), shard, - testSchemaContext, datastoreContext, shardStats, "txn", - CreateTransaction.CURRENT_VERSION); - - testOnReceiveReadDataWhenDataNotFound(getSystem().actorOf( - props, "testReadDataWhenDataNotFoundRO")); - - props = ShardTransaction.props( store.newReadWriteTransaction(), shard, - testSchemaContext, datastoreContext, shardStats, "txn", - CreateTransaction.CURRENT_VERSION); - - testOnReceiveReadDataWhenDataNotFound(getSystem().actorOf( - props, "testReadDataWhenDataNotFoundRW")); - } - - private void testOnReceiveReadDataWhenDataNotFound(final ActorRef transaction) { - // serialized read - transaction.tell(new ReadData(TestModel.TEST_PATH).toSerializable(), getRef()); - - ShardTransactionMessages.ReadDataReply replySerialized = - expectMsgClass(duration("5 seconds"), ReadDataReply.SERIALIZABLE_CLASS); - - assertTrue(ReadDataReply.fromSerializable( - testSchemaContext, TestModel.TEST_PATH, replySerialized).getNormalizedNode() == null); + public void testOnReceiveReadDataWhenDataNotFound() { + testOnReceiveReadDataWhenDataNotFound(newTransactionActor(RO, readOnlyTransaction(), + "testReadDataWhenDataNotFoundRO")); + testOnReceiveReadDataWhenDataNotFound(newTransactionActor(RW, readWriteTransaction(), + "testReadDataWhenDataNotFoundRW")); + } - // unserialized read - transaction.tell(new ReadData(TestModel.TEST_PATH),getRef()); + private void testOnReceiveReadDataWhenDataNotFound(final ActorRef transaction) { + transaction.tell(new ReadData(TestModel.TEST_PATH, DataStoreVersions.CURRENT_VERSION), testKit.getRef()); - ReadDataReply reply = expectMsgClass(duration("5 seconds"), ReadDataReply.class); + ReadDataReply reply = testKit.expectMsgClass(Duration.ofSeconds(5), ReadDataReply.class); - assertTrue(reply.getNormalizedNode() == null); - }}; + assertNull(reply.getNormalizedNode()); } @Test - public void testOnReceiveDataExistsPositive() throws Exception { - new JavaTestKit(getSystem()) {{ - final ActorRef shard = createShard(); - Props props = ShardTransaction.props(store.newReadOnlyTransaction(), shard, - testSchemaContext, datastoreContext, shardStats, "txn", - CreateTransaction.CURRENT_VERSION); - - testOnReceiveDataExistsPositive(getSystem().actorOf(props, "testDataExistsPositiveRO")); - - props = ShardTransaction.props(store.newReadWriteTransaction(), shard, - testSchemaContext, datastoreContext, shardStats, "txn", - CreateTransaction.CURRENT_VERSION); + public void testOnReceiveDataExistsPositive() { + testOnReceiveDataExistsPositive(newTransactionActor(RO, readOnlyTransaction(), "testDataExistsPositiveRO")); + testOnReceiveDataExistsPositive(newTransactionActor(RW, readWriteTransaction(), "testDataExistsPositiveRW")); + } - testOnReceiveDataExistsPositive(getSystem().actorOf(props, "testDataExistsPositiveRW")); - } + private void testOnReceiveDataExistsPositive(final ActorRef transaction) { + transaction.tell(new DataExists(YangInstanceIdentifier.EMPTY, DataStoreVersions.CURRENT_VERSION), + testKit.getRef()); - private void testOnReceiveDataExistsPositive(final ActorRef transaction) { - transaction.tell(new DataExists(YangInstanceIdentifier.builder().build()).toSerializable(), - getRef()); + DataExistsReply reply = testKit.expectMsgClass(Duration.ofSeconds(5), DataExistsReply.class); - ShardTransactionMessages.DataExistsReply replySerialized = - expectMsgClass(duration("5 seconds"), ShardTransactionMessages.DataExistsReply.class); + assertTrue(reply.exists()); + } - assertTrue(DataExistsReply.fromSerializable(replySerialized).exists()); + @Test + public void testOnReceiveDataExistsNegative() { + testOnReceiveDataExistsNegative(newTransactionActor(RO, readOnlyTransaction(), "testDataExistsNegativeRO")); + testOnReceiveDataExistsNegative(newTransactionActor(RW, readWriteTransaction(), "testDataExistsNegativeRW")); + } - // unserialized read - transaction.tell(new DataExists(YangInstanceIdentifier.builder().build()),getRef()); + private void testOnReceiveDataExistsNegative(final ActorRef transaction) { + transaction.tell(new DataExists(TestModel.TEST_PATH, DataStoreVersions.CURRENT_VERSION), testKit.getRef()); - DataExistsReply reply = expectMsgClass(duration("5 seconds"), DataExistsReply.class); + DataExistsReply reply = testKit.expectMsgClass(Duration.ofSeconds(5), DataExistsReply.class); - assertTrue(reply.exists()); - }}; + assertFalse(reply.exists()); } @Test - public void testOnReceiveDataExistsNegative() throws Exception { - new JavaTestKit(getSystem()) {{ - final ActorRef shard = createShard(); - Props props = ShardTransaction.props(store.newReadOnlyTransaction(), shard, - testSchemaContext, datastoreContext, shardStats, "txn", - CreateTransaction.CURRENT_VERSION); - - testOnReceiveDataExistsNegative(getSystem().actorOf(props, "testDataExistsNegativeRO")); - - props = ShardTransaction.props(store.newReadWriteTransaction(), shard, - testSchemaContext, datastoreContext, shardStats, "txn", - CreateTransaction.CURRENT_VERSION); + public void testOnReceiveBatchedModifications() { + ShardDataTreeTransactionParent parent = mock(ShardDataTreeTransactionParent.class); + DataTreeModification mockModification = mock(DataTreeModification.class); + ReadWriteShardDataTreeTransaction mockWriteTx = new ReadWriteShardDataTreeTransaction(parent, + nextTransactionId(), mockModification); + final ActorRef transaction = newTransactionActor(RW, mockWriteTx, "testOnReceiveBatchedModifications"); + + YangInstanceIdentifier writePath = TestModel.TEST_PATH; + NormalizedNode writeData = ImmutableContainerNodeBuilder.create() + .withNodeIdentifier(new YangInstanceIdentifier.NodeIdentifier(TestModel.TEST_QNAME)) + .withChild(ImmutableNodes.leafNode(TestModel.DESC_QNAME, "foo")).build(); + + YangInstanceIdentifier mergePath = TestModel.OUTER_LIST_PATH; + NormalizedNode mergeData = ImmutableContainerNodeBuilder.create() + .withNodeIdentifier(new YangInstanceIdentifier.NodeIdentifier(TestModel.OUTER_LIST_QNAME)) + .build(); + + YangInstanceIdentifier deletePath = TestModel.TEST_PATH; + + BatchedModifications batched = new BatchedModifications(nextTransactionId(), + DataStoreVersions.CURRENT_VERSION); + batched.addModification(new WriteModification(writePath, writeData)); + batched.addModification(new MergeModification(mergePath, mergeData)); + batched.addModification(new DeleteModification(deletePath)); + + transaction.tell(batched, testKit.getRef()); + + BatchedModificationsReply reply = testKit.expectMsgClass(Duration.ofSeconds(5), + BatchedModificationsReply.class); + assertEquals("getNumBatched", 3, reply.getNumBatched()); + + InOrder inOrder = inOrder(mockModification); + inOrder.verify(mockModification).write(writePath, writeData); + inOrder.verify(mockModification).merge(mergePath, mergeData); + inOrder.verify(mockModification).delete(deletePath); + } - testOnReceiveDataExistsNegative(getSystem().actorOf(props, "testDataExistsNegativeRW")); - } + @Test + public void testOnReceiveBatchedModificationsReadyWithoutImmediateCommit() { + final ActorRef transaction = newTransactionActor(WO, readWriteTransaction(), + "testOnReceiveBatchedModificationsReadyWithoutImmediateCommit"); + + TestKit watcher = new TestKit(getSystem()); + watcher.watch(transaction); + + YangInstanceIdentifier writePath = TestModel.TEST_PATH; + NormalizedNode writeData = ImmutableContainerNodeBuilder.create() + .withNodeIdentifier(new YangInstanceIdentifier.NodeIdentifier(TestModel.TEST_QNAME)) + .withChild(ImmutableNodes.leafNode(TestModel.DESC_QNAME, "foo")).build(); + + final TransactionIdentifier tx1 = nextTransactionId(); + BatchedModifications batched = new BatchedModifications(tx1, DataStoreVersions.CURRENT_VERSION); + batched.addModification(new WriteModification(writePath, writeData)); + + transaction.tell(batched, testKit.getRef()); + BatchedModificationsReply reply = testKit.expectMsgClass(Duration.ofSeconds(5), + BatchedModificationsReply.class); + assertEquals("getNumBatched", 1, reply.getNumBatched()); + + batched = new BatchedModifications(tx1, DataStoreVersions.CURRENT_VERSION); + batched.setReady(); + batched.setTotalMessagesSent(2); + + transaction.tell(batched, testKit.getRef()); + testKit.expectMsgClass(Duration.ofSeconds(5), ReadyTransactionReply.class); + watcher.expectMsgClass(Duration.ofSeconds(5), Terminated.class); + } - private void testOnReceiveDataExistsNegative(final ActorRef transaction) { - transaction.tell(new DataExists(TestModel.TEST_PATH).toSerializable(), getRef()); + @Test + public void testOnReceiveBatchedModificationsReadyWithImmediateCommit() { + final ActorRef transaction = newTransactionActor(WO, readWriteTransaction(), + "testOnReceiveBatchedModificationsReadyWithImmediateCommit"); + + TestKit watcher = new TestKit(getSystem()); + watcher.watch(transaction); + + YangInstanceIdentifier writePath = TestModel.TEST_PATH; + NormalizedNode writeData = ImmutableContainerNodeBuilder.create() + .withNodeIdentifier(new YangInstanceIdentifier.NodeIdentifier(TestModel.TEST_QNAME)) + .withChild(ImmutableNodes.leafNode(TestModel.DESC_QNAME, "foo")).build(); + + BatchedModifications batched = new BatchedModifications(nextTransactionId(), + DataStoreVersions.CURRENT_VERSION); + batched.addModification(new WriteModification(writePath, writeData)); + batched.setReady(); + batched.setDoCommitOnReady(true); + batched.setTotalMessagesSent(1); + + transaction.tell(batched, testKit.getRef()); + testKit.expectMsgClass(Duration.ofSeconds(5), CommitTransactionReply.class); + watcher.expectMsgClass(Duration.ofSeconds(5), Terminated.class); + } - ShardTransactionMessages.DataExistsReply replySerialized = - expectMsgClass(duration("5 seconds"), ShardTransactionMessages.DataExistsReply.class); + @Test(expected = TestException.class) + public void testOnReceiveBatchedModificationsFailure() throws Exception { + ShardDataTreeTransactionParent parent = mock(ShardDataTreeTransactionParent.class); + DataTreeModification mockModification = mock(DataTreeModification.class); + ReadWriteShardDataTreeTransaction mockWriteTx = new ReadWriteShardDataTreeTransaction(parent, + nextTransactionId(), mockModification); + final ActorRef transaction = newTransactionActor(RW, mockWriteTx, + "testOnReceiveBatchedModificationsFailure"); - assertFalse(DataExistsReply.fromSerializable(replySerialized).exists()); + TestKit watcher = new TestKit(getSystem()); + watcher.watch(transaction); - // unserialized read - transaction.tell(new DataExists(TestModel.TEST_PATH),getRef()); + YangInstanceIdentifier path = TestModel.TEST_PATH; + ContainerNode node = ImmutableNodes.containerNode(TestModel.TEST_QNAME); - DataExistsReply reply = expectMsgClass(duration("5 seconds"), DataExistsReply.class); + doThrow(new TestException()).when(mockModification).write(path, node); - assertFalse(reply.exists()); - }}; - } + final TransactionIdentifier tx1 = nextTransactionId(); + BatchedModifications batched = new BatchedModifications(tx1, DataStoreVersions.CURRENT_VERSION); + batched.addModification(new WriteModification(path, node)); - private void assertModification(final ActorRef subject, - final Class modificationType) { - new JavaTestKit(getSystem()) {{ - subject.tell(new ShardWriteTransaction.GetCompositedModification(), getRef()); + transaction.tell(batched, testKit.getRef()); + testKit.expectMsgClass(Duration.ofSeconds(5), akka.actor.Status.Failure.class); - CompositeModification compositeModification = expectMsgClass(duration("3 seconds"), - GetCompositeModificationReply.class).getModification(); + batched = new BatchedModifications(tx1, DataStoreVersions.CURRENT_VERSION); + batched.setReady(); + batched.setTotalMessagesSent(2); - assertTrue(compositeModification.getModifications().size() == 1); - assertEquals(modificationType, compositeModification.getModifications().get(0).getClass()); - }}; - } + transaction.tell(batched, testKit.getRef()); + Failure failure = testKit.expectMsgClass(Duration.ofSeconds(5), akka.actor.Status.Failure.class); + watcher.expectMsgClass(Duration.ofSeconds(5), Terminated.class); - @Test - public void testOnReceiveWriteData() throws Exception { - new JavaTestKit(getSystem()) {{ - final ActorRef shard = createShard(); - final Props props = ShardTransaction.props(store.newWriteOnlyTransaction(), shard, - testSchemaContext, datastoreContext, shardStats, "txn", - CreateTransaction.CURRENT_VERSION); - final ActorRef transaction = getSystem().actorOf(props, "testWriteData"); - - transaction.tell(new WriteData(TestModel.TEST_PATH, - ImmutableNodes.containerNode(TestModel.TEST_QNAME), TestModel.createTestContext()).toSerializable(), - getRef()); - - expectMsgClass(duration("5 seconds"), ShardTransactionMessages.WriteDataReply.class); - - assertModification(transaction, WriteModification.class); - - //unserialized write - transaction.tell(new WriteData(TestModel.TEST_PATH, - ImmutableNodes.containerNode(TestModel.TEST_QNAME), - TestModel.createTestContext()), - getRef()); - - expectMsgClass(duration("5 seconds"), WriteDataReply.class); - }}; + if (failure != null) { + Throwables.propagateIfPossible(failure.cause(), Exception.class); + throw new RuntimeException(failure.cause()); + } } - @Test - public void testOnReceiveMergeData() throws Exception { - new JavaTestKit(getSystem()) {{ - final ActorRef shard = createShard(); - final Props props = ShardTransaction.props(store.newReadWriteTransaction(), shard, - testSchemaContext, datastoreContext, shardStats, "txn", - CreateTransaction.CURRENT_VERSION); - final ActorRef transaction = getSystem().actorOf(props, "testMergeData"); + @Test(expected = IllegalStateException.class) + public void testOnReceiveBatchedModificationsReadyWithIncorrectTotalMessageCount() throws Exception { + final ActorRef transaction = newTransactionActor(WO, readWriteTransaction(), + "testOnReceiveBatchedModificationsReadyWithIncorrectTotalMessageCount"); - transaction.tell(new MergeData(TestModel.TEST_PATH, - ImmutableNodes.containerNode(TestModel.TEST_QNAME), testSchemaContext).toSerializable(), - getRef()); + TestKit watcher = new TestKit(getSystem()); + watcher.watch(transaction); - expectMsgClass(duration("5 seconds"), ShardTransactionMessages.MergeDataReply.class); + BatchedModifications batched = new BatchedModifications(nextTransactionId(), + DataStoreVersions.CURRENT_VERSION); + batched.setReady(); + batched.setTotalMessagesSent(2); - assertModification(transaction, MergeModification.class); + transaction.tell(batched, testKit.getRef()); - //unserialized merge - transaction.tell(new MergeData(TestModel.TEST_PATH, - ImmutableNodes.containerNode(TestModel.TEST_QNAME), testSchemaContext), - getRef()); + Failure failure = testKit.expectMsgClass(Duration.ofSeconds(5), akka.actor.Status.Failure.class); + watcher.expectMsgClass(Duration.ofSeconds(5), Terminated.class); - expectMsgClass(duration("5 seconds"), MergeDataReply.class); - }}; + if (failure != null) { + Throwables.throwIfInstanceOf(failure.cause(), Exception.class); + Throwables.throwIfUnchecked(failure.cause()); + throw new RuntimeException(failure.cause()); + } } @Test - public void testOnReceiveDeleteData() throws Exception { - new JavaTestKit(getSystem()) {{ - final ActorRef shard = createShard(); - final Props props = ShardTransaction.props( store.newWriteOnlyTransaction(), shard, - testSchemaContext, datastoreContext, shardStats, "txn", - CreateTransaction.CURRENT_VERSION); - final ActorRef transaction = getSystem().actorOf(props, "testDeleteData"); - - transaction.tell(new DeleteData(TestModel.TEST_PATH).toSerializable(), getRef()); + public void testReadWriteTxOnReceiveCloseTransaction() { + final ActorRef transaction = newTransactionActor(RW, readWriteTransaction(), + "testReadWriteTxOnReceiveCloseTransaction"); - expectMsgClass(duration("5 seconds"), ShardTransactionMessages.DeleteDataReply.class); + testKit.watch(transaction); - assertModification(transaction, DeleteModification.class); + transaction.tell(new CloseTransaction().toSerializable(), testKit.getRef()); - //unserialized merge - transaction.tell(new DeleteData(TestModel.TEST_PATH), getRef()); - - expectMsgClass(duration("5 seconds"), DeleteDataReply.class); - }}; + testKit.expectMsgClass(Duration.ofSeconds(3), CloseTransactionReply.class); + testKit.expectTerminated(Duration.ofSeconds(3), transaction); } - @Test - public void testOnReceiveReadyTransaction() throws Exception { - new JavaTestKit(getSystem()) {{ - final ActorRef shard = createShard(); - final Props props = ShardTransaction.props( store.newReadWriteTransaction(), shard, - testSchemaContext, datastoreContext, shardStats, "txn", - CreateTransaction.CURRENT_VERSION); - final ActorRef transaction = getSystem().actorOf(props, "testReadyTransaction"); - - watch(transaction); - - transaction.tell(new ReadyTransaction().toSerializable(), getRef()); - - expectMsgAnyClassOf(duration("5 seconds"), ReadyTransactionReply.SERIALIZABLE_CLASS, - Terminated.class); - expectMsgAnyClassOf(duration("5 seconds"), ReadyTransactionReply.SERIALIZABLE_CLASS, - Terminated.class); - }}; - - // test - new JavaTestKit(getSystem()) {{ - final ActorRef shard = createShard(); - final Props props = ShardTransaction.props( store.newReadWriteTransaction(), shard, - testSchemaContext, datastoreContext, shardStats, "txn", - CreateTransaction.CURRENT_VERSION); - final ActorRef transaction = getSystem().actorOf(props, "testReadyTransaction2"); - - watch(transaction); - - transaction.tell(new ReadyTransaction(), getRef()); - - expectMsgAnyClassOf(duration("5 seconds"), ReadyTransactionReply.class, - Terminated.class); - expectMsgAnyClassOf(duration("5 seconds"), ReadyTransactionReply.class, - Terminated.class); - }}; + public void testWriteOnlyTxOnReceiveCloseTransaction() { + final ActorRef transaction = newTransactionActor(WO, readWriteTransaction(), + "testWriteTxOnReceiveCloseTransaction"); - } + testKit.watch(transaction); - @SuppressWarnings("unchecked") - @Test - public void testOnReceiveCloseTransaction() throws Exception { - new JavaTestKit(getSystem()) {{ - final ActorRef shard = createShard(); - final Props props = ShardTransaction.props(store.newReadWriteTransaction(), shard, - testSchemaContext, datastoreContext, shardStats, "txn", - CreateTransaction.CURRENT_VERSION); - final ActorRef transaction = getSystem().actorOf(props, "testCloseTransaction"); + transaction.tell(new CloseTransaction().toSerializable(), testKit.getRef()); - watch(transaction); + testKit.expectMsgClass(Duration.ofSeconds(3), CloseTransactionReply.class); + testKit.expectTerminated(Duration.ofSeconds(3), transaction); + } - transaction.tell(new CloseTransaction().toSerializable(), getRef()); + @Test + public void testReadOnlyTxOnReceiveCloseTransaction() { + final ActorRef transaction = newTransactionActor(TransactionType.READ_ONLY, readOnlyTransaction(), + "testReadOnlyTxOnReceiveCloseTransaction"); - expectMsgClass(duration("3 seconds"), CloseTransactionReply.SERIALIZABLE_CLASS); - expectTerminated(duration("3 seconds"), transaction); - }}; - } + testKit.watch(transaction); - @Test(expected=UnknownMessageException.class) - public void testNegativePerformingWriteOperationOnReadTransaction() throws Exception { - final ActorRef shard = createShard(); - final Props props = ShardTransaction.props(store.newReadOnlyTransaction(), shard, - testSchemaContext, datastoreContext, shardStats, "txn", - CreateTransaction.CURRENT_VERSION); - final TestActorRef transaction = TestActorRef.apply(props,getSystem()); + transaction.tell(new CloseTransaction().toSerializable(), testKit.getRef()); - transaction.receive(new DeleteData(TestModel.TEST_PATH).toSerializable(), ActorRef.noSender()); + testKit.expectMsgClass(Duration.ofSeconds(3), Terminated.class); } @Test public void testShardTransactionInactivity() { - datastoreContext = DatastoreContext.newBuilder().shardTransactionIdleTimeout( - Duration.create(500, TimeUnit.MILLISECONDS)).build(); + 500, TimeUnit.MILLISECONDS).build(); + + final ActorRef transaction = newTransactionActor(RW, readWriteTransaction(), + "testShardTransactionInactivity"); - new JavaTestKit(getSystem()) {{ - final ActorRef shard = createShard(); - final Props props = ShardTransaction.props(store.newReadWriteTransaction(), shard, - testSchemaContext, datastoreContext, shardStats, "txn", - CreateTransaction.CURRENT_VERSION); - final ActorRef transaction = - getSystem().actorOf(props, "testShardTransactionInactivity"); + testKit.watch(transaction); - watch(transaction); + testKit.expectMsgClass(Duration.ofSeconds(3), Terminated.class); + } - expectMsgClass(duration("3 seconds"), Terminated.class); - }}; + public static class TestException extends RuntimeException { + private static final long serialVersionUID = 1L; } }